[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[ian.rees at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

--- Comment #5 from Ian Rees  2010-11-22 04:57:57 
UTC ---
Created attachment 22480
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22480
Simple fix for bug #45621

Simple patch against gcc-4.5.1 - just adds a call to Error(), which is more
appropriate than the current implementation.

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[ian.rees at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

Ian Rees  changed:

   What|Removed |Added

 CC||ian.rees at gmail dot com

--- Comment #6 from Ian Rees  2010-11-22 05:00:05 
UTC ---
Here's a patch to implement change suggested above - added call to error().  I
left in the existing fprintf() thinking that the list of supported MCUs is
useful.

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[ian.rees at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

Ian Rees  changed:

   What|Removed |Added

  Attachment #22480|0   |1
is obsolete||

--- Comment #8 from Ian Rees  2010-11-22 16:19:44 
UTC ---
Created attachment 22484
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22484
Updated fix for bug #45261 - error() rather than fprintf(), and suggests
--target-help instead of printing supported MCUs

(In reply to comment #7)
>(In reply to comment #6)
>> Here's a patch to implement change suggested above - added call to error().  
>> I
>> left in the existing fprintf() thinking that the list of supported MCUs is
>> useful.
>
>I think just replacing the fprintf() by error() is fine.  If anyone wants
>to know the list of supported MCUs, they can always use the --target-help
>option.

Good point - I wasn't familiar with --target-help, so this one just suggests
using --target-help and errors out.  Thanks!  -Ian-