[Bug c/31233] New: obstack.h typo

2007-03-16 Thread george at houseofellery dot com
in "obstack.h" in the \include dir of the GCC 4.1.2 release, the macro
definition for the obstack_int_grow_fast function is as follows:

# define obstack_int_grow_fast(h,aint)  \
  (((int *) ((h)->next_free += sizeof (int)))[-1] = (aptr))

shouldn't the right side of the assignment in the second line be "aint"
instead?


-- 
   Summary: obstack.h typo
   Product: gcc
   Version: 4.1.2
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: c
AssignedTo: unassigned at gcc dot gnu dot org
    ReportedBy: george at houseofellery dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31233



[Bug c/31233] obstack.h typo

2007-03-16 Thread george at houseofellery dot com


--- Comment #1 from george at houseofellery dot com  2007-03-16 21:50 
---
the above is the SECOND definition of the macro function in the
"#else /* not __GNUC__ or not __STDC__ */" branch of the enclosing conditional.


-- 

george at houseofellery dot com changed:

   What|Removed |Added

 CC|        |george at houseofellery dot
   |        |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31233



[Bug c/31377] New: wrap_help error

2007-03-27 Thread george at houseofellery dot com
in the file "opts.c", in the function "wrap_help", the var 'room' is calculated
as the space remaining between the the left item field width and the rightmost
column (which defaults to 80 chars). it is then compared to the columns value:

  room = columns - 3 - MAX (col_width, item_width);
  if (room > columns)
room = 0;
  len = remaining;

I assume this is supposed to determine if the left field is taking up more than
the entire width of the line and if so, sets it to 0 as there is no room left. 
to do this, the correct code should be

  room = columns - 3 - MAX (col_width, item_width);
  if (room < 0)
room = 0;
  len = remaining;

admitedly, since all the help lines that print out don't have a left field that
comes close to taking up the entire line, this case never occurs, so this is a
trival case.


-- 
   Summary: wrap_help error
   Product: gcc
   Version: 4.1.2
Status: UNCONFIRMED
  Severity: minor
  Priority: P3
 Component: c
AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: george at houseofellery dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31377



[Bug other/33768] New: splay-tree.c typo

2007-10-13 Thread george at houseofellery dot com
in the functions "rotate_left" and "rotate_right" in  in the
libiberty package, the comments preceding the functions should have an
apostrophe in the word "grandparents" (common to both comments) changing the
meaning from plural to possessive. a small point to sure but it confounded my
understanding of how these simple functions worked for quite a bit.


-- 
   Summary: splay-tree.c typo
   Product: gcc
   Version: 4.1.2
Status: UNCONFIRMED
  Severity: minor
  Priority: P3
 Component: other
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: george at houseofellery dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33768