Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-22 Thread Wei Mi via Gcc
It is a proto library build dependency issue which didn't expose on my
platform. I fix it at
https://github.com/google/autofdo/commit/98269aee9674cc885cc5eb1bd917eb2d12731710.
Please try again.

Thanks,
Wei.

On Fri, May 21, 2021 at 6:28 PM Eugene Rozenfeld <
eugene.rozenf...@microsoft.com> wrote:

> I tried following the instructions in "2.2 Build autofdo tool for gcc" in
> https://github.com/google/autofdo#readme
> and got build failures:
>
>
>
> eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja
>
> [1/228] Building CXX object CMakeFiles/create_gcov_lib.dir/profile.cc.o
>
> FAILED: CMakeFiles/create_gcov_lib.dir/profile.cc.o
>
> /usr/bin/c++  -I../ -I../third_party/glog/src -I../third_party/abseil
> -I../third_party/perf_data_converter/src
> -I../third_party/perf_data_converter/src/quipper -I../util -I.
> -Ithird_party/glog -std=gnu++1z -MD -MT
> CMakeFiles/create_gcov_lib.dir/profile.cc.o -MF
> CMakeFiles/create_gcov_lib.dir/profile.cc.o.d -o
> CMakeFiles/create_gcov_lib.dir/profile.cc.o -c ../profile.cc
>
> In file included from
> ../third_party/perf_data_converter/src/quipper/perf_parser.h:18:0,
>
>  from ../sample_reader.h:18,
>
>  from ../profile.h:15,
>
>  from ../profile.cc:5:
>
> ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0: warning:
> "DISALLOW_COPY_AND_ASSIGN" redefined
>
> #define DISALLOW_COPY_AND_ASSIGN(TypeName) \
>
> In file included from ../profile.h:14:0,
>
>  from ../profile.cc:5:
>
> ../base/macros.h:114:0: note: this is the location of the previous
> definition
>
> #define DISALLOW_COPY_AND_ASSIGN(TypeName) \
>
> In file included from
> ../third_party/perf_data_converter/src/quipper/perf_parser.h:18:0,
>
>  from ../sample_reader.h:18,
>
>  from ../profile.h:15,
>
>  from ../profile.cc:5:
>
> ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0:
> warning: "arraysize" redefined
>
> #define arraysize(x) (sizeof(x) / sizeof(*x))
>
> In file included from ../profile.h:14:0,
>
>  from ../profile.cc:5:
>
> ../base/macros.h:162:0: note: this is the location of the previous
> definition
>
> #define arraysize(array) (sizeof(ArraySizeHelper(array)))
>
> In file included from
> ../third_party/perf_data_converter/src/quipper/perf_parser.h:21:0,
>
>  from ../sample_reader.h:18,
>
>  from ../profile.h:15,
>
>  from ../profile.cc:5:
>
> ../third_party/perf_data_converter/src/quipper/compat/proto.h:16:10: fatal
> error: perf_stat.pb.h: No such file or directory
>
> #include "perf_stat.pb.h"
>
>   ^~~~
>
> compilation terminated.
>
>
>
> What is supposed to generate perf_stat.pb.h?
>
>
>
> Thanks,
>
>
>
> Eugene
>
>
>
> *From:* Wei Mi 
> *Sent:* Monday, May 10, 2021 4:47 PM
> *To:* Andi Kleen 
> *Cc:* Hongtao Yu ; Xinliang David Li ;
> Jan Hubicka ; gcc@gcc.gnu.org; Eugene Rozenfeld <
> eugene.rozenf...@microsoft.com>; Wenlei He 
> *Subject:* [EXTERNAL] Re: State of AutoFDO in GCC
>
>
>
> https://github.com/google/autofdo
> 
> has been updated. Now create_gcov/dump_gcov are added back and can be built
> separately.
>
> Please look at "2.2 Build autofdo tool for gcc" in
> https://github.com/google/autofdo#readme
>
> 
> On Wed, Apr 28, 2021 at 10:40 PM Andi Kleen  wrote:
> >
> > On Mon, Apr 26, 2021 at 06:40:56PM +, Hongtao Yu wrote:
> > >Andi, thanks for pointing out the perf script issues. Can you please
> > >elaborate a bit on the exact issue you have seen? We’ve been using
> > >specific output of perf script such as mmap, LBR and callstack
> events
> > >filtered by process id. It works fine so far but may certainly hit
> issues
> > >in the future with extended uses.
> >
> > Okay I took a look at the latest autofdo now. It seems to be basically
> > a LLVM project now that depends on LLVM to even build with all kinds
> > of dependency hell on some old LLVM version and other packages.
> >
> > I guess gcc will really need a replacement that doesn't pull in
> > all of LLVM if it wants to continue supporting autofdo.
> >
> > I'm myself unable to bu

online doc corr.

2021-05-22 Thread Johannes Nendwich via Gcc
https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gfortran/ATOMIC_005fADD.html#ATOMIC_005fADD

"ATOMIC_ADD(ATOM, VALUE) atomically adds the value of VAR to the
variable ATOM."

--> "... adds the value of VALUE ..." ?


gcc-11-20210522 is now available

2021-05-22 Thread GCC Administrator via Gcc
Snapshot gcc-11-20210522 is now available on
  https://gcc.gnu.org/pub/gcc/snapshots/11-20210522/
and on various mirrors, see http://gcc.gnu.org/mirrors.html for details.

This snapshot has been generated from the GCC 11 git branch
with the following options: git://gcc.gnu.org/git/gcc.git branch 
releases/gcc-11 revision 907a70be204588d9d7a282a7165048df912197de

You'll find:

 gcc-11-20210522.tar.xz   Complete GCC

  SHA256=592743b6711f3a60cd33be5a40907c994acf6244d82c413c0fa84665317cf41b
  SHA1=3be7ee5a6fff30117ec6b93aef84c31dbaea0a11

Diffs from 11-20210515 are available in the diffs/ subdirectory.

When a particular snapshot is ready for public consumption the LATEST-11
link is updated and a message is sent to the gcc list.  Please do not use
a snapshot before it has been announced that way.