Re: Request for better syntax checking in lang.opt

2020-02-20 Thread Martin Liška

On 2/20/20 8:29 AM, Thomas Koenig wrote:

Hi,

having just lost a few hours on a space in lang.opt where
there was supposed to be none, leading to a new option
being silently ignored, a request:


Hello.

Sure, I can improve sanity checking. What exactly have you screwed up?



Would it be possible to improve the syntax checking for lang.opt?
It's a file that people touch only rarely, so it is likely that
they will have no experience or will already have forgotten the
gotchas they encountered the last time.


Fully agree with that!
Martin



Regards

 Thomas




Re: GCC 8.4 Status Report (2020-02-17)

2020-02-20 Thread Bernd Edlinger
On 2/19/20 10:24 AM, Richard Biener wrote:
> On Tue, Feb 18, 2020 at 8:37 PM Bernd Edlinger
>  wrote:
>>
>>> It has been almost a year since GCC 8.3 has been released and GCC 8.4
>>> release should have been released already, so we should concentrate on
>>> getting it out soon.  Unfortunately we have two P1s, one of them is
>>> waiting for reporter's input, so we might as well just ignore it unless
>>> the input is provided, but the other, C++ FE one, looks something that
>>> should be fixed.  If we get rid of the P1s, I'd like to create
>>> 8.4-rc1 on Wednesday, Feb 26th and release 8.4 the week afterwards.
>>> If you have any queued backports, please commit them to 8 branch
>>> (and 9 branch too, we'd like to release 9.3 soon too).
>>
>> Hi Jakub,
>>
>> it just occurred to me that my patch here is a kind of
>> security relevant one:
>>
>> https://gcc.gnu.org/ml/gcc-patches/2020-02/msg01060.html
>>
>> since every time the collect2 process is interrupted via a signal
>> it can delete random files from the hard drive, since the
>> signal handler may be using the path name, and passes it to the unlink
>> function before it is initialized.
>>
>> The patch doe not apply cleanly to gcc-8, but just fixing
>> that issue, without tackling the cleanup at the same time should
>> be feasible, if you like that for this version?
> 
> Sure, these kind of fixes are always welcome, but please  post them
> for review.
> 

OK, posted here:
https://gcc.gnu.org/ml/gcc-patches/2020-02/msg01104.html

Bernd.

> Richard.
> 
>>
>> Thanks
>> Bernd.


Re: Request for better syntax checking in lang.opt

2020-02-20 Thread Thomas Koenig

Hi Martin,


Sure, I can improve sanity checking.


Thanks!


What exactly have you screwed up?

I had, in lang.opt

EnumValue
Enum (gfc_fcoarray) String (native) Value (GFC_FCOARRAY_NATIVE)

It was a bit non-obvious to me that this led to the whole sub-option
being ignored due to

*drum roll*

the space between the keywords and the opening parenthesis.  I have
internalized the GNU style guides to such an extent that I hardly
ever see the space there :-)

Regards

Thomas


ABI compatibility: GCC9 vs GCC10

2020-02-20 Thread Jason Mancini
Any notable ABI changes from 9 to 10?
Thanks!
-Jason
(Sorry for asking here, there was no response from gcc-help in January.)