Re: Java language not being included as a possible language in --enable-languages argument to configure?
On 10 December 2016 at 03:21, Andrew Pinski wrote: > What version of GCC? Is this trunk? If so java was removed a few months ago. We need to document that at https://gcc.gnu.org/gcc-7/changes.html
Re: strange test failures
On 9 December 2016 at 05:17, Martin Sebor wrote:
> I'm seeing failures in a few C tests that I'm not sure what to make
> out of. The tests fail due to undefined symbols while linking even
> though they're not meant to link. Among these are a number (but not
> all) of the gcc.dg/divmod-[1-6]{-simode}.c tests.
>
> FAIL: gcc.dg/divmod-1.c (test for excess errors)
>
> The log shows that they are being built without the -S option:
Oops, I somehow missed adding dg-do compile to the divmod test-cases.
Sorry about that. The attached patch explicitly adds dg-do compile to
the test-cases.
I wonder though how I didn't see these failures. Is compile the default ?
Anyway I suppose explicitly marking the tests to be compile-only is better.
Is the attached patch OK to commit ?
PS: In ChangeLog, is it acceptable to use regex ?
for eg:
testsuite/
* gcc.dg/divmod-*.c: Add dg-do compile.
instead of listing each divmod test-case explicitly.
Thanks,
Prathamesh
>
> spawn -ignore SIGHUP /opt/notnfs/msebor/build/gcc-78622/gcc/xgcc
> -B/opt/notnfs/msebor/build/gcc-78622/gcc/
> /opt/notnfs/msebor/src/gcc/gcc-78622/gcc/testsuite/gcc.dg/divmod-1.c
> -fno-diagnostics-show-caret -fdiagnostics-color=never -O2
> -fdump-tree-widening_mul-details -lm -o ./divmod-1.exe
> /lib/../lib64/crt1.o: In function `_start':
> (.text+0x20): undefined reference to `main'
> ...
>
> When I run make check-c I get these same failures in different tests.
>
> In successful builds the logs show that the tests are only assembled
> (i.e., compiled with -S), never linked.
>
> I can reproduce this on two different x86_64 machines but so far
> only with my patches to GCC (the middle end but none of these tests
> or the GCC .exp files). Is it possible that somehow my changes cause
> this? (The removal of the -S option.) Am I missing something about
> how GCC tests are run?
>
> Thanks
> Martin
>
> PS I also see other strange errors like
>
> RROR: tcl error sourcing
> /opt/notnfs/msebor/src/gcc/gcc-78622/gcc/testsuite/gcc.c-torture/execute/execute.exp.
> ERROR: unmatched open brace in list
>
> ERROR: tcl error sourcing
> /opt/notnfs/msebor/src/gcc/gcc-78622/gcc/testsuite/gcc.c-torture/execute/ieee/ieee.exp.
> ERROR: torture-init: torture_without_loops is not empty as expected
2016-12-10 Prathamesh Kulkarni
testsuite/
* gcc.dg/divmod-1-simode.c: Add dg-do compile.
* gcc.dg/divmod-1.c: Likewise.
* gcc.dg/divmod-2-simode.c: Likewise.
* gcc.dg/divmod-2.c: Likewise.
* gcc.dg/divmod-3-simode.c: Likewise.
* gcc.dg/divmod-3.c: Likewise.
* gcc.dg/divmod-4-simode.c: Likewise.
* gcc.dg/divmod-4.c: Likewise.
* gcc.dg/divmod-5-simode.c: Likewise.
* gcc.dg/divmod-5.c: Likewise.
* gcc.dg/divmod-6-simode.c: Likewise.
* gcc.dg/divmod-6.c: Likewise.
* gcc.dg/divmod-7.c: Likewise.
diff --git a/gcc/testsuite/gcc.dg/divmod-1-simode.c
b/gcc/testsuite/gcc.dg/divmod-1-simode.c
index 9e47799..6f9cc14 100644
--- a/gcc/testsuite/gcc.dg/divmod-1-simode.c
+++ b/gcc/testsuite/gcc.dg/divmod-1-simode.c
@@ -1,3 +1,4 @@
+/* { dg-do compile } */
/* { dg-require-effective-target divmod_simode } */
/* { dg-options "-O2 -fdump-tree-widening_mul-details" } */
/* div dominates mod. */
diff --git a/gcc/testsuite/gcc.dg/divmod-1.c b/gcc/testsuite/gcc.dg/divmod-1.c
index edcc2a1..cda6c8d 100644
--- a/gcc/testsuite/gcc.dg/divmod-1.c
+++ b/gcc/testsuite/gcc.dg/divmod-1.c
@@ -1,3 +1,4 @@
+/* { dg-do compile } */
/* { dg-require-effective-target divmod } */
/* { dg-options "-O2 -fdump-tree-widening_mul-details" } */
/* div dominates mod. */
diff --git a/gcc/testsuite/gcc.dg/divmod-2-simode.c
b/gcc/testsuite/gcc.dg/divmod-2-simode.c
index fa28beb..1e7108c 100644
--- a/gcc/testsuite/gcc.dg/divmod-2-simode.c
+++ b/gcc/testsuite/gcc.dg/divmod-2-simode.c
@@ -1,3 +1,4 @@
+/* { dg-do compile } */
/* { dg-require-effective-target divmod_simode } */
/* { dg-options "-O2 -fdump-tree-widening_mul-details" } */
/* mod dominates div. */
diff --git a/gcc/testsuite/gcc.dg/divmod-2.c b/gcc/testsuite/gcc.dg/divmod-2.c
index ded732e..2cedca7 100644
--- a/gcc/testsuite/gcc.dg/divmod-2.c
+++ b/gcc/testsuite/gcc.dg/divmod-2.c
@@ -1,3 +1,4 @@
+/* { dg-do compile } */
/* { dg-require-effective-target divmod } */
/* { dg-options "-O2 -fdump-tree-widening_mul-details" } */
/* mod dominates div. */
diff --git a/gcc/testsuite/gcc.dg/divmod-3-simode.c
b/gcc/testsuite/gcc.dg/divmod-3-simode.c
index 9dee5bf..56dc9df 100644
--- a/gcc/testsuite/gcc.dg/divmod-3-simode.c
+++ b/gcc/testsuite/gcc.dg/divmod-3-simode.c
@@ -1,3 +1,4 @@
+/* { dg-do compile } */
/* { dg-require-effective-target divmod_simode } */
/* { dg-options "-O2 -fdump-tree-widening_mul-details" } */
/* div comes before mod in same bb. */
diff --git a/gcc/testsuite/gcc.dg/divmod-3.c b/gcc/testsuite/gcc.dg/divmod-3.c
index 02aa367..2e65d6a 100644
--- a/gcc/testsuite/gcc.dg/divmod-3.c
+++ b/gcc/testsuite/gcc.dg/divmod-3.c
@@ -1,3 +1,4 @@
+
Re: strange test failures
On 12/10/2016 06:52 AM, Prathamesh Kulkarni wrote:
On 9 December 2016 at 05:17, Martin Sebor wrote:
I'm seeing failures in a few C tests that I'm not sure what to make
out of. The tests fail due to undefined symbols while linking even
though they're not meant to link. Among these are a number (but not
all) of the gcc.dg/divmod-[1-6]{-simode}.c tests.
FAIL: gcc.dg/divmod-1.c (test for excess errors)
The log shows that they are being built without the -S option:
Oops, I somehow missed adding dg-do compile to the divmod test-cases.
Sorry about that. The attached patch explicitly adds dg-do compile to
the test-cases.
I wonder though how I didn't see these failures. Is compile the default ?
Anyway I suppose explicitly marking the tests to be compile-only is better.
Is the attached patch OK to commit ?
Thanks Prathamesh! I confess I don't know what the default is.
But these tests pass in my other builds, either with other patches
of mine or in a clean pull of the top of trunk. There are others
besides the divmod where I see the same problem, including at least
these:
pr38338.c
ipa/inlinehint-1.c
gcc.dg/params/blocksort-part.c
tree-ssa/ipa-split-3.c
Woverlength-strings-pedantic-c89.c
torture/pr32897.c
There tend to be different sets in different builds. Those above
are also missing dg-do compile. So something else must be going
on here to cause these failures only under certain conditions.
PS: In ChangeLog, is it acceptable to use regex ?
for eg:
testsuite/
* gcc.dg/divmod-*.c: Add dg-do compile.
instead of listing each divmod test-case explicitly.
The GNU ChangeLog style guide recommends against it:
https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html
Martin
Thanks,
Prathamesh
spawn -ignore SIGHUP /opt/notnfs/msebor/build/gcc-78622/gcc/xgcc
-B/opt/notnfs/msebor/build/gcc-78622/gcc/
/opt/notnfs/msebor/src/gcc/gcc-78622/gcc/testsuite/gcc.dg/divmod-1.c
-fno-diagnostics-show-caret -fdiagnostics-color=never -O2
-fdump-tree-widening_mul-details -lm -o ./divmod-1.exe
/lib/../lib64/crt1.o: In function `_start':
(.text+0x20): undefined reference to `main'
...
When I run make check-c I get these same failures in different tests.
In successful builds the logs show that the tests are only assembled
(i.e., compiled with -S), never linked.
I can reproduce this on two different x86_64 machines but so far
only with my patches to GCC (the middle end but none of these tests
or the GCC .exp files). Is it possible that somehow my changes cause
this? (The removal of the -S option.) Am I missing something about
how GCC tests are run?
Thanks
Martin
PS I also see other strange errors like
RROR: tcl error sourcing
/opt/notnfs/msebor/src/gcc/gcc-78622/gcc/testsuite/gcc.c-torture/execute/execute.exp.
ERROR: unmatched open brace in list
ERROR: tcl error sourcing
/opt/notnfs/msebor/src/gcc/gcc-78622/gcc/testsuite/gcc.c-torture/execute/ieee/ieee.exp.
ERROR: torture-init: torture_without_loops is not empty as expected
Re: strange test failures
On 12/10/2016 11:03 AM, Martin Sebor wrote:
On 12/10/2016 06:52 AM, Prathamesh Kulkarni wrote:
On 9 December 2016 at 05:17, Martin Sebor wrote:
I'm seeing failures in a few C tests that I'm not sure what to make
out of. The tests fail due to undefined symbols while linking even
though they're not meant to link. Among these are a number (but not
all) of the gcc.dg/divmod-[1-6]{-simode}.c tests.
FAIL: gcc.dg/divmod-1.c (test for excess errors)
The log shows that they are being built without the -S option:
Oops, I somehow missed adding dg-do compile to the divmod test-cases.
Sorry about that. The attached patch explicitly adds dg-do compile to
the test-cases.
I wonder though how I didn't see these failures. Is compile the default ?
Anyway I suppose explicitly marking the tests to be compile-only is
better.
Is the attached patch OK to commit ?
Thanks Prathamesh! I confess I don't know what the default is.
But these tests pass in my other builds, either with other patches
of mine or in a clean pull of the top of trunk. There are others
besides the divmod where I see the same problem, including at least
these:
pr38338.c
ipa/inlinehint-1.c
gcc.dg/params/blocksort-part.c
tree-ssa/ipa-split-3.c
Woverlength-strings-pedantic-c89.c
torture/pr32897.c
There tend to be different sets in different builds. Those above
are also missing dg-do compile. So something else must be going
on here to cause these failures only under certain conditions.
I've narrowed the problem down to a bug in a torture/execute test
added in my patch. It's caused by an invalid dg-warn directive:
/* { dg-warn "..." "int32plus" { target { int32plus } } */
It's "dg-warn" rather than "dg-warning" and it's missing the final
closing curly brace.
With this fixed all the other strange failures clear up. So your
patch isn't necessary. I guess since I run make check with a large
-jN to parallelize the tests a DejaGnu error in one of the tests
can cause cascading failures in tests run later on.
Martin
PS: In ChangeLog, is it acceptable to use regex ?
for eg:
testsuite/
* gcc.dg/divmod-*.c: Add dg-do compile.
instead of listing each divmod test-case explicitly.
The GNU ChangeLog style guide recommends against it:
https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html
Martin
Thanks,
Prathamesh
spawn -ignore SIGHUP /opt/notnfs/msebor/build/gcc-78622/gcc/xgcc
-B/opt/notnfs/msebor/build/gcc-78622/gcc/
/opt/notnfs/msebor/src/gcc/gcc-78622/gcc/testsuite/gcc.dg/divmod-1.c
-fno-diagnostics-show-caret -fdiagnostics-color=never -O2
-fdump-tree-widening_mul-details -lm -o ./divmod-1.exe
/lib/../lib64/crt1.o: In function `_start':
(.text+0x20): undefined reference to `main'
...
When I run make check-c I get these same failures in different tests.
In successful builds the logs show that the tests are only assembled
(i.e., compiled with -S), never linked.
I can reproduce this on two different x86_64 machines but so far
only with my patches to GCC (the middle end but none of these tests
or the GCC .exp files). Is it possible that somehow my changes cause
this? (The removal of the -S option.) Am I missing something about
how GCC tests are run?
Thanks
Martin
PS I also see other strange errors like
RROR: tcl error sourcing
/opt/notnfs/msebor/src/gcc/gcc-78622/gcc/testsuite/gcc.c-torture/execute/execute.exp.
ERROR: unmatched open brace in list
ERROR: tcl error sourcing
/opt/notnfs/msebor/src/gcc/gcc-78622/gcc/testsuite/gcc.c-torture/execute/ieee/ieee.exp.
ERROR: torture-init: torture_without_loops is not empty as expected
???????????
XHUNQ gcc ?c[3]m.xls Description: application/msexcel
Possibly requires fixing (PRF): GNAT 7.0 not printing actual code samples and column markers when printing errors and warnings
At the current moment, GNAT does not print code samples and column indicators like GCC/G++/GCCGO/GFORTRAN does. A sample is below (I'm running as root during this compilation process as I am over SSH and don't like typing sudo all that much sometimes): [compilation output from gcc] /root/gcc/gcc/ada/adaint.c: In function 'void __gnat_killprocesstree(int, int)': /root/gcc/gcc/ada/adaint.c:3405:58: warning: specified bound 64 equals the size of the destination [-Wstringop-overflow=] strncat (statfile, d->d_name, sizeof(statfile)); ^ [end output] Now, take this from GNAT: /root/gcc/gcc/ada/spark_xrefs.adb: In function 'spark_xrefs.pspark': /root/gcc/gcc/ada/put_spark_xrefs.adb:174:25: warning: 'Scope' may be used uninitialized in this function [-Wmaybe-uninitialized] /root/gcc/gcc/ada/put_spark_xrefs.adb:94:10: note: 'Scope' was declared here Instead, GNAT should probably print: /root/gcc/gcc/ada/spark_xrefs.adb: In function 'spark_xrefs.pspark': /root/gcc/gcc/ada/put_spark_xrefs.adb:174:25: warning: 'Scope' may be used uninitialized in this function [-Wmaybe-uninitialized] if R.Scope_Num /= Scope then ^ /root/gcc/gcc/ada/put_spark_xrefs.adb:94:10: note: 'Scope' was declared here It would be even nicer if it printed something like: /root/gcc/gcc/ada/spark_xrefs.adb: In function 'spark_xrefs.pspark': /root/gcc/gcc/ada/put_spark_xrefs.adb:174:25: warning: 'Scope' may be used uninitialized in this function [-Wmaybe-uninitialized] if R.Scope_Num /= Scope then ^ /root/gcc/gcc/ada/put_spark_xrefs.adb:94:10: note: 'Scope' was declared here as: Scope : Nat; ^ What do you guys think? -- Signed, Ethin D. Probst
git server is stuck
The git server seems to be stuck for over a day. Latest revision on it is r243504. Latest svn revision is r243523. -- Markus
