On Thu, 2015-02-26 at 11:17 -0500, David Malcolm wrote:
> On Fri, 2015-02-20 at 10:29 -0700, Jeff Law wrote:
> > On 02/19/15 14:56, Chris Johns wrote:
> > > On 20/02/2015 8:23 am, Joel Sherrill wrote:
> > >>
> > >> On 2/19/2015 2:56 PM, Sandra Loosemore wrote:
> > >>> Jakub Jelinek wrote:
> > On Wed, Feb 18, 2015 at 11:21:56AM -0800, Jeff Prothero wrote:
> > > Starting with gcc 4.9, -O2 implicitly invokes
> > >
> > > -fisolate-erroneous-paths-dereference:
> > >
> > > which
> > >
> > > https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html
> > >
> > > documents as
> > >
> > > Detect paths that trigger erroneous or undefined behavior due to
> > > dereferencing a null pointer. Isolate those paths from the
> > > main control
> > > flow and turn the statement with erroneous or undefined
> > > behavior into a
> > > trap. This flag is enabled by default at -O2 and higher.
> > >
> > > This results in a sizable number of previously working embedded
> > > programs mysteriously
> > > crashing when recompiled under gcc 4.9. The problem is that embedded
> > > programs will often have ram starting at address zero (think
> > > hardware-defined
> > > interrupt vectors, say) which gets initialized by code which the
> > > -fisolate-erroneous-paths-deference logic can recognize as reading
> > > and/or
> > > writing address zero.
> > If you have some pages mapped at address 0, you really should
> > compile your
> > code with -fno-delete-null-pointer-checks, otherwise you can run
> > into tons
> > of other issues.
> > >>> H, Passing the additional option in user code would be one thing,
> > >>> but what about library code? E.g., using memcpy (either explicitly or
> > >>> implicitly for a structure copy)?
> > >>>
> > >>> It looks to me like cr16 and avr are currently the only architectures
> > >>> that disable flag_delete_null_pointer_checks entirely, but I am sure
> > >>> that this issue affects other embedded targets besides nios2, too. E.g.
> > >>> scanning Mentor's ARM board support library, I see a whole pile of
> > >>> devices that have memory mapped at address zero (TI Stellaris/Tiva,
> > >>> Energy Micro EFM32Gxxx, Atmel AT91SAMxxx, ). Plus our simulator
> > >>> BSPs assume a flat address space starting at address 0.
> > >> I forwarded this to the RTEMS list and was promptly pointed to a patch
> > >> on a Coldfire BSP where someone worked around this behavior.
> > >>
> > >> We are discussing how to deal with this. It is likely OK in user code but
> > >> horrible in BSP and driver code. We don't have a solution ourselves. We
> > >> just recognize it impacts a number of targets.
> > >>
> > >
> > > My main concern is not knowing the trap has been added to the code. If I
> > > could build an application and audit it somehow then I can manage it. We
> > > have a similar issue with the possible use of FP registers being used in
> > > general code (ISR save/restore trade off).
> > >
> > > Can the ELF be annotated in some GCC specific way that makes it to the
> > > final executable to flag this is happening ? We can then create tools to
> > > audit the executables.
> > Not really, for a variety of reasons.
>
> Is information on this reaching the pass-specific dumpfile? I don't see
> any explicit dumping in gimple-ssa-isolate-paths.c, but I guess that
> insert_trap_and_remove_trailing_statements could log itself to the
> dumpfile, or use the statistics framework (which itself also reaches a
> dumpfile).
>
> Assuming the info is reaching a dumpfile, could gcc have an option to
> write its dumpfiles into a special ELF section in the .s, rather than to
> disk?
>
> Then (given a suitable new option to e.g. eu-readelf) you'd be able to
> read the dumpfiles from a .o file, and (handwaving about linkage) from
> an execuable or library.
>
> Not that I'm volunteering...
Perhaps foolishly I had a go at prototyping this; attached is a
proof-of-concept patch (albeit with FIXMEs and no ChangeLog or testsuite
coverage).
When writing out the final asm, each dumpfile is read, and embedded into
its own section. Manual review of the built .o file shows that the
dumpfiles make it into them, e.g.:
$ eu-readelf -x .note.GNU-dump.tree-switchconv smoketest.o|head
Hex dump of section [28] '.note.GNU-dump.tree-switchconv', 2698 bytes at offset
0xf021:
0x 0a3b3b20 46756e63 74696f6e 20746573 .;; Function tes
0x0010 745f7068 69202874 6573745f 7068692c t_phi (test_phi,
0x0020 2066756e 63646566 5f6e6f3d 302c2064 funcdef_no=0, d
0x0030 65636c5f 7569643d 31383332 2c206367 ecl_uid=1832, cg
0x0040 72617068 5f756964 3d302c20 73796d62 raph_uid=0, symb
0x0050 6f6c5f6f 72646572 3d30290a 0a746573 ol_order=0)..tes
0x0060 745f7068 69202869 6e742069 2c20696e t_phi (int i, in
0x0070 74206a29 0a7b0a20 20696e74 206b3b0a t j).{. int
