Re: [PATCH 6/8] fortran: use grep -F instead of fgrep
On Fri, 2022-06-24 at 13:13 +0200, Bernhard Reutner-Fischer wrote: > > - if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i > > debian' >/dev/null 2>&1; then \ > > + if $(SHELL) -c 'install-info --version | sed 1q | grep -F -s -v -i > > debian' >/dev/null 2>&1; then \ > > echo " install-info --delete --info-dir=$(DESTDIR)$(infodir) > > $(DESTDIR)$(infodir)/gfortran.info"; \ > > install-info --delete --info-dir=$(DESTDIR)$(infodir) > > $(DESTDIR)$(infodir)/gfortran.info || : ; \ > > else : ; fi; \ > > I'd replace -s >/dev/null 2>&1 with -q while at it. > > But why is -F used here in the first place? > I do not see much in debian that can be interpreted as a regex? I'm not sure. It was there since 2004. Perhaps the author thinks fgrep may save several CPU cycles :). I'll just use a plain grep in PATCH v2. Rainer: do you have some idea about the availability of "-q" on different hosts? If you agree I'll use it instead of -s > /dev/null too. -- Xi Ruoyao School of Aerospace Science and Technology, Xidian University
[PATCH v2 4/7] fortran: use grep instead of fgrep
fgrep has been deprecated in favor of grep -F for a long time, and the next grep release (3.8 or 4.0) will print a warning of fgrep is used. Stop using fgrep so we won't see the warning. We can't hard code grep -F here or it may break build on hosts w/o GNU grep. autoconf documentation contains a warning about this issue and suggest to use AC_PROG_FGREP and $FGREP, but these are too overkill in the specific case: there is no way "debian" could be interpreted as an non-trivial regex, so we can use a plain grep here. gcc/fortran/ChangeLog: * Make-lang.in: Use grep instead of fgrep. --- gcc/fortran/Make-lang.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/fortran/Make-lang.in b/gcc/fortran/Make-lang.in index 1cb47cb1a52..6eb597d0ca0 100644 --- a/gcc/fortran/Make-lang.in +++ b/gcc/fortran/Make-lang.in @@ -278,7 +278,7 @@ $(DESTDIR)$(man1dir)/$(GFORTRAN_INSTALL_NAME)$(man1ext): doc/gfortran.1 \ -chmod a-x $@ fortran.uninstall: - if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i debian' >/dev/null 2>&1; then \ + if $(SHELL) -c 'install-info --version | sed 1q | grep -s -v -i debian' >/dev/null 2>&1; then \ echo " install-info --delete --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/gfortran.info"; \ install-info --delete --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/gfortran.info || : ; \ else : ; fi; \ -- 2.36.1
Re: GCC 13.0.0 Status Report (2022-11-14), Stage 3 in effect now
Hi Martin, Is it allowed to merge libsanitizer from LLVM in stage 3? If not I'd like to cherry pick some commits from LLVM [to fix some stupid errors I've made in LoongArch libasan :(]. On Mon, 2022-11-14 at 13:21 +, Richard Biener via Gcc-patches wrote: > Status > == > > The GCC development branch which will become GCC 13 is now in > bugfixing mode (Stage 3) until the end of Jan 15th. > > As usual the first weeks of Stage 3 are used to feature patches > posted late during Stage 1. At some point unreviewed features > need to be postponed for the next Stage 1. > > > Quality Data > > > Priority # Change from last report > --- --- > P1 33 > P2 473 > P3 113 + 29 > P4 253 + 6 > P5 25 > --- --- > Total P1-P3 619 + 29 > Total 897 + 35 > > > Previous Report > === > > https://gcc.gnu.org/pipermail/gcc/2022-October/239690.html -- Xi Ruoyao School of Aerospace Science and Technology, Xidian University
Pushed: [PATCH v2 4/7] fortran: use grep instead of fgrep
On Wed, 2023-05-10 at 22:02 +0200, Thomas Koenig wrote: > On 10.05.23 21:29, Bernhard Reutner-Fischer via Fortran wrote: > > On Mon, 27 Jun 2022 14:10:36 +0800 > > Xi Ruoyao wrote: > > > > > fgrep has been deprecated in favor of grep -F for a long time, and the > > > next grep release (3.8 or 4.0) will print a warning of fgrep is used. > > > Stop using fgrep so we won't see the warning. > > > > > > We can't hard code grep -F here or it may break build on hosts w/o GNU > > > grep. autoconf documentation contains a warning about this issue and > > > suggest to use AC_PROG_FGREP and $FGREP, but these are too overkill in > > > the specific case: there is no way "debian" could be interpreted as an > > > non-trivial regex, so we can use a plain grep here. > > > > LGTM but i cannot approve it. I'd say this one is trivial and obvious > > so you could sneak it in under the "obvious" rule.. > > I concur, this could also have been obvious. > > Anyway, OK for trunk, and > > > Thanks for the patch! Pushed r14-698, with a commit msg change for the status of grep release. -- Xi Ruoyao School of Aerospace Science and Technology, Xidian University
