Re: [PING] [PATCH] gfortran: Rely on dg-do-what-default to avoid running pr85853.f90, pr107254.f90 and vect-alias-check-1.F90 on non-vector targets
On 11/15/23 17:03, Patrick O'Neill wrote: Ping. Testsuite fixup similar to: https://inbox.sourceware.org/gcc-patches/974e9e5e-8f07-46dd-b9b9-db8aa4685...@gmail.com/T/#t https://inbox.sourceware.org/gcc-patches/7e78cd70-70c9-41b1-8a98-6977a1034...@rivosinc.com/T/#t OK. Jeff
Re: [PATCH 4/5] value-range: Add as_string diagnostics helper
On 11/12/22 16:55, Andrew Pinski via Gcc-patches wrote: On Sat, Nov 12, 2022 at 3:47 PM Bernhard Reutner-Fischer via Gcc-patches wrote: gcc/ChangeLog: * value-range.cc (get_bound_with_infinite_markers): New static helper. (irange::as_string): New definition. * value-range.h: New declaration. --- Provide means to print a value range to a newly allocated buffer. The caller is responsible to free() the allocated memory. Bootstrapped and regtested on x86_86-unknown-linux with no regressions. Ok for trunk? Cc: Andrew MacLeod Cc: Aldy Hernandez --- gcc/value-range.cc | 56 ++ gcc/value-range.h | 3 +++ 2 files changed, 59 insertions(+) diff --git a/gcc/value-range.cc b/gcc/value-range.cc index a855aaf626c..51cd9a38d90 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -3099,6 +3099,62 @@ debug (const value_range &vr) fprintf (stderr, "\n"); } +/* Helper for irange::as_string(). Print a bound to an allocated buffer. */ +static char * Can we start using std::string instead of char* here? If it makes the code easier to read/maintain, sure. std::string isn't used heavily, but has crept into a few places, mostly in target files. std::string isn't something we've pushed at all in terms of preferred practices. Jeff
Re: Test with an lto-build of libgfortran.
On 9/27/23 12:21, Toon Moene wrote: The lto-ing of libgfortran did succeed, because I did get a new warning: gfortran -O3 -flto -flto-partition=none -static -o xlintstrfz zchkrfp.o zdrvrfp.o zdrvrf1.o zdrvrf2.o zdrvrf3.o zdrvrf4.o zerrrfp.o zlatb4.o zlaipd.o zlarhs.o zsbmv.o zget04.o zpot01.o zpot03.o zpot02.o chkxer.o xerbla.o alaerh.o aladhd.o alahd.o alasvm.o ../../libtmglib.a ../../liblapack.a ../../librefblas.a In function 'xtoa_big', inlined from 'write_z' at /home/toon/compilers/gcc/libgfortran/io/write.c:1296:11, inlined from 'formatted_transfer_scalar_write' at /home/toon/compilers/gcc/libgfortran/io/transfer.c:2136:4: /home/toon/compilers/gcc/libgfortran/io/write.c:1222:6: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=] 1222 | *q = '\0'; | ^ /home/toon/compilers/gcc/libgfortran/io/write.c: In function 'formatted_transfer_scalar_write': /home/toon/compilers/gcc/libgfortran/io/write.c:1291:8: note: at offset [34, 4294967294] into destination object 'itoa_buf' of size 33 1291 | char itoa_buf[GFC_XTOA_BUF_SIZE]; | ^ which was (of course) not given with a non-lto libgfortran. Yea. This certainly can happen with LTO. These warnings would definitely be something worth investigating. Essentially the inlining enabled by LTO can expose a different set of diagnostics. Jeff
Re: [PATCH][WIP] Add install-dvi Makefile targets
On 10/18/2021 7:30 PM, Eric Gallager wrote: On Tue, Oct 12, 2021 at 5:09 PM Eric Gallager wrote: On Thu, Oct 6, 2016 at 10:41 AM Eric Gallager wrote: Currently the build machinery handles install-pdf and install-html targets, but no install-dvi target. This patch is a step towards fixing that. Note that I have only tested with --enable-languages=c,c++,lto,objc,obj-c++. Thus, target hooks will probably also have to be added for the languages I skipped. Also, please note that this patch applies on top of: https://gcc.gnu.org/ml/gcc-patches/2016-10/msg00370.html ChangeLog: 2016-10-06 Eric Gallager * Makefile.def: Handle install-dvi target. * Makefile.tpl: Likewise. * Makefile.in: Regenerate. gcc/ChangeLog: 2016-10-06 Eric Gallager * Makefile.in: Handle dvidir and install-dvi target. * ./[c|cp|lto|objc|objcp]/Make-lang.in: Add dummy install-dvi target hooks. * configure.ac: Handle install-dvi target. * configure: Regenerate. libiberty/ChangeLog: 2016-10-06 Eric Gallager * Makefile.in: Handle dvidir and install-dvi target. * functions.texi: Regenerate. Ping. The prerequisite patch that I linked to previously has gone in now. I'm not sure if this specific patch still applies, though. Also note that I've opened a bug to track this issue: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102663 Hi, I have updated this patch and tested it with more languages now; I can now confirm that it works with ada, d, and fortran now. The only languages that remain untested now are go (since I'm building on darwin and go doesn't build on darwin anyways, as per bug 46986) and jit (which I ran into a bug about that I brought up on IRC, and will probably need to file on bugzilla). OK to install? Yea, I think this is OK. We might need to adjust go/jit and perhaps other toplevel modules, but if those do show up as problems I think we can fault in those fixes. jeff
Re: [PATCH] Remove dead Fortran function.
On 11/9/2021 6:59 AM, Martin Liška wrote: Hello. The function was introduced in 2009 in g:cf2b3c22a2cbd7f50db530ca9d2b14c70ba0359d and has never been used since that. Ready to be installed? Thanks, Martin gcc/fortran/ChangeLog: * symbol.c (gfc_get_ultimate_derived_super_type): Remove. OK jeff
