Re: [PATCH, libgfortran] PR119856 Part 2 Fix error handling for missing commas in format strings

2025-06-01 Thread Thomas Koenig

Hi Jerry,

The attached patch fixes a latent issue where we were saving a parsed 
and checked format string that had a missing comma. This resulted in the 
correct error on the first use of the string, but a missed error on 
subsequent uses of the string.


New test case provided.

Regression tested on x86_64

OK for trunk and eventual backport to 15?


Looks good to me. Thanks for the patch!

Best regards

Thomas



Re: [PATCH, libgfortran] PR119856 Part 2 Fix error handling for missing commas in format strings

2025-06-01 Thread Harald Anlauf

Hi Jerry,

On 5/31/25 19:38, Jerry D wrote:

Hi all,

The attached patch fixes a latent issue where we were saving a parsed 
and checked format string that had a missing comma. This resulted in the 
correct error on the first use of the string, but a missed error on 
subsequent uses of the string.


New test case provided.

Regression tested on x86_64

OK for trunk and eventual backport to 15?


both is OK.

Thanks for the patch!

Harald


Regards,

Jerry


[Sidenote: this is a pure libgfortran test where AFAICT torture-testing
does not make much sense.  It is cheap, though.]



[PATCH] gcc: middle-end opt for trigonometric pi-based functions builtins

2025-06-01 Thread Yuao Ma
Hello world,

This patch partially handled PR118592.

This patch builds upon r16-710-g591d3d02664c7b and r16-711-g89935d56f768b4. It
introduces middle-end optimizations, such as constant folding, for our
trigonometric pi-based function built-ins.

For MPFR versions older than 4.2.0, we've included our own folding functions.
I've also added tests to ensure everything works as expected.

Best regards,
Yuao


0001-gcc-middle-end-opt-for-trigonometric-pi-based-functi.patch
Description: 0001-gcc-middle-end-opt-for-trigonometric-pi-based-functi.patch