Re: *PING* [PATCH 0/7] fortran: Inline MINLOC/MAXLOC with DIM [PR90608]
On Fri, Nov 01, 2024 at 01:01:39PM +0100, Mikael Morin wrote: > Le 30/10/2024 à 23:00, Harald Anlauf a écrit : > > > > given that Jakub changed lots of whitespace in r15-4624-g50332a4fdd3243, > > you may want to rebase your patches onto HEAD of trunk. > > > > May I also suggest to attach the patches instead of mailing them inline? > > > Hello, > > I checked with today's master, didn't see any whitespace issue. Have you > encountered any, trying to apply the patches? > > My workflow was: > * save the seven e-mails to an empty directory. > * git am --scissors /path/to/dir/* > And the seven patches are applied in order without error. > Mikael, I've read through each of the patch and nothing jumped out as an issue. I think you can go ahead and commit them. I'll leave it up to you whether to commit a patch and wait a short time before committing the next in the series. The short time period may help catch any unforeseen regressions. Thanks for the sequence of patches. -- Steve
Re: [PATCH] Fortran: add bounds-checking for ALLOCATE of CHARACTER with type-spec [PR53357]
Am 18.11.24 um 03:55 schrieb Jerry D: On 11/17/24 2:21 PM, Harald Anlauf wrote: Dear all, the attached patch fixes a rejects-valid / rejects-potentially-valid code issue for ALLOCATE of CHARACTER with type-spec, and add character length checking with -fcheck=bounds for the case at hand. It also improves checking of character function declarations and references slightly, using the diagnostics of NAG as a guidance. Some testcases popped up during regtesting, suggesting that one needs to be careful not to generate too many false positives, so I decided to not spend to much time on the FIXME's therein. (Character length might be expressions in an explicit interface and the actual declaration, where we don't have a reliable way to compare.) Regtested on x86_64-pc-linux-gnu. OK for mainline? Thanks, Harald Looks good, OK for mainline. Jerry Thanks for the review, Jerry! Committed as r15-5414-g386f6d98ba0d43.
