Generated files going to a different place now - intentional?

2024-08-17 Thread Thomas Koenig 

Hi,

when working on the first unsigned array intrinsics, I noticed
something strange.  With maintainer mode enabled, and the usual-style
patch to include the generated functions (see below), I found that the
files were regenerated in the build dir, under
x86_64-pc-linux-gnu/libgfortran/generated
and not in the source directory, as previously.

Was this change intentional, or is this a bug introduced by some other
change?  I could not see anything along those lines in the
ChangeLog entries.

Best regards

Thomas


diff --git a/libgfortran/Makefile.am b/libgfortran/Makefile.am
index 8524cc6ed03..5c91e5ceebf 100644
--- a/libgfortran/Makefile.am
+++ b/libgfortran/Makefile.am
@@ -604,6 +604,11 @@ generated/matmul_i2.c \
 generated/matmul_i4.c \
 generated/matmul_i8.c \
 generated/matmul_i16.c \
+generated/matmul_m1.c \
+generated/matmul_m2.c \
+generated/matmul_m4.c \
+generated/matmul_m8.c \
+generated/matmul_m16.c \
 generated/matmul_r4.c \
 generated/matmul_r8.c \
 generated/matmul_r10.c \
diff --git a/libgfortran/Makefile.in b/libgfortran/Makefile.in
index 6c6c89cc14e..dee2f9c2ed1 100644
--- a/libgfortran/Makefile.in
+++ b/libgfortran/Makefile.in
@@ -342,12 +342,14 @@ am__objects_20 = generated/parity_l1.lo 
generated/parity_l2.lo \

generated/parity_l16.lo
 am__objects_21 = generated/matmul_i1.lo generated/matmul_i2.lo \
generated/matmul_i4.lo generated/matmul_i8.lo \
-   generated/matmul_i16.lo generated/matmul_r4.lo \
-   generated/matmul_r8.lo generated/matmul_r10.lo \
-   generated/matmul_r16.lo generated/matmul_r17.lo \
-   generated/matmul_c4.lo generated/matmul_c8.lo \
-   generated/matmul_c10.lo generated/matmul_c16.lo \
-   generated/matmul_c17.lo
+   generated/matmul_i16.lo generated/matmul_m1.lo \
+   generated/matmul_m2.lo generated/matmul_m4.lo \
+   generated/matmul_m8.lo generated/matmul_m16.lo \
+   generated/matmul_r4.lo generated/matmul_r8.lo \
+   generated/matmul_r10.lo generated/matmul_r16.lo \
+   generated/matmul_r17.lo generated/matmul_c4.lo \
+   generated/matmul_c8.lo generated/matmul_c10.lo \
+   generated/matmul_c16.lo generated/matmul_c17.lo
 am__objects_22 = generated/matmul_l4.lo generated/matmul_l8.lo \
generated/matmul_l16.lo
 am__objects_23 = generated/shape_i1.lo generated/shape_i2.lo \
@@ -1362,6 +1364,11 @@ generated/matmul_i2.c \
 generated/matmul_i4.c \
 generated/matmul_i8.c \
 generated/matmul_i16.c \
+generated/matmul_m1.c \
+generated/matmul_m2.c \
+generated/matmul_m4.c \
+generated/matmul_m8.c \
+generated/matmul_m16.c \
 generated/matmul_r4.c \
 generated/matmul_r8.c \
 generated/matmul_r10.c \
@@ -2474,6 +2481,16 @@ generated/matmul_i8.lo: generated/$(am__dirstamp) \
generated/$(DEPDIR)/$(am__dirstamp)
 generated/matmul_i16.lo: generated/$(am__dirstamp) \
generated/$(DEPDIR)/$(am__dirstamp)
+generated/matmul_m1.lo: generated/$(am__dirstamp) \
+   generated/$(DEPDIR)/$(am__dirstamp)
+generated/matmul_m2.lo: generated/$(am__dirstamp) \
+   generated/$(DEPDIR)/$(am__dirstamp)
+generated/matmul_m4.lo: generated/$(am__dirstamp) \
+   generated/$(DEPDIR)/$(am__dirstamp)
+generated/matmul_m8.lo: generated/$(am__dirstamp) \
+   generated/$(DEPDIR)/$(am__dirstamp)
+generated/matmul_m16.lo: generated/$(am__dirstamp) \
+   generated/$(DEPDIR)/$(am__dirstamp)
 generated/matmul_r4.lo: generated/$(am__dirstamp) \
generated/$(DEPDIR)/$(am__dirstamp)
 generated/matmul_r8.lo: generated/$(am__dirstamp) \
@@ -3803,6 +3820,11 @@ distclean-compile:
 @AMDEP_TRUE@@am__include@ 
@am__quote@generated/$(DEPDIR)/matmul_l16.Plo@am__quote@
 @AMDEP_TRUE@@am__include@ 
@am__quote@generated/$(DEPDIR)/matmul_l4.Plo@am__quote@
 @AMDEP_TRUE@@am__include@ 
@am__quote@generated/$(DEPDIR)/matmul_l8.Plo@am__quote@
+@AMDEP_TRUE@@am__include@ 
@am__quote@generated/$(DEPDIR)/matmul_m1.Plo@am__quote@
+@AMDEP_TRUE@@am__include@ 
@am__quote@generated/$(DEPDIR)/matmul_m16.Plo@am__quote@
+@AMDEP_TRUE@@am__include@ 
@am__quote@generated/$(DEPDIR)/matmul_m2.Plo@am__quote@
+@AMDEP_TRUE@@am__include@ 
@am__quote@generated/$(DEPDIR)/matmul_m4.Plo@am__quote@
+@AMDEP_TRUE@@am__include@ 
@am__quote@generated/$(DEPDIR)/matmul_m8.Plo@am__quote@
 @AMDEP_TRUE@@am__include@ 
@am__quote@generated/$(DEPDIR)/matmul_r10.Plo@am__quote@
 @AMDEP_TRUE@@am__include@ 
@am__quote@generated/$(DEPDIR)/matmul_r16.Plo@am__quote@
 @AMDEP_TRUE@@am__include@ 
@am__quote@generated/$(DEPDIR)/matmul_r17.Plo@am__quote@

diff --git a/libgfortran/m4/types.m4 b/libgfortran/m4/types.m4
index cb808290c08..ebef54fec54 100644
--- a/libgfortran/m4/types.m4
+++ b/libgfortran/m4/types.m4
@@ -1,4 +1,4 @@
 define(get_typename2, `GFC_$1_$2')dnl
-define(get_typename, 
`get_typename2(ifelse($1,i,INTEGER,ifelse($1,r,REAL,ifelse($1,l,LOGICAL,ifelse($1,c,COMPLEX,unknown,`$2')')dnl
+define(get_typename, 
`get_typename2(ifelse($1,i,INTEGER,ifelse($1,m,UNSIGNED,ifelse($1,r,REAL,ifelse($1,l,LOGICAL,ifelse($1,c,COMPLEX,unknown)

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-17 Thread Sergio Had 
Hi,

If we are good at this point, could someone help with merging it? (I don’t have 
commit access, of course.)

Sergey
On Aug 14, 2024 at 21:30 +0800, Sergey Fedorov , wrote:
> Thank you, Iain.
> I have adjusted a longer line and added an intro sentence before changelog 
> record.
>
>
>
> > On Wed, Aug 14, 2024 at 8:24 PM Iain Sandoe  wrote:
> > >
> > >
> > > > On 14 Aug 2024, at 13:17, Sergey Fedorov  wrote:
> > > >
> > > >
> > > >
> > > > On Wed, Aug 14, 2024 at 8:03 PM FX Coudert  wrote:
> > > > > Thank you for responding.
> > > > > I have added a changelog (is this a correct way?).
> > > >
> > > > Content seems ok, lines are maybe too long. Check with 
> > > > contrib/gcc-changelog/git_check_commit.py before pushing.
> > > > Once that is fine, OK to push.
> > > >
> > > > Looks like the script is okay with formatting:
> > > >
> > > > 36-25% /opt/local/bin/python3.11 
> > > > /Users/svacchanda/Github_barracuda156/gcc-git/contrib/gcc-changelog/git_check_commit.py
> > > > Checking 16e8ea376ada59306583decf1a218b2281a48638: OK
> > >
> > >         * config/fpu-macppc.h (new file): initial support for 
> > > powerpc-darwin.
> > >         * configure.host: enable ieee_support for powerpc-darwin case, 
> > > set fpu_host='fpu-macppc’.
> > >
> > > The description lines should begin with a capital letter and the lines 
> > > should
> > > not exceed 80 chars (some people prefer if they do not exceed 76 chars so
> > > that  “git show” output fits into 80 columns).
> > >
> > > hth
> > > Iain
> > >
> > >
> > > >
> > > > Sergey
> > > >
> > >

Re: Generated files going to a different place now - intentional?

2024-08-17 Thread Thomas Koenig 

Am 17.08.24 um 13:20 schrieb Thomas Koenig:


when working on the first unsigned array intrinsics, I noticed
something strange.  With maintainer mode enabled, and the usual-style
patch to include the generated functions (see below), I found that the
files were regenerated in the build dir, under
x86_64-pc-linux-gnu/libgfortran/generated
and not in the source directory, as previously.


Having looked through the git log (apparently the ChangeLog didn't make
it thrugh), this seems to be affd24bfc62203db9f9937c0d6cf8f1f75b80d72 .
I have opened https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116400 for
this.

Best regards

Thomas

Re: Generated files going to a different place now - intentional?

2024-08-17 Thread Thomas Koenig 

Am 17.08.24 um 13:20 schrieb Thomas Koenig:

--- a/libgfortran/m4/types.m4
+++ b/libgfortran/m4/types.m4


Yes, I now know that this is the wrong place (we could remove this, I
think :-)