Re: [PATCH v5 2/5] libcpp: add a function to determine UTF-8 validity of a C string
On Wed, Jan 25, 2023 at 4:09 PM Ben Boeckel via Gcc wrote: > > This simplifies the interface for other UTF-8 validity detections when a > simple "yes" or "no" answer is sufficient. > > libcpp/ > > * charset.cc: Add `_cpp_valid_utf8_str` which determines whether > a C string is valid UTF-8 or not. > * internal.h: Add prototype for `_cpp_valid_utf8_str`. > > Signed-off-by: Ben Boeckel [going through patches in patchwork] What's the status of this patch; did this ever get committed? I see that Jason preapproved this via his review of "[PATCH v3 2/3] libcpp: add a function to determine UTF-8 validity of a C string" Thanks Dave
Re: [PATCH v5 2/5] libcpp: add a function to determine UTF-8 validity of a C string
On 10/23/23 11:16, David Malcolm wrote: On Wed, Jan 25, 2023 at 4:09 PM Ben Boeckel via Gcc wrote: This simplifies the interface for other UTF-8 validity detections when a simple "yes" or "no" answer is sufficient. libcpp/ * charset.cc: Add `_cpp_valid_utf8_str` which determines whether a C string is valid UTF-8 or not. * internal.h: Add prototype for `_cpp_valid_utf8_str`. Signed-off-by: Ben Boeckel [going through patches in patchwork] What's the status of this patch; did this ever get committed? It was superseded. Jason
Re: [PATCH v5 2/5] libcpp: add a function to determine UTF-8 validity of a C string
On Mon, 2023-10-23 at 11:24 -0400, Jason Merrill wrote: > On 10/23/23 11:16, David Malcolm wrote: > > On Wed, Jan 25, 2023 at 4:09 PM Ben Boeckel via Gcc > > wrote: > > > > > > This simplifies the interface for other UTF-8 validity detections > > > when a > > > simple "yes" or "no" answer is sufficient. > > > > > > libcpp/ > > > > > > * charset.cc: Add `_cpp_valid_utf8_str` which determines > > > whether > > > a C string is valid UTF-8 or not. > > > * internal.h: Add prototype for `_cpp_valid_utf8_str`. > > > > > > Signed-off-by: Ben Boeckel > > > > [going through patches in patchwork] > > > > What's the status of this patch; did this ever get committed? > > It was superseded. Thanks; closed out in patchwork. Dave
RE: [PATCH v4] libgfortran: Replace mutex with rwlock
> > Hi Lipeng, > > >>> Sure, as your comments, in the patch V6, I added 3 test cases with > >>> OpenMP to test different cases in concurrency respectively: > >>> 1. find and create unit very frequently to stress read lock and write > >>> lock. > >>> 2. only access the unit which exist in cache to stress read lock. > >>> 3. access the same unit in concurrency. > >>> For the third test case, it also help to find a bug: When unit > >>> can't be found in cache nor unit list in read phase, then threads > >>> will try to acquire write lock to insert the same unit, this will > >>> cause duplicate key > >> error. > >>> To fix this bug, I get the unit from unit list once again before > >>> insert in write > >> lock. > >>> More details you can refer the patch v6. > >>> > >> > >> Could you help to review this update? I really appreciate your assistance. > >> > > > Could you help to review this update? Any concern will be appreciated. > > Fortran parts are OK (I think I wrote that already), we need somebody for the > non-Fortran parts. > Hi Thomas, Thanks for your response. Very appreciate for your patience and help. > Jakub, could you maybe take a look? > > Best regards > > Thomas Hi Jakub, Can you help to take a look at the change for libgcc part that added several rwlock macros in libgcc/gthr-posix.h? Best Regards, Lipeng Zhu
