[FFmpeg-devel] [PATCH] avformat/rtmpproto: Fix segfault

2024-03-27 Thread Armin Hasitzka via ffmpeg-devel
Hi,

we found this when testing with rejected RTMP streams.

Best
Armin


0001-avformat-rtmpproto-Fix-segfault.patch
Description: Binary data
___
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: Fix segfault

2024-03-27 Thread Armin Hasitzka via ffmpeg-devel
Ooooh interesting, I see (makes a lot of sense)! I can confirm, btw; your
updated fix (from 324509) works for me (no segfault + clean shutdown)! ...
I will comment on the other thread as soon as the email comes through!

Thanks a lot!
Armin

On Wed, 27 Mar 2024 at 18:21, Andreas Rheinhardt <
[email protected]> wrote:

> Armin Hasitzka via ffmpeg-devel:
> > Hi,
> >
> > we found this when testing with rejected RTMP streams.
> >
> > Best
> > Armin
>
> Thanks for the report and the patch; yet actually freeing them manually
> is not only harmful, but also unnecessary, as these strings can be set
> via AVOptions; therefore they will be freed generically (which is also
> the reason why rtmp_close() does not have code to free them). I sent a
> patch for this here:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2024-March/324509.html Would
> be nice if you could test it.
>
> - Andreas
>
> ___
> ffmpeg-devel mailing list
> [email protected]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> [email protected] with subject "unsubscribe".
>
___
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".