[Engine-patches] Change in ovirt-engine[engine_3.0]: core: Fix network name on default cluster
Ofer Schreiber has uploaded a new change for review. Change subject: core: Fix network name on default cluster .. core: Fix network name on default cluster This patch renames the network name of default cluster from engine to ovirtmgmt, as a part of a previous patch-set, which missed this spot. Change-Id: If9d9d9f254f02c69f636cd63ea0b78afbc0076bd (cherry picked from commit 2474e1657a8c0134519fef4de1ed83c98a296b78) --- A backend/manager/dbscripts/upgrade/03_01_0130_update_network_name.sql 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/1074/1 -- To view, visit http://gerrit.ovirt.org/1074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If9d9d9f254f02c69f636cd63ea0b78afbc0076bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Doron Fediuck ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: raise minor version 1.1
Ofer Schreiber has posted comments on this change. Change subject: sdk: raise minor version 1.1 .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If941066a8bdd4eee721c13d2c0b34eeaeeef797e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine-cli[master]: cli: raise minor version 1.1
Ofer Schreiber has posted comments on this change. Change subject: cli: raise minor version 1.1 .. Patch Set 2: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia32b210bc3922861bfc75702a80d1804bdf1380e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak Gerrit-Reviewer: Michael Pasternak Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: allow ovirt-node to be registered
Ofer Schreiber has uploaded a new change for review. Change subject: allow ovirt-node to be registered .. allow ovirt-node to be registered Change-Id: I18fd386a8ab12723d126528a891e5df073a782cf (cherry picked from commit 8ab700ba7d0a8a603a035c47632bcf5759584db4) --- M backend/manager/conf/vds_installer.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/18/1118/1 -- To view, visit http://gerrit.ovirt.org/1118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I18fd386a8ab12723d126528a891e5df073a782cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Michael Burns ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: BZ#782439 - nfsconfig should be set with at least...
Ofer Schreiber has posted comments on this change. Change subject: packaging: BZ#782439 - nfsconfig should be set with at least one daemon per processor .. Patch Set 1: Verified; Looks good to me, approved looks great, approved. -- To view, visit http://gerrit.ovirt.org/1109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a25780fa683e66355b48a50299c0c24b20d0d12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Haim Ateya Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: BZ#782439 - nfsconfig should be set with at least...
Ofer Schreiber has posted comments on this change. Change subject: packaging: BZ#782439 - nfsconfig should be set with at least one daemon per processor .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a25780fa683e66355b48a50299c0c24b20d0d12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Haim Ateya Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: BZ#782439 - nfsconfig should be set with at least...
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: BZ#782439 - nfsconfig should be set with at least one daemon per processor .. packaging: BZ#782439 - nfsconfig should be set with at least one daemon per processor By default, NFS configuration file use 8 daemons per processor, we used none, so service failed to start properly. Change-Id: I5a25780fa683e66355b48a50299c0c24b20d0d12 --- M packaging/fedora/setup/nfs.sysconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a25780fa683e66355b48a50299c0c24b20d0d12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Haim Ateya Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: packaging: BZ#782439 - nfsconfig should be set with at least...
Ofer Schreiber has uploaded a new change for review. Change subject: packaging: BZ#782439 - nfsconfig should be set with at least one daemon per processor .. packaging: BZ#782439 - nfsconfig should be set with at least one daemon per processor By default, NFS configuration file use 8 daemons per processor, we used none, so service failed to start properly. Change-Id: I5a25780fa683e66355b48a50299c0c24b20d0d12 (cherry picked from commit 16bfac6e93d68caa7d0e99b69ed9e82278be1d5b) --- M packaging/fedora/setup/nfs.sysconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/1119/1 -- To view, visit http://gerrit.ovirt.org/1119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5a25780fa683e66355b48a50299c0c24b20d0d12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Haim Ateya ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: packaging: BZ#782439 - nfsconfig should be set with at least...
Ofer Schreiber has posted comments on this change. Change subject: packaging: BZ#782439 - nfsconfig should be set with at least one daemon per processor .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a25780fa683e66355b48a50299c0c24b20d0d12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: packaging: BZ#782439 - nfsconfig should be set with at least...
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: BZ#782439 - nfsconfig should be set with at least one daemon per processor .. packaging: BZ#782439 - nfsconfig should be set with at least one daemon per processor By default, NFS configuration file use 8 daemons per processor, we used none, so service failed to start properly. Change-Id: I5a25780fa683e66355b48a50299c0c24b20d0d12 (cherry picked from commit 16bfac6e93d68caa7d0e99b69ed9e82278be1d5b) --- M packaging/fedora/setup/nfs.sysconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a25780fa683e66355b48a50299c0c24b20d0d12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: virt-engine: Support RHEVManager url
Ofer Schreiber has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 4: Fails
(2 inline comments)
Please cherry-pick after merge to engine_3.0
File packaging/fedora/setup/engine-setup.py
Line 2167: xmlObj.addNodes("//web:subsystem:virtual-server", rewriteNode)
this should be changed
Line 2169: logging.debug("Configuring rewrite rules for jboss")
"Configured" is better here
--
To view, visit http://gerrit.ovirt.org/1120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c3ce188155bda87f5cc106e2a6c2408fb0da790
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
Gerrit-Reviewer: Doron Fediuck
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Ofer Schreiber
Gerrit-Reviewer: Ronen Angluster
Gerrit-Reviewer: Roy Golan
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: virt-engine: Support RHEVManager url
Ofer Schreiber has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 5: Fails
(1 inline comment)
File packaging/fedora/setup/engine-setup.py
Line 2167: xmlObj.addNodes("//web:subsystem:web:virtual-server",
rewriteNode)
it should be:
//web:subsystem/web:virtual-server
--
To view, visit http://gerrit.ovirt.org/1120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c3ce188155bda87f5cc106e2a6c2408fb0da790
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
Gerrit-Reviewer: Doron Fediuck
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Ofer Schreiber
Gerrit-Reviewer: Ronen Angluster
Gerrit-Reviewer: Roy Golan
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: virt-engine: Support RHEVManager url
Ofer Schreiber has posted comments on this change. Change subject: virt-engine: Support RHEVManager url .. Patch Set 6: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c3ce188155bda87f5cc106e2a6c2408fb0da790 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster Gerrit-Reviewer: Roy Golan ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: add tmpfiles.d rules for ovirt-engine lock dir (#...
Ofer Schreiber has posted comments on this change. Change subject: packaging: add tmpfiles.d rules for ovirt-engine lock dir (#771590) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53209e9e477973c6a69cd262da13e003a343cafb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: add tmpfiles.d rules for ovirt-engine lock dir (#...
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: add tmpfiles.d rules for ovirt-engine lock dir (#771590) .. packaging: add tmpfiles.d rules for ovirt-engine lock dir (#771590) http://bugzilla.redhat.com/771590 Add rules for /var/lock/ovirt-engine in tmpfiles.d so the directory will be created and persistent over reboots Change-Id: I53209e9e477973c6a69cd262da13e003a343cafb --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in A packaging/resources/ovirt-tmpfilesd 3 files changed, 4 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53209e9e477973c6a69cd262da13e003a343cafb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: packaging: add tmpfiles.d rules for ovirt-engine lock dir (#...
Ofer Schreiber has uploaded a new change for review. Change subject: packaging: add tmpfiles.d rules for ovirt-engine lock dir (#771590) .. packaging: add tmpfiles.d rules for ovirt-engine lock dir (#771590) http://bugzilla.redhat.com/771590 Add rules for /var/lock/ovirt-engine in tmpfiles.d so the directory will be created and persistent over reboots Change-Id: I53209e9e477973c6a69cd262da13e003a343cafb (cherry picked from commit 8c60f1b1019b60a63c96de9ea1039b521865caa1) --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in A packaging/resources/ovirt-tmpfilesd 3 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/1198/1 -- To view, visit http://gerrit.ovirt.org/1198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I53209e9e477973c6a69cd262da13e003a343cafb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: packaging: add tmpfiles.d rules for ovirt-engine lock dir (#...
Ofer Schreiber has posted comments on this change. Change subject: packaging: add tmpfiles.d rules for ovirt-engine lock dir (#771590) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53209e9e477973c6a69cd262da13e003a343cafb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: packaging: add tmpfiles.d rules for ovirt-engine lock dir (#...
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: add tmpfiles.d rules for ovirt-engine lock dir (#771590) .. packaging: add tmpfiles.d rules for ovirt-engine lock dir (#771590) http://bugzilla.redhat.com/771590 Add rules for /var/lock/ovirt-engine in tmpfiles.d so the directory will be created and persistent over reboots Change-Id: I53209e9e477973c6a69cd262da13e003a343cafb (cherry picked from commit 8c60f1b1019b60a63c96de9ea1039b521865caa1) --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in A packaging/resources/ovirt-tmpfilesd 3 files changed, 4 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53209e9e477973c6a69cd262da13e003a343cafb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: ovirt-engine - support long host fqdn in create_c...
Ofer Schreiber has posted comments on this change. Change subject: packaging: ovirt-engine - support long host fqdn in create_ca (#782810) .. Patch Set 1: (2 inline comments) Commit Message Line 7: packaging: ovirt-engine - support long host fqdn in create_ca (#782810) it's a patch in engine-setup (the whole git is for ovirt-engine) File packaging/fedora/setup/basedefs.py Line 140: CONST_MAX_HOST_FQDN_LEN=30 I would recommend to increase this to be the maximum (or something near (with a comments stating why we're choosing this number and it shouldn't be increased) -- To view, visit http://gerrit.ovirt.org/1187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f3c5584b54afb78a28c0c22c10649d6d559e247 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: ovirt-engine - support long host fqdn in create_c...
Ofer Schreiber has posted comments on this change. Change subject: packaging: ovirt-engine - support long host fqdn in create_ca (#782810) .. Patch Set 1: Fails -- To view, visit http://gerrit.ovirt.org/1187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f3c5584b54afb78a28c0c22c10649d6d559e247 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - support long host fqdn in create_c...
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-setup - support long host fqdn in create_ca (#782810) .. Patch Set 2: Fails (1 inline comment) File packaging/fedora/setup/basedefs.py Line 142: CONST_MAX_HOST_FQDN_LEN=40 This will cause the script to fail. -- To view, visit http://gerrit.ovirt.org/1187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f3c5584b54afb78a28c0c22c10649d6d559e247 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - support long host fqdn in create_c...
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-setup - support long host fqdn in create_ca (#782810) .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f3c5584b54afb78a28c0c22c10649d6d559e247 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Update configuration in logcollector and isouploa...
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Patch Set 1: Fails (2 inline comments) Commit looks good. Please fix the log path as well File backend/manager/tools/engine-iso-uploader/src/engine-iso-uploader.py Line 46: DEFAULT_LOG_FILE='/var/log/engine/engine-iso-uploader.log' I think this path is also wrong File backend/manager/tools/engine-logcollector/src/rhev/logcollector.py Line 29: DEFAULT_LOG_FILE='/var/log/engine/engine-log-collector.log' what about this path? -- To view, visit http://gerrit.ovirt.org/1270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I625e804d9a421af990edf32dbadbc21c83e6739e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Update configuration in logcollector and isouploa...
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Patch Set 2: Verified; Looks good to me, approved Perfect -- To view, visit http://gerrit.ovirt.org/1270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I625e804d9a421af990edf32dbadbc21c83e6739e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Update configuration in logcollector and isouploa...
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I625e804d9a421af990edf32dbadbc21c83e6739e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Update configuration in logcollector and isouploa...
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Packaging: Update configuration in logcollector and isouploader (#784303) https://bugzilla.redhat.com/show_bug.cgi?id=784303 Updated default configuration path for logcollector and isouploader configuration files. Fixed default log paths as well for logcollector and isouploader. Fixed creating "engine" option in configuration files instead of "rhevm" in engine-setup.py Change-Id: I625e804d9a421af990edf32dbadbc21c83e6739e --- M backend/manager/tools/engine-iso-uploader/src/engine-iso-uploader.py M backend/manager/tools/engine-logcollector/src/rhev/logcollector.py M packaging/fedora/setup/engine-setup.py 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I625e804d9a421af990edf32dbadbc21c83e6739e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: core : Clean up - "User is already logged in" error when try...
Ofer Schreiber has posted comments on this change. Change subject: core : Clean up - "User is already logged in" error when trying to login" .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie56deb344247d53f3ec3e571279037dd01d1e1d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Michael Kublin Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: core : Clean up - "User is already logged in" error when try...
Ofer Schreiber has submitted this change and it was merged. Change subject: core : Clean up - "User is already logged in" error when trying to login" .. core : Clean up - "User is already logged in" error when trying to login" This is a first part of the described fix, it is clean up before a fix. The following fix should solve a described error, it can occurred at some cases when user is failed to login but his session mistakenly kept Change-Id: Ie56deb344247d53f3ec3e571279037dd01d1e1d2 (cherry picked from commit 7fa20ce4d0b544c267e979d3c2acccab3624a18b) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 1 file changed, 17 insertions(+), 47 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie56deb344247d53f3ec3e571279037dd01d1e1d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Michael Kublin Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - Remove locale check (#769319)
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-setup - Remove locale check (#769319) .. Patch Set 1: Fails (1 inline comment) Please fix whitespace and resend. all other stuff looks good. File packaging/fedora/setup/output_messages.py Line 345: ERR_EXP_FAILED_KERNEL_PARAMS="Error: failed setting the kernel parameters" please remove this additional whitespace at the ebd -- To view, visit http://gerrit.ovirt.org/1269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb41855dad22a871b02d0f5904186bbc354f00f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Mansano Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: core : "User is already logged in" error when trying to logi...
Ofer Schreiber has posted comments on this change. Change subject: core : "User is already logged in" error when trying to login" .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83c34e2ed694eada9db7776a86944e8faeab8e60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Michael Kublin Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Michael Kublin Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: core : "User is already logged in" error when trying to logi...
Ofer Schreiber has submitted this change and it was merged. Change subject: core : "User is already logged in" error when trying to login" .. core : "User is already logged in" error when trying to login" The following fix should solve a described error, it can occurred at some cases when user is failed to login but his session mistakenly kept Change-Id: I83c34e2ed694eada9db7776a86944e8faeab8e60 (cherry picked from commit 1a10f641da6b88d417386436a73230eb5568aee9) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginAdminUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 2 files changed, 23 insertions(+), 16 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83c34e2ed694eada9db7776a86944e8faeab8e60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Michael Kublin Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Michael Kublin Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update configuration in logcollector and isouploa...
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I625e804d9a421af990edf32dbadbc21c83e6739e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update configuration in logcollector and isouploa...
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Packaging: Update configuration in logcollector and isouploader (#784303) https://bugzilla.redhat.com/show_bug.cgi?id=784303 Updated default configuration path for logcollector and isouploader configuration files. Fixed default log paths as well for logcollector and isouploader. Fixed creating "engine" option in configuration files instead of "rhevm" in engine-setup.py Change-Id: I625e804d9a421af990edf32dbadbc21c83e6739e (cherry picked from commit 6250645f115bf45a8904161d48ff816357e91a55) --- M backend/manager/tools/engine-iso-uploader/src/engine-iso-uploader.py M backend/manager/tools/engine-logcollector/src/rhev/logcollector.py M packaging/fedora/setup/engine-setup.py 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I625e804d9a421af990edf32dbadbc21c83e6739e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Update ssh configuration in logcollector (#784568...
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update ssh configuration in logcollector (#784568) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759d0ee7f6a370700f2864b37d9c869d38fc5bbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Update ssh configuration in logcollector (#784568...
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: Update ssh configuration in logcollector (#784568) .. Packaging: Update ssh configuration in logcollector (#784568) https://bugzilla.redhat.com/show_bug.cgi?id=784568 Fixed default ssh keys path for logcollector configuration file. Change-Id: I759d0ee7f6a370700f2864b37d9c869d38fc5bbc --- M backend/manager/tools/engine-logcollector/src/rhev/logcollector.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759d0ee7f6a370700f2864b37d9c869d38fc5bbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update ssh configuration in logcollector (#784568...
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update ssh configuration in logcollector (#784568) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759d0ee7f6a370700f2864b37d9c869d38fc5bbc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update ssh configuration in logcollector (#784568...
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update ssh configuration in logcollector (#784568) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759d0ee7f6a370700f2864b37d9c869d38fc5bbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update ssh configuration in logcollector (#784568...
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: Update ssh configuration in logcollector (#784568) .. Packaging: Update ssh configuration in logcollector (#784568) https://bugzilla.redhat.com/show_bug.cgi?id=784568 Fixed default ssh keys path for logcollector configuration file. Change-Id: I759d0ee7f6a370700f2864b37d9c869d38fc5bbc (cherry picked from commit 2c220d5ff64a51747c591f54f8371e4c94831fc2) --- M backend/manager/tools/engine-logcollector/src/rhev/logcollector.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759d0ee7f6a370700f2864b37d9c869d38fc5bbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - Remove locale check (#769319)
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-setup - Remove locale check (#769319) .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb41855dad22a871b02d0f5904186bbc354f00f7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Mansano Gerrit-Reviewer: Idan Mansano Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - Remove locale check (#769319)
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-setup - Remove locale check (#769319) .. packaging: engine-setup - Remove locale check (#769319) https://bugzilla.redhat.com/show_bug.cgi?id=769319 engine-setup won't validate locale in the system Change-Id: Ibb41855dad22a871b02d0f5904186bbc354f00f7 --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/output_messages.py 3 files changed, 1 insertion(+), 20 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb41855dad22a871b02d0f5904186bbc354f00f7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Mansano Gerrit-Reviewer: Idan Mansano Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup -support long host fqdn (#782810)
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-setup -support long host fqdn (#782810) .. Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f3c5584b54afb78a28c0c22c10649d6d559e247 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Updated ambiguous text message (#784206)
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Updated ambiguous text message (#784206) .. Patch Set 1: Fails (2 inline comments) Two comments inside Commit Message Line 11: Description: No need for "Description" File packaging/fedora/setup/output_messages.py Line 144: WARN_LOW_MEMORY="There is less than %s GB of available free memory on this machine.\nIt is recommended to have at least %s GB of available memory to run the Engine Manager." % (basedefs.CONST_WARN_MEMORY_GB, basedefs.CONST_WARN_MEMORY_GB) the official name is oVirt-Engine (and not Engine Manager). Better separate it to another variable (and check if we user rhevm/RHEV Manager) in other variables. -- To view, visit http://gerrit.ovirt.org/1291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia89016c6bc5ac423b781c4daba07447988c68b30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup -support long host fqdn (#782810)
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-setup -support long host fqdn (#782810) .. Patch Set 7: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f3c5584b54afb78a28c0c22c10649d6d559e247 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Updated ambiguous text message (#784206)
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Updated ambiguous text message (#784206) .. Patch Set 2: Fails Just drop the"description" word, not the entire description. -- To view, visit http://gerrit.ovirt.org/1291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia89016c6bc5ac423b781c4daba07447988c68b30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Updated ambiguous text message (#784206)
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Updated ambiguous text message (#784206) .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia89016c6bc5ac423b781c4daba07447988c68b30 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Updated release definition (#784425)
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Updated release definition (#784425) .. Patch Set 1: Fails -- To view, visit http://gerrit.ovirt.org/1318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f45b2c8a7231dce5022d7fac0b5a019976ab221 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Updated ambiguous text message (#784206)
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Updated ambiguous text message (#784206) .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia89016c6bc5ac423b781c4daba07447988c68b30 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Updated ambiguous text message (#784206)
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: Updated ambiguous text message (#784206) .. Packaging: Updated ambiguous text message (#784206) https://bugzilla.redhat.com/show_bug.cgi?id=784206 Updated the text mentioning the minimal free memory requirements. Replaced reference to RHEV with ovirt-engine. Change-Id: Ia89016c6bc5ac423b781c4daba07447988c68b30 --- M packaging/fedora/setup/output_messages.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia89016c6bc5ac423b781c4daba07447988c68b30 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup -support long host fqdn (#782810)
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-setup -support long host fqdn (#782810) .. Patch Set 8: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f3c5584b54afb78a28c0c22c10649d6d559e247 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup -support long host fqdn (#782810)
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-setup -support long host fqdn (#782810) .. packaging: engine-setup -support long host fqdn (#782810) - fixed installCA.sh to exit on error - truncate long fqdn host to avoid failure in create ca Change-Id: I7f3c5584b54afb78a28c0c22c10649d6d559e247 --- M backend/manager/conf/ca/installCA.sh M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-setup.py 3 files changed, 12 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f3c5584b54afb78a28c0c22c10649d6d559e247 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: change engine-db-install to support sysv & system...
Ofer Schreiber has posted comments on this change. Change subject: packaging: change engine-db-install to support sysv & systemd .. Patch Set 2: Fails (4 inline comments) Patch looks good, few comments inside. File backend/manager/dbscripts/engine-db-install.sh Line 39: POSTGRESQL_SERVICE=postgresql.service Both *_SERVICE are pretty confusing... Line 43:SYSTEMD_SUPPORT=1 Better put "else: SYSTEMD_SUPPORT=0" Line 134:if [ $SYSTEMD_SUPPORT -eq 1 ] If SYSTEMD_SUPPORT won't be defined, the script will throw few errors... Line 170: if [ $SYSTEMD_SUPPORT -eq 1 ] Same here, SYSTEMD_SUPPORT must be defined -- To view, visit http://gerrit.ovirt.org/1313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If71f737f88da9228938389ed6bc558d091935b0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: change engine-db-install to support sysv & system...
Ofer Schreiber has posted comments on this change. Change subject: packaging: change engine-db-install to support sysv & systemd .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If71f737f88da9228938389ed6bc558d091935b0e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Updated release definition (#784425)
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Updated release definition (#784425) .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f45b2c8a7231dce5022d7fac0b5a019976ab221 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: backend: change how encryptpasswd look for jars
Ofer Schreiber has posted comments on this change. Change subject: backend: change how encryptpasswd look for jars .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4701064d05db36b67b5028d590d27a456c1990c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: change engine-db-install to support sysv & system...
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: change engine-db-install to support sysv & systemd .. packaging: change engine-db-install to support sysv & systemd Change engine-db-install in order to support sysv init scripts and systemd in the same code Change-Id: If71f737f88da9228938389ed6bc558d091935b0e --- M backend/manager/dbscripts/engine-db-install.sh 1 file changed, 39 insertions(+), 15 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If71f737f88da9228938389ed6bc558d091935b0e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: change engine-db-install to support sysv & system...
Ofer Schreiber has posted comments on this change. Change subject: packaging: change engine-db-install to support sysv & systemd .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If71f737f88da9228938389ed6bc558d091935b0e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: virt-engine: Support RHEVManager url
Ofer Schreiber has posted comments on this change. Change subject: virt-engine: Support RHEVManager url .. Patch Set 6: No score -- To view, visit http://gerrit.ovirt.org/1120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c3ce188155bda87f5cc106e2a6c2408fb0da790 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster Gerrit-Reviewer: Roy Golan ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: add userportal-gwtp.war to spec file
Ofer Schreiber has posted comments on this change. Change subject: packaging: add userportal-gwtp.war to spec file .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaa654257b4e8e30529ac2af58ec20e917bbefc6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: add userportal-gwtp.war to spec file
Ofer Schreiber has posted comments on this change. Change subject: packaging: add userportal-gwtp.war to spec file .. -- To view, visit http://gerrit.ovirt.org/1382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaa654257b4e8e30529ac2af58ec20e917bbefc6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: use files instead of pipe in execCmd
Ofer Schreiber has posted comments on this change. Change subject: packaging: use files instead of pipe in execCmd .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica39e946b9ee3e13b343ebe619ef2c770d170e8f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Idan Mansano Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: use files instead of pipe in execCmd
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: use files instead of pipe in execCmd .. packaging: use files instead of pipe in execCmd Add a flag for common_utils.execCmd to use real files instead of the subprocess pipes (subprocess.PIPE) this change has been crafted in order to by pass "forked fork" processes which holds stdout & stderr open and hangs subprocess when using pipes for stdout & stderr. Change-Id: Ica39e946b9ee3e13b343ebe619ef2c770d170e8f --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py 2 files changed, 25 insertions(+), 5 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica39e946b9ee3e13b343ebe619ef2c770d170e8f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Idan Mansano Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: add userportal-gwtp.war to spec file
Ofer Schreiber has posted comments on this change. Change subject: packaging: add userportal-gwtp.war to spec file .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaa654257b4e8e30529ac2af58ec20e917bbefc6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: Revert "engine-core: log the host name when can't connect (#...
Ofer Schreiber has submitted this change and it was merged. Change subject: Revert "engine-core: log the host name when can't connect (#766287)" .. Revert "engine-core: log the host name when can't connect (#766287)" This reverts commit b86418910fcb4353e8ad9f1bf5446061d544071f -- ofrenkel https://bugzilla.redhat.com/show_bug.cgi?id=782432 Change-Id: Ia2b492e81e620f616102bb733d4cb74a4f1d1cb4 (cherry picked from commit 726eae8bd7649a0ad3031c24345f81234e2653c1) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 2 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2b492e81e620f616102bb733d4cb74a4f1d1cb4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Doron Fediuck Gerrit-Reviewer: Laszlo Hornyak Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Omer Frenkel ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: Revert "engine-core: log the host name when can't connect (#...
Ofer Schreiber has posted comments on this change. Change subject: Revert "engine-core: log the host name when can't connect (#766287)" .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b492e81e620f616102bb733d4cb74a4f1d1cb4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Doron Fediuck Gerrit-Reviewer: Laszlo Hornyak Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Omer Frenkel ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: engine : Added additional release of lock
Ofer Schreiber has posted comments on this change. Change subject: engine : Added additional release of lock .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea6d2ba94dcf30feb0b513ed0a5a533a15a11b44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Doron Fediuck Gerrit-Reviewer: Michael Kublin Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Omer Frenkel ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: add userportal-gwtp.war to spec file
Ofer Schreiber has posted comments on this change. Change subject: packaging: add userportal-gwtp.war to spec file .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaa654257b4e8e30529ac2af58ec20e917bbefc6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: add userportal-gwtp.war to spec file
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: add userportal-gwtp.war to spec file .. packaging: add userportal-gwtp.war to spec file add a definition for userportal-gwtp.war in the spec file Change-Id: Ifaa654257b4e8e30529ac2af58ec20e917bbefc6 --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaa654257b4e8e30529ac2af58ec20e917bbefc6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: changed the way engine-cleanup removes DB (#78217...
Ofer Schreiber has posted comments on this change. Change subject: Packaging: changed the way engine-cleanup removes DB (#782176) .. Patch Set 1: Fails (3 inline comments) File packaging/fedora/setup/engine-cleanup.py Line 231: cmd = ["/usr/bin/psql", "-U", basedefs.DB_ADMIN, "-c", clearQuery] Please use CONSTANT instead of /usr/bin/psql Line 232: output, rc = utils.execCmd(cmd, None, True, MSG_ERROR_CLEAR_DB_CONNECTIONS, []) Please drop the [ ] Line 233: if (rc != 0): No need for this rc check -- To view, visit http://gerrit.ovirt.org/1407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie76a9f61ab8092156c1ad9a8b7772fbe4a6796ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: changed the way engine-cleanup removes DB (#78217...
Ofer Schreiber has posted comments on this change. Change subject: Packaging: changed the way engine-cleanup removes DB (#782176) .. Patch Set 2: Fails (2 inline comments) File packaging/fedora/setup/engine-cleanup.py Line 231: """ Block New connections and disconnect active ones """ Use # for comments Line 236: """ Drop DB """ same here -- To view, visit http://gerrit.ovirt.org/1407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie76a9f61ab8092156c1ad9a8b7772fbe4a6796ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: changed the way engine-cleanup removes DB (#78217...
Ofer Schreiber has posted comments on this change. Change subject: Packaging: changed the way engine-cleanup removes DB (#782176) .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie76a9f61ab8092156c1ad9a8b7772fbe4a6796ac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: changed the way engine-cleanup removes DB (#78217...
Ofer Schreiber has posted comments on this change. Change subject: Packaging: changed the way engine-cleanup removes DB (#782176) .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie76a9f61ab8092156c1ad9a8b7772fbe4a6796ac Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: changed the way engine-cleanup removes DB (#78217...
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: changed the way engine-cleanup removes DB (#782176) .. Packaging: changed the way engine-cleanup removes DB (#782176) https://bugzilla.redhat.com/show_bug.cgi?id=782176 Updated the way engine-cleanup drops DB. First it blocks new connections, then disconnects all active connections to 'engine'. Then it drops the 'engine' DB. Change-Id: Ie76a9f61ab8092156c1ad9a8b7772fbe4a6796ac --- M packaging/fedora/setup/engine-cleanup.py 1 file changed, 14 insertions(+), 7 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie76a9f61ab8092156c1ad9a8b7772fbe4a6796ac Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Updated release definition (#784425)
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Updated release definition (#784425) .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f45b2c8a7231dce5022d7fac0b5a019976ab221 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: Updated release definition (#784425)
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: Updated release definition (#784425) .. Packaging: Updated release definition (#784425) https://bugzilla.redhat.com/show_bug.cgi?id=784425 Defined a new static parameter RELEASE_VERSION in Makefile. Updated Makefile to use it for the following: * Create corresponding 'Release' value in spec file. * Create corresponding Welcome message in oVirt-Engine. Change-Id: I6f45b2c8a7231dce5022d7fac0b5a019976ab221 (cherry picked from commit 204db5911039816a7ff742858caecac3a6c23b60) --- M Makefile 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f45b2c8a7231dce5022d7fac0b5a019976ab221 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: fixed incorrect configuration parameter (#786143)
Ofer Schreiber has posted comments on this change. Change subject: Packaging: fixed incorrect configuration parameter (#786143) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2b3157b2722343c8940cbdd5cbe6fbd513e13f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: Packaging: fixed incorrect configuration parameter (#786143)
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: fixed incorrect configuration parameter (#786143) .. Packaging: fixed incorrect configuration parameter (#786143) https://bugzilla.redhat.com/show_bug.cgi?id=786143 Fixed incorrect configuration parameter creation. Fixed to use 'engine' instead of 'rhevm'. Change-Id: Id2b3157b2722343c8940cbdd5cbe6fbd513e13f8 --- M backend/manager/tools/engine-logcollector/src/rhev/logcollector.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2b3157b2722343c8940cbdd5cbe6fbd513e13f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: fixed incorrect configuration parameter (#786143)
Ofer Schreiber has posted comments on this change. Change subject: Packaging: fixed incorrect configuration parameter (#786143) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2b3157b2722343c8940cbdd5cbe6fbd513e13f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: fixed incorrect configuration parameter (#786143)
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: fixed incorrect configuration parameter (#786143) .. Packaging: fixed incorrect configuration parameter (#786143) https://bugzilla.redhat.com/show_bug.cgi?id=786143 Fixed incorrect configuration parameter creation. Fixed to use 'engine' instead of 'rhevm'. Change-Id: Id2b3157b2722343c8940cbdd5cbe6fbd513e13f8 (cherry picked from commit f87a6a0f2efa32088e8e57c12e74d133de6fd161) --- M backend/manager/tools/engine-logcollector/src/rhev/logcollector.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2b3157b2722343c8940cbdd5cbe6fbd513e13f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: pacakging: Edit restapi rpm description
Ofer Schreiber has uploaded a new change for review. Change subject: pacakging: Edit restapi rpm description .. pacakging: Edit restapi rpm description Removed "Red Hat" from ovirt-engine-restapi rpm description Change-Id: Ia7efb55eb02e62855d0640867ce00ad1ff7ffc5e --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/1636/1 -- To view, visit http://gerrit.ovirt.org/1636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7efb55eb02e62855d0640867ce00ad1ff7ffc5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#...
Ofer Schreiber has posted comments on this change. Change subject: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#784850) .. Patch Set 1: looks OK, but what is the packaging/ovirtlogrot.sh I see in the git? -- To view, visit http://gerrit.ovirt.org/1624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2b540582c0641fa96e3f1380cee73c53e05967d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#...
Ofer Schreiber has posted comments on this change. Change subject: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#784850) .. Patch Set 1: Fails -- To view, visit http://gerrit.ovirt.org/1624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2b540582c0641fa96e3f1380cee73c53e05967d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: pacakging: Edit rpm descripions
Ofer Schreiber has posted comments on this change. Change subject: pacakging: Edit rpm descripions .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7efb55eb02e62855d0640867ce00ad1ff7ffc5e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: pacakging: Edit rpm descripions
Ofer Schreiber has submitted this change and it was merged. Change subject: pacakging: Edit rpm descripions .. pacakging: Edit rpm descripions Subtitute "Open Virtualization Manager" with "oVirt Engine" and Removed "Red Hat" from rpm descriptions. Change-Id: Ia7efb55eb02e62855d0640867ce00ad1ff7ffc5e --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 29 insertions(+), 29 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7efb55eb02e62855d0640867ce00ad1ff7ffc5e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#...
Ofer Schreiber has posted comments on this change. Change subject: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#784850) .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2b540582c0641fa96e3f1380cee73c53e05967d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: packaging - Remove release field from tarball
Ofer Schreiber has uploaded a new change for review. Change subject: sdk: packaging - Remove release field from tarball .. sdk: packaging - Remove release field from tarball The source tarball shouldn't containt the "release" attribute, it is up to the spec file to specify the release. Change-Id: Id9d8aff11cb116acffa5421f571314154859addf --- M Makefile M ovirt-engine-sdk.spec.in 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-sdk refs/changes/98/1698/1 -- To view, visit http://gerrit.ovirt.org/1698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id9d8aff11cb116acffa5421f571314154859addf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#...
Ofer Schreiber has posted comments on this change. Change subject: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#784850) .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2b540582c0641fa96e3f1380cee73c53e05967d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#...
Ofer Schreiber has posted comments on this change. Change subject: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#784850) .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2b540582c0641fa96e3f1380cee73c53e05967d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#...
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#784850) .. packaging: Fixed using "ovirt-engine" instead of 'rhevm' (#784850) https://bugzilla.redhat.com/show_bug.cgi?id=784850 Updates to logging and archiving of engine.log: * Fixed using 'ovirt-engine' instead of 'rhevm' in logging from ovirt-cron. * Fixed using ovirtlogrot.sh from the correct path when deployed. * Moved ovirtlogrot.sh from 'packaging' to 'packaging/resources' folder in dev tree. * Fixed Makefile to deploy ovirtlogrot.sh from the updated location. * Updated ovirtlogrot.sh script to archive the correct log files. * Removed obsolete engine-cron script and its corresponding engine.logrotate configuration file. Change-Id: If2b540582c0641fa96e3f1380cee73c53e05967d --- M Makefile D packaging/fedora/setup/resources/engine-cron D packaging/fedora/setup/resources/engine.logrotate M packaging/resources/ovirt-cron R packaging/resources/ovirtlogrot.sh 5 files changed, 8 insertions(+), 26 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2b540582c0641fa96e3f1380cee73c53e05967d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: Rename engine war to ovirtengine
Ofer Schreiber has uploaded a new change for review. Change subject: packaging: Rename engine war to ovirtengine .. packaging: Rename engine war to ovirtengine Rename engineager.war to ovirtengine.war according to 6ce3923824aab0d4b36223df44b60a8f033451ae Change-Id: I16c18200928ebaa3f0c50846a120d111b52ad873 --- M packaging/fedora/setup/basedefs.py M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/1725/1 -- To view, visit http://gerrit.ovirt.org/1725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I16c18200928ebaa3f0c50846a120d111b52ad873 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: Rename engine war to ovirtengine
Ofer Schreiber has posted comments on this change. Change subject: packaging: Rename engine war to ovirtengine .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16c18200928ebaa3f0c50846a120d111b52ad873 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster Gerrit-Reviewer: Roy Golan ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: Rename engine war to ovirtengine
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Rename engine war to ovirtengine .. packaging: Rename engine war to ovirtengine Rename engineager.war to ovirtengine.war according to 6ce3923824aab0d4b36223df44b60a8f033451ae Change-Id: I16c18200928ebaa3f0c50846a120d111b52ad873 --- M packaging/fedora/setup/basedefs.py M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16c18200928ebaa3f0c50846a120d111b52ad873 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster Gerrit-Reviewer: Roy Golan ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: packaging: Rename engine war to ovirtengine
Ofer Schreiber has uploaded a new change for review. Change subject: packaging: Rename engine war to ovirtengine .. packaging: Rename engine war to ovirtengine Rename engineager.war to ovirtengine.war according to 6ce3923824aab0d4b36223df44b60a8f033451ae Change-Id: I16c18200928ebaa3f0c50846a120d111b52ad873 (cherry picked from commit 4013b5f1ca50cc13e195ecfdbe02b08ab8c3b057) --- M packaging/fedora/setup/basedefs.py M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/29/1729/1 -- To view, visit http://gerrit.ovirt.org/1729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I16c18200928ebaa3f0c50846a120d111b52ad873 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: packaging: Rename engine war to ovirtengine
Ofer Schreiber has posted comments on this change. Change subject: packaging: Rename engine war to ovirtengine .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/1729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16c18200928ebaa3f0c50846a120d111b52ad873 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: packaging: Rename engine war to ovirtengine
Ofer Schreiber has posted comments on this change. Change subject: packaging: Rename engine war to ovirtengine .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16c18200928ebaa3f0c50846a120d111b52ad873 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[engine_3.0]: packaging: Rename engine war to ovirtengine
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Rename engine war to ovirtengine .. packaging: Rename engine war to ovirtengine Rename engineager.war to ovirtengine.war according to 6ce3923824aab0d4b36223df44b60a8f033451ae Change-Id: I16c18200928ebaa3f0c50846a120d111b52ad873 (cherry picked from commit 4013b5f1ca50cc13e195ecfdbe02b08ab8c3b057) --- M packaging/fedora/setup/basedefs.py M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Ronen Angluster: Verified; Looks good to me, but someone else must approve Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16c18200928ebaa3f0c50846a120d111b52ad873 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: packaging: Update spec file to Fedora 17
Ofer Schreiber has uploaded a new change for review. Change subject: sdk: packaging: Update spec file to Fedora 17 .. sdk: packaging: Update spec file to Fedora 17 Update the spec file according to the one submitted into Fedora 17. * Updated source0 link * Added BuildArch (noarch) Change-Id: I5a012eec7b322d3fe93ff8f2bf56bddf687f18cd --- M ovirt-engine-sdk.spec.in 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-sdk refs/changes/54/1754/1 -- To view, visit http://gerrit.ovirt.org/1754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5a012eec7b322d3fe93ff8f2bf56bddf687f18cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: packaging: Update spec file to Fedora 17
Ofer Schreiber has posted comments on this change. Change subject: sdk: packaging: Update spec file to Fedora 17 .. Patch Set 1: (1 inline comment) File ovirt-engine-sdk.spec.in Line 42: Since it's the text we submitted to Fedora (That's the way to push new version) -- To view, visit http://gerrit.ovirt.org/1754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a012eec7b322d3fe93ff8f2bf56bddf687f18cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber Gerrit-Reviewer: Michael Pasternak Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: Add engine-upgrade utility
Ofer Schreiber has uploaded a new change for review. Change subject: packaging: Add engine-upgrade utility .. packaging: Add engine-upgrade utility Introducing engine-upgrade utility, new utility for upgrading ovirt-engine. Using yum-plugin-versionlock, engine-setup will now lock existing critical rpms, so the upgrade utility will take care of the complete upgrade path. Change-Id: Ic0bac004c8a8bf93f9b3d3bc7e2efe5b0ec2823a --- M Makefile M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py A packaging/fedora/setup/engine-check-update M packaging/fedora/setup/engine-setup.py A packaging/fedora/setup/engine-upgrade.py A packaging/fedora/setup/post_upgrade.py M packaging/fedora/spec/ovirt-engine.spec.in 8 files changed, 760 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/1801/1 -- To view, visit http://gerrit.ovirt.org/1801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0bac004c8a8bf93f9b3d3bc7e2efe5b0ec2823a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: packaging: copy engine-encryptutils.jar
Ofer Schreiber has posted comments on this change. Change subject: packaging: copy engine-encryptutils.jar .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I878617a469275e203fd62ad35de4926c0ad3c085 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Ofer Schreiber Gerrit-Reviewer: Ronen Angluster ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
[Engine-patches] Change in ovirt-engine[master]: dbscripts: fix adjustment for engine-db-install to support s...
Ofer Schreiber has posted comments on this change. Change subject: dbscripts: fix adjustment for engine-db-install to support systemd .. Patch Set 1: Fails (2 inline comments) File backend/manager/dbscripts/engine-db-install.sh Line 187: /bin/systemctl status postgresql.service >> $LOG_FILE 2>&1 Please use CONSTs here Line 195: /bin/systemctl start postgresql.service >> $LOG_FILE 2>&1 same here -- To view, visit http://gerrit.ovirt.org/1844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If442cbf9eaef4c429bd91b800d93bf84eac3e74f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ofer Schreiber ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
