[elpa] externals/corfu aee555e: Document another bug, frame border is not updated appropriately
branch: externals/corfu commit aee555ea7de0b74906c014c5754c8c6fb2a0c44b Author: Daniel Mendler Commit: Daniel Mendler Document another bug, frame border is not updated appropriately --- corfu.el | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/corfu.el b/corfu.el index 4417154..534fd14 100644 --- a/corfu.el +++ b/corfu.el @@ -322,14 +322,15 @@ filter string with spaces is allowed." ;; XXX HACK Setting the same frame-parameter/face-background is not a nop (BUG!). ;; Check explicitly before applying the setting. ;; Without the check, the frame flickers on Mac. -;; With the check, the inner frame sometimes does not get updated sometimes (BUG!). -(let ((new (face-attribute 'corfu-background :background))) - (unless (equal (frame-parameter corfu--frame 'background-color) new) - (set-frame-parameter corfu--frame 'background-color new))) +;; XXX HACK We have to apply the face background before adjusting the frame parameter, +;; otherwise the border is not updated (BUG!). (let* ((face (if (facep 'child-frame-border) 'child-frame-border 'internal-border)) (new (face-attribute 'corfu-border :background))) (unless (equal (face-attribute face :background corfu--frame) new) (set-face-background face new corfu--frame))) +(let ((new (face-attribute 'corfu-background :background))) + (unless (equal (frame-parameter corfu--frame 'background-color) new) + (set-frame-parameter corfu--frame 'background-color new))) (set-window-buffer (frame-root-window corfu--frame) buffer) ;; XXX HACK Make the frame invisible before moving the popup from above to below the line in ;; order to avoid flicker.
[elpa] externals/corfu 0e84897: README: Remove multi-capf backend idea
branch: externals/corfu commit 0e8489751acc9c28ec2e6c1218ef4202dc6c6eff Author: Daniel Mendler Commit: Daniel Mendler README: Remove multi-capf backend idea It turns out the comint completion backend supports additional file completions (See #9). --- README.org | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/README.org b/README.org index dfd3e15..eea3657 100644 --- a/README.org +++ b/README.org @@ -34,9 +34,9 @@ * Features - - Timer-based auto-completions (off by default, set ~corfu-auto~) + - Timer-based auto-completions (/off/ by default, set ~corfu-auto~) - Popup display with scrollbar indicator and arrow key navigation - - The popup must be summoned explicitly by pressing =TAB= + - In manual mode, the popup must be summoned explicitly by pressing =TAB= - The current candidate is inserted with =TAB= and selected with =RET= - Candidates sorting by prefix, string length and alphabetically - Completion is automatically terminated after candidate selection @@ -143,15 +143,14 @@ * Caveats - Corfu works in most scenarios. However there are a few known technical caveats. + Corfu works well in most scenarios. However there are a few known technical + caveats. - Corfu falls back to the default Completion buffer on non-graphical displays, since Corfu requires child frames. - The abort handling could be improved, for example the input could be undone. - Company kind icons, docsig and match data are not supported (~company-kind~, ~company-docsig~, ~company-match~). - - No support for multi-backends like Company. A possible multi-capf backend -could be implemented. - No sorting by history, since ~completion-at-point~ does not maintain a history (See branch =history= for a possible solution).
