[Bug libelf/23903] Uses linux specifc mremap
https://sourceware.org/bugzilla/show_bug.cgi?id=23903 Jean Michault changed: What|Removed |Added CC||bibi584762 at gmail dot com --- Comment #8 from Jean Michault --- Created attachment 11932 --> https://sourceware.org/bugzilla/attachment.cgi?id=11932&action=edit patch to allow compile on systems without mremap I suggest the patch attached. This makes it possible to compile elfutils on nonlinux systems, but generates an error if one tries to use features that need mremap. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libelf/23903] Uses linux specifc mremap
https://sourceware.org/bugzilla/show_bug.cgi?id=23903 --- Comment #10 from Jean Michault --- (In reply to Mark Wielaard from comment #9) > (In reply to Jean Michault from comment #8) > > Created attachment 11932 [details] > > patch to allow compile on systems without mremap > > > > I suggest the patch attached. > > This makes it possible to compile elfutils on nonlinux systems, but > > generates an error if one tries to use features that need mremap. > > Thanks. Some questions about the proposed patch: > - What defines HAVE_MMAP? > I don't believe we currently have a configure check for it, should we? > - The guard checks for HAVE_MMAP, but the code calls mremap. > Should we have a HAVE_MREMAP guard and configure check instead? > - On which systems did you test and what were the make check results? You're right, i was a little too fast, you can have mmap without having mremap, so you have to test mremap. And we need to add the mremap test in configure.ac. I will work again. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libelf/23903] Uses linux specifc mremap
https://sourceware.org/bugzilla/show_bug.cgi?id=23903 Jean Michault changed: What|Removed |Added Attachment #11932|0 |1 is obsolete|| --- Comment #11 from Jean Michault --- Created attachment 11933 --> https://sourceware.org/bugzilla/attachment.cgi?id=11933&action=edit patch to allow compile on systems without mremap -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libelf/23903] Uses linux specifc mremap
https://sourceware.org/bugzilla/show_bug.cgi?id=23903 --- Comment #12 from Jean Michault --- (In reply to Mark Wielaard from comment #9) > (In reply to Jean Michault from comment #8) > > Created attachment 11932 [details] > > patch to allow compile on systems without mremap > > > > I suggest the patch attached. > > This makes it possible to compile elfutils on nonlinux systems, but > > generates an error if one tries to use features that need mremap. > > Thanks. Some questions about the proposed patch: > - What defines HAVE_MMAP? > I don't believe we currently have a configure check for it, should we? > - The guard checks for HAVE_MMAP, but the code calls mremap. > Should we have a HAVE_MREMAP guard and configure check instead? > - On which systems did you test and what were the make check results? I propose another patch that checks mremap. I tested on a debian system GNU / Hurd 2019. The compilation is going well but some tests fail: Testsuite summary for elfutils 0.176 # TOTAL: 205 # PASS: 170 # SKIP: 23 # XFAIL: 0 # FAIL: 12 # XPASS: 0 # ERROR: 0 failing tests are : FAIL: run-readelf-loc.sh FAIL: run-readelf-ranges.sh FAIL: run-bug1-test.sh FAIL: run-varlocs.sh FAIL: run-allfcts-multi.sh FAIL: elfstrtab FAIL: emptyfile FAIL: run-get-units-split.sh FAIL: run-attr-integrate-skel.sh FAIL: run-all-dwarf-ranges.sh FAIL: run-unit-info.sh FAIL: run-copyadd-sections.sh -- You are receiving this mail because: You are on the CC list for the bug.
