Re: [PATCH] Take latest of archive and file mtime

[Frank Ch. Eigler]

Hi -

> [...]
> Every time you rebuild some packages, the package files are rebuilt with the
> new contents. When this happens, the new package files will have a newer
> mtime, but the files inside the archive (elf, source) will have the same
> fixed timestamp as before. 

Do I understand this part correctly: that yocto package-file
filestamps are normal (reflect their actual unique-ish creation time),
but the timestamps of constituent files are synthetic (and may be
backdated / duplicate)?

> And when debuginfod will traverse them (without the patch I
> propose), it will not update the database because it will find
> consider that the files inside the packages were not modified. [...]

That's not how debuginfod works though.  It decides to reanalyze
archives based on the archive mtime, not the constituent file mtime.
Your patch only affects the "_r_seekable.mtime" column, which I
believe is not used for any sort of caching/invalidation type logic.

> [...]  That's the problem I'm facing where, before my patch, the
> only thing I could do was to remove the sqlite debuginfod database
> and index all again every time I rebuild a package in the yocto
> distribution, to have debuginfod serving the new debuginfo
> correctly.

Yeah, that shouldn't be necessary.

Maybe we could make this discussion more concrete by having you show
us an actual example.  Two different yocto package versions, with
detailed timestamp/content listings, ingested into an otherwise empty
debuginfod database one at a time, and doing a database dump after
both completed scan operations.

- FChE

[PATCH 1/1] debuginfod: add --http-addr option

[Michael Trapp]

Use MHD_OPTION_SOCK_ADDR to bind the http listen socket to a single address.
The address can be any IPv4 or IPv6 address configured on the system:
--http-addr=127.0.0.1
--http-addr=::1
--http-addr='ANY_ACTIVE_LOCAL_IP_ADDRESS'
As debuginfod does not include any security features, a listen on the
localhost address is sufficient for a HTTP/HTTPS reverse-proxy setup.
---
 debuginfod/debuginfod.cxx | 115 ++
 doc/debuginfod.8  |   5 ++
 2 files changed, 84 insertions(+), 36 deletions(-)

diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index 0edd57cb..30916093 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -81,6 +81,7 @@ extern "C" {
 #include 
 #include 
 #include 
+#include 
 
 
 /* If fts.h is included before config.h, its indirect inclusions may not
@@ -481,6 +482,8 @@ static const struct argp_option options[] =
 #define ARGP_KEY_METADATA_MAXTIME 0x100C
{ "metadata-maxtime", ARGP_KEY_METADATA_MAXTIME, "SECONDS", 0,
  "Number of seconds to limit metadata query run time, 0=unlimited.", 0 },
+#define ARGP_KEY_HTTP_ADDR 0x100D
+   { "http-addr", ARGP_KEY_HTTP_ADDR, "ADDR", 0, "HTTP address to listen on.", 
0 },
{ NULL, 0, NULL, 0, NULL, 0 },
   };
 
@@ -512,6 +515,8 @@ static volatile sig_atomic_t sigusr1 = 0;
 static volatile sig_atomic_t forced_groom_count = 0;
 static volatile sig_atomic_t sigusr2 = 0;
 static unsigned http_port = 8002;
+static struct sockaddr_in6 http_sockaddr;
+static string addr_info = "";
 static bool webapi_cors = false;
 static unsigned rescan_s = 300;
 static unsigned groom_s = 86400;
@@ -753,6 +758,16 @@ parse_opt (int key, char *arg,
   requires_koji_sigcache_mapping = true;
   break;
 #endif
+case ARGP_KEY_HTTP_ADDR:
+  if (inet_pton(AF_INET, arg, &(((sockaddr_in*)&http_sockaddr)->sin_addr)) 
== 1)
+  http_sockaddr.sin6_family = AF_INET;
+  else
+  if (inet_pton(AF_INET6, arg, &http_sockaddr.sin6_addr) == 1)
+  http_sockaddr.sin6_family = AF_INET6;
+  else
+  argp_failure(state, 1, EINVAL, "HTTP address");
+  addr_info = arg;
+  break;
   // case 'h': argp_state_help (state, stderr, 
ARGP_HELP_LONG|ARGP_HELP_EXIT_OK);
 default: return ARGP_ERR_UNKNOWN;
 }
@@ -5596,6 +5611,8 @@ main (int argc, char *argv[])
   fdcache_prefetch = 64; // guesstimate storage is this much less costly than 
re-decompression
 
   /* Parse and process arguments.  */
+  memset(&http_sockaddr, 0, sizeof(http_sockaddr));
+  http_sockaddr.sin6_family = AF_UNSPEC;
   int remaining;
   (void) argp_parse (&argp, argc, argv, ARGP_IN_ORDER, &remaining, NULL);
   if (remaining != argc)
@@ -5702,50 +5719,75 @@ main (int argc, char *argv[])
 #endif
| MHD_USE_DEBUG); /* report errors to stderr */
 
-  // Start httpd server threads.  Use a single dual-homed pool.
-  MHD_Daemon *d46 = MHD_start_daemon (mhd_flags, http_port,
- NULL, NULL, /* default accept policy */
- handler_cb, NULL, /* handler callback */
- MHD_OPTION_EXTERNAL_LOGGER,
- error_cb, NULL,
- MHD_OPTION_THREAD_POOL_SIZE,
- (int)connection_pool,
- MHD_OPTION_END);
-
-  MHD_Daemon *d4 = NULL;
-  if (d46 == NULL)
+  MHD_Daemon *dsa = NULL,
+*d4 = NULL,
+*d46 = NULL;
+
+  if (http_sockaddr.sin6_family != AF_UNSPEC)
 {
-  // Cannot use dual_stack, use ipv4 only
-  mhd_flags &= ~(MHD_USE_DUAL_STACK);
-  d4 = MHD_start_daemon (mhd_flags, http_port,
-NULL, NULL, /* default accept policy */
+  if (http_sockaddr.sin6_family == AF_INET)
+   ((sockaddr_in*)&http_sockaddr)->sin_port = htons(http_port);
+  if (http_sockaddr.sin6_family == AF_INET6)
+   http_sockaddr.sin6_port = htons(http_port);
+  // Start httpd server threads on socket addr:port.
+  dsa = MHD_start_daemon (mhd_flags & ~MHD_USE_DUAL_STACK, http_port,
+ NULL, NULL, /* default accept policy */
 handler_cb, NULL, /* handler callback */
 MHD_OPTION_EXTERNAL_LOGGER,
 error_cb, NULL,
-(connection_pool
- ? MHD_OPTION_THREAD_POOL_SIZE
- : MHD_OPTION_END),
-(connection_pool
- ? (int)connection_pool
- : MHD_OPTION_END),
+MHD_OPTION_SOCK_ADDR,
+(struct sockaddr *) &http_sockaddr,
+MHD_OPTION_THREAD_POOL_SIZE,
+(int)connection_pool,
 MHD_OPT