☺ Buildbot (Sourceware): elfutils - build successful (main)
A restored build has been detected on builder elfutils-fedora-ppc64le while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#/builders/55/builds/375 Build state: build successful Revision: 977c4dba220db572fe5ff43b6eb8b81673be0ef7 Worker: fedora-ppc64le Build Reason: (unknown) Blamelist: Mark Wielaard , Michael Pratt , Philippe Benard Steps: - 0: worker_preparation ( success ) - 1: set package name ( success ) - 2: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/2/logs/stdio - 3: autoreconf ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/3/logs/stdio - 4: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/4/logs/stdio - config.log: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/4/logs/config_log - 5: get version ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/5/logs/stdio - property changes: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/5/logs/property_changes - 6: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/6/logs/stdio - warnings (3): https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/6/logs/warnings__3_ - 7: make check ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/7/logs/stdio - test-suite.log: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/7/logs/test-suite_log - 8: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/8/logs/stdio - 9: build bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/9/logs/stdio - 10: fetch bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/10/logs/stdio - 11: unpack bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/11/logs/stdio - 12: pass .bunsen.source.* ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/12/logs/stdio - 13: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/13/logs/stdio - 14: clean up ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/14/logs/stdio - 15: make distclean ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/375/steps/15/logs/stdio
Re: [PATCH] libcpu: Remove false positive null ptr deref warning for GCC, -O3
Hi Phi, On Fri, Jan 10, 2025 at 8:26 AM Phi wrote: > > I try to send a patch via thunderbird, I don't know if the process is correct. > I tried from gmail but it was not good. > > The patch is trivial and I use it to learn the patch submission process, > along with the signed-off-by process Thanks for the patch, it fixes the warning for me. I merged your patch with a small change to the commit message. I moved the bugzilla reference and the changelog to just above the Signed-off-by. I also replaced "See bugzilla Bug#32527" with the sourceware URL of the bug. It's recommended that you send patches to this list using 'git send-email'. But in this case I was able to apply the patch you attached without issue. Aaron
Re: ☠ Buildbot (Sourceware): elfutils - failed test (failure) (main)
On Fri, Jan 10, 2025 at 3:50 PM wrote: > > A new failure has been detected on builder elfutils-fedora-ppc64le while > building elfutils. > > Full details are available at: > https://builder.sourceware.org/buildbot/#/builders/55/builds/374 > > Build state: failed test (failure) > Revision: c79c1d4d1d2995aefeb0119868b19c08d3184edb > Worker: fedora-ppc64le > Build Reason: (unknown) > Blamelist: Michael Pratt > > Steps: > > - 0: worker_preparation ( success ) > > - 1: set package name ( success ) > > - 2: git checkout ( success ) > Logs: > - stdio: > https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/2/logs/stdio > > - 3: autoreconf ( success ) > Logs: > - stdio: > https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/3/logs/stdio > > - 4: configure ( success ) > Logs: > - stdio: > https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/4/logs/stdio > - config.log: > https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/4/logs/config_log > > - 5: get version ( success ) > Logs: > - stdio: > https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/5/logs/stdio > - property changes: > https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/5/logs/property_changes > > - 6: make ( warnings ) > Logs: > - stdio: > https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/6/logs/stdio > - warnings (3): > https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/6/logs/warnings__3_ > > - 7: make check ( failure ) > Logs: > - stdio: > https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/7/logs/stdio > - test-suite.log: > https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/7/logs/test-suite_log This failure is due to the randomly failing tests/run-backtrace-native-core.sh and is unrelated to mcpratt's patches. Aaron
Re: [PATCH] Update minimum C compiler supported to C11 plus stdatomic.h
Hi Mark, On Thu, Nov 21, 2024 at 6:34 PM Mark Wielaard wrote: > > We were using a somewhat odd mix of gnu99 with a fallback atomics.h so > we could build with gcc 4.7. Lets requires a compiler that can do at > least C11 and has a stdatomic.h. So we can build against any C > standard >= C11 (including C17 and C23). That means GCC 4.9+. > GCC 4.9 was released in 2014. > > The lowest compiler version we check in the buildbots is currently > GCC 8.3.0 (Debian old old stable, released in 2018). > > Also update the minimum autoconf version to 2.69. We would really like > 2.70+ so we don't need the gnulib gnu11.m4. But 2.69 still seems in > use on various stable systems. autoconf 2.70 was released end of 2020, > autoconf 2.69 in 2012. > > * configure.ac (AC_PACKAGE_URL): Removed workaround for > autoconf < 2.64. > (AC_PREREQ): Update from 2.63 to 2.69. > (AC_PROG_CC): Test for ac_cv_prog_cc_c11. > (AC_CACHE_CHECK for stdatomic.h > * config/eu.am (AM_CFLAGS): Remove -std=gnu99. > * lib/Makefile.am (noinst_HEADERS): Remove atomics.h and > stdatomic-fbsd.h. > * lib/atomics.h: Removed. > * lib/stdatomic-fbsd.h: Removed. > * lib/dynamicsizehash_concurrent.h: Include stdatomic.h. > * libdw/libdw_alloc.c: Likewise. > * m4/.gitignore: Add !/std-gnu11.m4. > * m4/std-gnu11.m4: New file from gnulib to provide AC_PROG_CC > from autoconf 2.70. > > Signed-off-by: Mark Wielaard LGTM. Aaron
Re: [PATCH] config: Put the -D option as first argument to INSTALL_DATA
Hi Mark,
On Wed, Jan 8, 2025 at 6:45 AM Mark Wielaard wrote:
>
> INSTALL_DATA uses the install program to install files. The GNU
> coreutils implementation of install takes options anywhere. Other
> implementations of install might take options only before the source
> and destination arguments.
>
> * config/Makefile.am (all-local): Move -D option before
> file and directory arguments.
>
> Signed-off-by: Mark Wielaard
> ---
> config/Makefile.am | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/config/Makefile.am b/config/Makefile.am
> index 2dcbe94eaef1..11693ed47dad 100644
> --- a/config/Makefile.am
> +++ b/config/Makefile.am
> @@ -42,9 +42,9 @@ all-local:
> sed -i 's/{prefix}/prefix/g' profile.fish
>
> install-data-local:
> - $(INSTALL_DATA) profile.sh -D
> $(DESTDIR)$(sysconfdir)/profile.d/debuginfod.sh
> - $(INSTALL_DATA) profile.csh -D
> $(DESTDIR)$(sysconfdir)/profile.d/debuginfod.csh
> - $(INSTALL_DATA) profile.fish -D
> $(DESTDIR)$(datadir)/fish/vendor_conf.d/debuginfod.fish
> + $(INSTALL_DATA) -D profile.sh
> $(DESTDIR)$(sysconfdir)/profile.d/debuginfod.sh
> + $(INSTALL_DATA) -D profile.csh
> $(DESTDIR)$(sysconfdir)/profile.d/debuginfod.csh
> + $(INSTALL_DATA) -D profile.fish
> $(DESTDIR)$(datadir)/fish/vendor_conf.d/debuginfod.fish
> mkdir -p $(DESTDIR)$(sysconfdir)/debuginfod
> if [ -n "@DEBUGINFOD_URLS@" ]; then \
> echo "@DEBUGINFOD_URLS@" >
> $(DESTDIR)$(sysconfdir)/debuginfod/elfutils.urls; \
> --
> 2.47.1
>
LGTM.
Aaron
[PATCH] libcpu: Remove false positive null ptr deref warning for GCC, -O3
Hi All, I try to send a patch via thunderbird, I don't know if the process is correct. I tried from gmail but it was not good. The patch is trivial and I use it to learn the patch submission process, along with the signed-off-by process Cheers, Phi From 3ac65cf6eec36a9a22af378e89bc4d5b148d8713 Mon Sep 17 00:00:00 2001 From: Philippe Benard Date: Thu, 9 Jan 2025 14:59:00 +0100 Subject: [PATCH] libcpu: Remove false positive null ptr deref warning for GCC -O3 See bugzilla Bug#32527 * libcpu/Makefile.am i386_lex_CFLAGS += $(subst -O3,-Wno-null-dereference,$(findstring -O3,$(CFLAGS))) i386_lex_CFLAGS is a make variable to tweak the i386_lex.c.o specific compile flags. The are already some -W defined there, I'd like to add one to avoid seeing false warning during build with -O3 compile flag. GCC 14.2 (as well as 13.x) produce a false positive warning for the i386 lexer, a bug is filled already against GCC for that, CLANG is imune. Signed-off-by: Philippe Benard --- libcpu/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libcpu/Makefile.am b/libcpu/Makefile.am index 32835237..2e87021b 100644 --- a/libcpu/Makefile.am +++ b/libcpu/Makefile.am @@ -91,6 +91,8 @@ libeu = ../lib/libeu.a i386_lex_CFLAGS = -Wno-unused-label -Wno-unused-function -Wno-sign-compare \ -Wno-implicit-fallthrough +i386_lex_CFLAGS += $(subst -O3,-Wno-null-dereference,$(findstring -O3,$(CFLAGS))) + i386_parse.o: i386_parse.c i386.mnemonics i386_lex.o: i386_parse.h i386_gendis_LDADD = $(libeu) -lm $(obstack_LIBS) -- 2.43.0
[Bug libdw/32540] New: dwarf_errno() error codes are private
https://sourceware.org/bugzilla/show_bug.cgi?id=32540 Bug ID: 32540 Summary: dwarf_errno() error codes are private Product: elfutils Version: unspecified Status: UNCONFIRMED Severity: normal Priority: P2 Component: libdw Assignee: unassigned at sourceware dot org Reporter: michael.tremer at ipfire dot org CC: elfutils-devel at sourceware dot org Target Milestone: --- Hello, I am using libdw to extract sources from compiled binaries using dwarf_getsrcfiles(). This function as well as others may return errors which can be retrieved using dwarf_errno(). These error codes are however not part of the header files. Instead they are in libdwP.h: > https://sourceware.org/git/?p=elfutils.git;a=blob;f=libdw/libdwP.h;h=d6bab6063cca74de4c23d6c5a542d773e55bac5d;hb=HEAD#l100 Would it be possible to move them into libdw.h or are they intentionally kept there? I would be happy to provide a patch if this change would be considered acceptable. -- You are receiving this mail because: You are on the CC list for the bug.
Re: [PATCH 3/3] Consolidate list of custom phony targets
Hi Michael, On Sun, Nov 24, 2024 at 2:04 PM Michael Pratt wrote: > > Having a target defined as phony within a condition > while another target is always defined as phony > causes an automake warning: > > Makefile.am:67: warning: .PHONY was already defined in condition TRUE, > which includes condition GCOV ... > config/eu.am:141: ... '.PHONY' previously defined here > Makefile.am:21: 'config/eu.am' included from here > tests/Makefile.am:895: warning: .PHONY was already defined in condition > TRUE, which includes condition GCOV ... > config/eu.am:141: ... '.PHONY' previously defined here > tests/Makefile.am:19: 'config/eu.am' included from here > > Instead, list all the custom targets that are phony > in the common definitions in the eu.am file. > > Since it is all related to coverage at this moment, > the list can be grouped as it is instead of moved or split. > > * Makefile.am: remove .PHONY list in conditional > * config/eu.am: add coverage target to .PHONY list > * tests/Makefile.am: remove .PHONY list in conditional > > Signed-off-by: Michael Pratt > --- > Makefile.am | 1 - > config/eu.am | 3 ++- > tests/Makefile.am | 1 - > 3 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index e44bbe62..3a181d75 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -64,7 +64,6 @@ build_COVERAGE_DIRS = $(patsubst > %,$(builddir)/%,$(COVERAGE_DIRS)) > all_COVERAGE_DIRS = $(sort $(src_COVERAGE_DIRS) $(build_COVERAGE_DIRS)) > LCOV_DIRS_ARGS = $(patsubst %,--directory=%,$(all_COVERAGE_DIRS)) > > -.PHONY: coverage > coverage: $(COVERAGE_OUTPUT_INDEX_HTML) > @echo 'file://$(abs_builddir)/$(COVERAGE_OUTPUT_INDEX_HTML)' > > diff --git a/config/eu.am b/config/eu.am > index 475d5836..e4fcbd1a 100644 > --- a/config/eu.am > +++ b/config/eu.am > @@ -138,7 +138,8 @@ endif > COVERAGE_OUTPUT_DIRECTORY = coverage > COVERAGE_OUTPUT_FILE = $(PACKAGE_NAME).lcov > > -.PHONY: clean-coverage > +.PHONY: clean-coverage coverage > + > clean-local: clean-coverage > clean-coverage: > -rm -rf $(COVERAGE_OUTPUT_DIRECTORY) > diff --git a/tests/Makefile.am b/tests/Makefile.am > index 44cbb825..8f087798 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -892,7 +892,6 @@ CLEANFILES = $(BUILT_SOURCES) > > if GCOV > check: check-am coverage > -.PHONY: coverage > coverage: > -$(srcdir)/coverage.sh > endif > -- > 2.30.2 Thanks for the patches, I've merged this series. Aaron
☠ Buildbot (Sourceware): elfutils - failed test (failure) (main)
A new failure has been detected on builder elfutils-fedora-ppc64le while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#/builders/55/builds/374 Build state: failed test (failure) Revision: c79c1d4d1d2995aefeb0119868b19c08d3184edb Worker: fedora-ppc64le Build Reason: (unknown) Blamelist: Michael Pratt Steps: - 0: worker_preparation ( success ) - 1: set package name ( success ) - 2: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/2/logs/stdio - 3: autoreconf ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/3/logs/stdio - 4: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/4/logs/stdio - config.log: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/4/logs/config_log - 5: get version ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/5/logs/stdio - property changes: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/5/logs/property_changes - 6: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/6/logs/stdio - warnings (3): https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/6/logs/warnings__3_ - 7: make check ( failure ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/7/logs/stdio - test-suite.log: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/7/logs/test-suite_log - 8: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/8/logs/stdio - 9: build bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/9/logs/stdio - 10: fetch bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/10/logs/stdio - 11: unpack bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/11/logs/stdio - 12: pass .bunsen.source.* ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/12/logs/stdio - 13: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/13/logs/stdio - 14: clean up ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/14/logs/stdio - 15: make distclean ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/55/builds/374/steps/15/logs/stdio
