[PATCH] backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files
Using the NONE relocation doesn't do anything, but is harmless. This fixes several (self) tests on sparc that use elflint to check files are valid ELF. Signed-off-by: Mark Wielaard --- backends/ChangeLog | 4 backends/sparc_reloc.def | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/backends/ChangeLog b/backends/ChangeLog index f28ab89b..40ec7c0c 100644 --- a/backends/ChangeLog +++ b/backends/ChangeLog @@ -1,3 +1,7 @@ +2023-01-19 Mark Wielaard + + * sparc_reloc.def (NONE): Add EXEC and DYN. + 2022-12-21 Shahab Vahedi * Makefile.am (modules): Add arc. diff --git a/backends/sparc_reloc.def b/backends/sparc_reloc.def index 7cd5ce96..f0eeb5c6 100644 --- a/backends/sparc_reloc.def +++ b/backends/sparc_reloc.def @@ -28,7 +28,7 @@ /* NAME, REL|EXEC|DYN*/ -RELOC_TYPE (NONE, REL) +RELOC_TYPE (NONE, REL|EXEC|DYN) RELOC_TYPE (8, REL) RELOC_TYPE (16, REL) RELOC_TYPE (32, REL|DYN) -- 2.31.1
Re: [PATCH] backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files
> Using the NONE relocation doesn't do anything, but is harmless. > > This fixes several (self) tests on sparc that use elflint to > check files are valid ELF. FWIW looks good to me. > > Signed-off-by: Mark Wielaard > --- > backends/ChangeLog | 4 > backends/sparc_reloc.def | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/backends/ChangeLog b/backends/ChangeLog > index f28ab89b..40ec7c0c 100644 > --- a/backends/ChangeLog > +++ b/backends/ChangeLog > @@ -1,3 +1,7 @@ > +2023-01-19 Mark Wielaard > + > + * sparc_reloc.def (NONE): Add EXEC and DYN. > + > 2022-12-21 Shahab Vahedi > > * Makefile.am (modules): Add arc. > diff --git a/backends/sparc_reloc.def b/backends/sparc_reloc.def > index 7cd5ce96..f0eeb5c6 100644 > --- a/backends/sparc_reloc.def > +++ b/backends/sparc_reloc.def > @@ -28,7 +28,7 @@ > > /* NAME, REL|EXEC|DYN*/ > > -RELOC_TYPE (NONE, REL) > +RELOC_TYPE (NONE, REL|EXEC|DYN) > RELOC_TYPE (8, REL) > RELOC_TYPE (16, REL) > RELOC_TYPE (32, REL|DYN)
Re: [PATCH] backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files
Hi Jose, On Thu, Jan 19, 2023 at 11:17:13PM +0100, Jose E. Marchesi wrote: > > Using the NONE relocation doesn't do anything, but is harmless. > > > > This fixes several (self) tests on sparc that use elflint to > > check files are valid ELF. > > FWIW looks good to me. Thanks, pushed. Cheers, Mark
[COMMITTED] tests: run-debuginfod-query-retry.sh /bin/sh might not have a build-id
If /bin/sh wasn't build with build-id the test fails because
debuginfod-find will not be able to even try to fetch something.
Use libdebuginfod.so.1 instead as test file because we just
build that and configure makes sure we always produce a build-id.
Signed-off-by: Mark Wielaard
---
tests/ChangeLog | 5 +
tests/run-debuginfod-query-retry.sh | 5 +++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/ChangeLog b/tests/ChangeLog
index 8c841fa1..66807856 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,8 @@
+2023-01-19 Mark Wielaard
+
+ * run-debuginfod-query-retry.sh: Use libdebuginfod.so.1 instead
+ of /bin/sh as test file.
+
2022-12-21 Shahab Vahedi
* hello_arc_hs4.ko.bz2: New testfile.
diff --git a/tests/run-debuginfod-query-retry.sh
b/tests/run-debuginfod-query-retry.sh
index 0cfdba92..2f551ffb 100755
--- a/tests/run-debuginfod-query-retry.sh
+++ b/tests/run-debuginfod-query-retry.sh
@@ -25,8 +25,9 @@ unset VALGRIND_CMD
# set up tests for retrying failed queries.
retry_attempts=`(testrun env DEBUGINFOD_URLS=http://255.255.255.255/JUNKJUNK
DEBUGINFOD_RETRY_LIMIT=10 DEBUGINFOD_VERBOSE=1
DEBUGINFOD_CACHE_PATH=${PWD}/.client_cache \
-${abs_top_builddir}/debuginfod/debuginfod-find debuginfo /bin/sh ||
true) 2>&1 >/dev/null \
-| grep -c 'Retry failed query'`
+${abs_top_builddir}/debuginfod/debuginfod-find debuginfo \
+${abs_top_builddir}/debuginfod/libdebuginfod.so.1 || true) \
+2>&1 >/dev/null | grep -c 'Retry failed query'`
if [ $retry_attempts -ne 10 ]; then
echo "retry mechanism failed."
exit 1;
--
2.31.1
☺ Buildbot (Sourceware): elfutils - build successful (master)
A restored build has been detected on builder elfutils-gentoo-sparc while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/225/builds/4 Build state: build successful Revision: ba59ce28cbd62ee12128b89bc0601a38ceeb5aa8 Worker: gentoo-sparc Build Reason: (unknown) Blamelist: Aaron Merey , Aleksei Vetrov , Andreas Schwab , Andrew Paprocki , Arsen Arsenović , Daniel Thornburgh , Di Chen , Frank Ch. Eigler , Gavin Li , Hengqi Chen , Josef Cejka , Khem Raj , Mark Wielaard , Martin Liska , Michael Trapp , Milian Wolff , Noah Sanci , Sam James , Sergei Trofimovich via Elfutils-devel , Shahab Vahedi , Shahab Vahedi , Ulrich Drepper , Ulrich Drepper , Yonggang Luo , 河辺 岳人 Steps: - 0: worker_preparation ( success ) - 1: set package name ( success ) - 2: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/2/logs/stdio - 3: autoreconf ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/3/logs/stdio - 4: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/4/logs/stdio - 5: get version ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/5/logs/stdio - property changes: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/5/logs/property_changes - 6: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/6/logs/stdio - warnings (3): https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/6/logs/warnings__3_ - 7: make check ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/7/logs/stdio - test-suite.log: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/7/logs/test-suite_log - 8: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/8/logs/stdio - 9: build bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/9/logs/stdio - 10: fetch bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/10/logs/stdio - 11: unpack bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/11/logs/stdio - 12: pass .bunsen.source.gitname ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/12/logs/stdio - 13: pass .bunsen.source.gitdescribe ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/13/logs/stdio - 14: pass .bunsen.source.gitbranch ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/14/logs/stdio - 15: pass .bunsen.source.gitrepo ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/15/logs/stdio - 16: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/16/logs/stdio - 17: clean up ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/17/logs/stdio - 18: make distclean ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/225/builds/4/steps/18/logs/stdio
