Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec.' -> 'hello3.spec'

[Mark Wielaard]

Hi,

On Tue, Sep 20, 2022 at 04:43:01PM +0800, Yonggang Luo via Elfutils-devel wrote:
> These filenames are invalid on win32

This looks ok to me, but I don't really know why these files were
named this way in the first place.

The files themselves are not directly used, they are there to recreate
the hello3*rpm test files.

Frank, would you mind if these are just renamed to normal *.spec?

Thanks,

Mark

> Signed-off-by: Yonggang Luo 
> ---
>  tests/Makefile.am   | 2 +-
>  tests/debuginfod-rpms/{hello2.spec. => hello2.spec} | 0
>  tests/debuginfod-rpms/{hello3.spec. => hello3.spec} | 0
>  3 files changed, 1 insertion(+), 1 deletion(-)
>  rename tests/debuginfod-rpms/{hello2.spec. => hello2.spec} (100%)
>  rename tests/debuginfod-rpms/{hello3.spec. => hello3.spec} (100%)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 85514898..fc2235f4 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -563,7 +563,7 @@ EXTRA_DIST = run-arextract.sh run-arsymtest.sh run-ar.sh \
>debuginfod-rpms/fedora31/hello3-debugsource-1.0-2.x86_64.rpm \
>debuginfod-rpms/fedora31/hello3-two-1.0-2.x86_64.rpm \
>debuginfod-rpms/fedora31/hello3-two-debuginfo-1.0-2.x86_64.rpm \
> -  debuginfod-rpms/hello2.spec. \
> +  debuginfod-rpms/hello2.spec \
>debuginfod-rpms/rhel6/hello2-1.0-2.i686.rpm \
>debuginfod-rpms/rhel6/hello2-1.0-2.src.rpm \
>debuginfod-rpms/rhel6/hello2-debuginfo-1.0-2.i686.rpm \
> diff --git a/tests/debuginfod-rpms/hello2.spec. 
> b/tests/debuginfod-rpms/hello2.spec
> similarity index 100%
> rename from tests/debuginfod-rpms/hello2.spec.
> rename to tests/debuginfod-rpms/hello2.spec
> diff --git a/tests/debuginfod-rpms/hello3.spec. 
> b/tests/debuginfod-rpms/hello3.spec
> similarity index 100%
> rename from tests/debuginfod-rpms/hello3.spec.
> rename to tests/debuginfod-rpms/hello3.spec
> -- 
> 2.36.1.windows.1
> 

Re: [PATCH 2/7] move platform depended include into system.h

[Mark Wielaard]

On Tue, Sep 20, 2022 at 04:43:02PM +0800, Yonggang Luo via Elfutils-devel wrote:
> All of these files either #include  directly or #include "libelfP.h"
> And now "libelfP.h also #include , so the platform depended include
> can be moved to system.h safely

I like this in theory since it cleans up some of the includes.
But it doesn't work as is.

libebl/eblobjnotetypename.c only included system.h so now doesn't
compile anymore.  And libintl.h is removed from libelf/elf_error.c
which really is necessary.

Cheers,

Mark