Re: [PATCH] elfcompress: Add sanity checks to make sure to not override variable
Hi, On Tue, May 10, 2022 at 12:35:01PM +0200, Mark Wielaard wrote: > The process_file code is a little tricky. Add sanity checks to make > sure shstrtab_name, shstrtab_newname and symstrents are only set once. Pushed. Cheers, Mark
Re: [PATCHv2] debuginfod: Check result of curl_easy_getinfo in debuginfod_write_callback
Hi, On Mon, May 09, 2022 at 05:40:39PM +0200, Mark Wielaard wrote: > This was the only place in debuginfod-client.c where we didn't check > the result of curl_easy_getinfo. Just check it to make things consistent. Pushed. Cheers, Mark
Re: [PATCH] debuginfod: Check all curl_easy_setopt calls
Hi, On Mon, May 09, 2022 at 06:22:29PM +0200, Mark Wielaard wrote: > curl_easy_setup can fail for various reasons. Add a curl_easy_setopt_ck > macro to check all curl_easy_setopt calls and provides a human readable > error message in verbose mode. Pushed. Cheers, Mark
Re: [PATCH] libdw: Add sanity check to store_implicit_value
Hi, On Mon, May 09, 2022 at 06:48:58PM +0200, Mark Wielaard wrote: > Don't just skip the block length, but check it is equal to the > op->number that we are going to use as length. Pushed. Cheers, Mark
Re: [PATCH] strip: Add more NULL check
Hi, On Mon, May 09, 2022 at 10:24:35PM +0200, Mark Wielaard wrote: > When gelf_getshdr, gelf_getrela, gelf_getrel or gelf_getsymshndx > return NULL it is an internal error which we want to report instead of > crashing. Pushed. Cheers, Mark
☠ Buildbot (GNU Toolchain): elfutils - failed test (failure) (master)
A new failure has been detected on builder elfutils-debian-armhf while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/6/builds/25 Build state: failed test (failure) Revision: 4a13bd2cf82a401cbe5850fe9a8bd3fcb5b13bfb Worker: debian-armhf Build Reason: (unknown) Blamelist: Mark Wielaard Steps: - 0: worker_preparation ( success ) - 1: set package name ( success ) - 2: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/2/logs/stdio - 3: autoreconf ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/3/logs/stdio - 4: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/4/logs/stdio - 5: get version ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/5/logs/stdio - property changes: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/5/logs/property_changes - 6: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/6/logs/stdio - warnings (3): https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/6/logs/warnings__3_ - 7: make check ( failure ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/7/logs/stdio - test-suite.log: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/7/logs/test-suite_log - 8: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/8/logs/stdio - 9: fetch ['tests/*.trs', 'tests/*.log'] ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/9/logs/stdio - 10: fetch ['elfutils-*/_build/sub/tests/*.trs', 'elfut ( skipped ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/10/logs/stdio - 11: fetch ['config.log'] ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/11/logs/stdio - 12: fetch ['elfutils-*/_build/sub/config.log'] ( skipped ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/12/logs/stdio - 13: pass .bunsen.source.gitname ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/13/logs/stdio - 14: pass .bunsen.source.gitrepo ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/14/logs/stdio - 15: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/15/logs/stdio - 16: clean up ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/25/steps/16/logs/stdio
☺ Buildbot (GNU Toolchain): elfutils - build successful (master)
A restored build has been detected on builder elfutils-debian-armhf while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/6/builds/26 Build state: build successful Revision: ededa24fba3a78d97a0e5df2bbe47067906af1d2 Worker: debian-armhf Build Reason: (unknown) Blamelist: Mark Wielaard Steps: - 0: worker_preparation ( success ) - 1: set package name ( success ) - 2: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/2/logs/stdio - 3: autoreconf ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/3/logs/stdio - 4: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/4/logs/stdio - 5: get version ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/5/logs/stdio - property changes: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/5/logs/property_changes - 6: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/6/logs/stdio - warnings (3): https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/6/logs/warnings__3_ - 7: make check ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/7/logs/stdio - test-suite.log: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/7/logs/test-suite_log - 8: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/8/logs/stdio - 9: fetch ['tests/*.trs', 'tests/*.log'] ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/9/logs/stdio - 10: fetch ['elfutils-*/_build/sub/tests/*.trs', 'elfut ( skipped ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/10/logs/stdio - 11: fetch ['config.log'] ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/11/logs/stdio - 12: fetch ['elfutils-*/_build/sub/config.log'] ( skipped ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/12/logs/stdio - 13: pass .bunsen.source.gitname ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/13/logs/stdio - 14: pass .bunsen.source.gitrepo ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/14/logs/stdio - 15: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/15/logs/stdio - 16: clean up ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/26/steps/16/logs/stdio
☠ Buildbot (GNU Toolchain): elfutils - failed test (failure) (master)
A new failure has been detected on builder elfutils-debian-armhf while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/6/builds/27 Build state: failed test (failure) Revision: 0f2c8af3ba82ac54acc63ab7cb068578a6c0d96e Worker: debian-armhf Build Reason: (unknown) Blamelist: Mark Wielaard Steps: - 0: worker_preparation ( success ) - 1: set package name ( success ) - 2: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/2/logs/stdio - 3: autoreconf ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/3/logs/stdio - 4: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/4/logs/stdio - 5: get version ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/5/logs/stdio - property changes: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/5/logs/property_changes - 6: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/6/logs/stdio - warnings (3): https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/6/logs/warnings__3_ - 7: make check ( failure ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/7/logs/stdio - test-suite.log: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/7/logs/test-suite_log - 8: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/8/logs/stdio - 9: fetch ['tests/*.trs', 'tests/*.log'] ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/9/logs/stdio - 10: fetch ['elfutils-*/_build/sub/tests/*.trs', 'elfut ( skipped ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/10/logs/stdio - 11: fetch ['config.log'] ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/11/logs/stdio - 12: fetch ['elfutils-*/_build/sub/config.log'] ( skipped ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/12/logs/stdio - 13: pass .bunsen.source.gitname ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/13/logs/stdio - 14: pass .bunsen.source.gitrepo ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/14/logs/stdio - 15: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/15/logs/stdio - 16: clean up ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/16/logs/stdio
Re: ☠ Buildbot (GNU Toolchain): elfutils - failed test (failure) (master)
Hi,
On Sat, May 14, 2022 at 03:34:43PM +, builder--- via Elfutils-devel wrote:
> A new failure has been detected on builder elfutils-debian-armhf while
> building elfutils.
>
> Full details are available at:
> https://builder.sourceware.org/buildbot/#builders/6/builds/27
>
> Build state: failed test (failure)
> Revision: 0f2c8af3ba82ac54acc63ab7cb068578a6c0d96e
> Worker: debian-armhf
> Build Reason: (unknown)
> Blamelist: Mark Wielaard
>
> Steps:
> [...]
> - 7: make check ( failure )
> Logs:
> - stdio:
> https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/7/logs/stdio
> - test-suite.log:
> https://builder.sourceware.org/buildbot/#builders/6/builds/27/steps/7/logs/test-suite_log
This failed twice today:
FAIL: run-backtrace-native-core.sh
==
0xbeff4000 0xbeff5000 linux-vdso.so.1
0xb6fa9000 0xb6fd2974 ld-linux-armhf.so.3
0xb62a7000 0xb6321078 libm.so.6
0xb6322000 0xb642c6ec libstdc++.so.6
0xb642d000 0xb6442218 librt.so.1
0xb6443000 0xb64550c4 libdl.so.2
0xb6456000 0xb654f33c libc.so.6
0xb655 0xb6574270 libpthread.so.0
0xb6575000 0xb659d134 libgcc_s.so.1
0xb659e000 0xb6a4c0f4 libubsan.so.1
0xb6a4d000 0xb6fa8e30 libasan.so.5
0x4a0x4b27c0backtrace-child
TID 25528:
# 0 0xb655f526 __libc_do_syscall
# 1 0xb655e316 - 1 raise
# 2 0x4a1290 - 1sigusr2
# 3 0x4a1344 - 1stdarg
# 4 0x4a1378 - 1backtracegen
# 5 0x4a1382 - 1start
# 6 0xb6555bbe - 1 start_thread
# 7 0xb64f016c - 1
TID 25526:
# 0 0xb64ed8d2 syscall
# 1 0xb6a89adc - 1 __interceptor_pthread_create
/var/lib/buildbot/workers/wildebeest/elfutils-debian-armhf/build/tests/backtrace:
dwfl_thread_getframes: no matching address range
/var/lib/buildbot/workers/wildebeest/elfutils-debian-armhf/build/tests/backtrace:
dwfl_thread_getframes: No DWARF information found
backtrace: backtrace.c:81: callback_verify: Assertion `seen_main' failed.
./test-subr.sh: line 84: 25578 Aborted
LD_LIBRARY_PATH="${built_library_path}${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH"
$VALGRIND_CMD "$@"
/var/lib/buildbot/workers/wildebeest/elfutils-debian-armhf/build/tests/backtrace:
dwfl_thread_getframes: No DWARF information found
backtrace-child-core.25526: arm needs debuginfo installed for all libraries
rmdir: failed to remove 'test-25518': Directory not empty
FAIL run-backtrace-native-core.sh (exit status: 1)
And once last week. Sadly I don't know why. If this test keep being
flaky on armhf then we might have to disable it.
Since this seems to be compiled with ubsan and asan I installed the
libasan5-dbg and libasan5-dbg packages. Maybe that helps.
Cheers,
Mark
Re: [PATCH] debuginfod: Always request servname from getnameinfo for conninfo.
Hi, On Mon, May 09, 2022 at 11:10:44PM +0200, Mark Wielaard wrote: > When getting the connection info getnameinfo is called getting the > hostname and servname except when the sockaddr is a pure ipv6 > address. In that last case only hostname is requested. Since servname > is stack allocated and not initialized it might contain garbage which > is then put in the log. Just always request both hostname and servname > with NI_NUMERICHOST | NI_NUMERICSERV. Pushed. Cheers, Mark
Re: Optimize debuginfod-client cache lookup/cleanup a little
Hi, On Tue, May 10, 2022 at 12:57:20AM +0200, Mark Wielaard wrote: > debuginfod-client would try to create the cache config files twice, > once through debuginfod_init_cache, which was always called before the > debuginfod_clean_cache check. Which called debuginfod_config_cache > which also tried to create the config files when they didn't exist > yet. debuginfod_config_cache however had a small bug that meant it > would not provide a valid struct stat if the config file didn't exist > yet. The first patch fixes that: > > [PATCH 1/3] debuginfod: Make sure debuginfod_config_cache always returns > valid stat > > Then the second patch removes debuginfod_init_cache which saves two > stat calls (but introduces a new mkdir call). > > [PATCH 2/3] debuginfod: Remove debuginfod_init_cache > > Finally as soon as debuginfod_clean_cache commits to clean the cache > dir we immediately update the mtime of the interval config file so > other threads will not try to simultaniously also try to clean up the > cache dir. Because that is just duplicate work. > > [PATCH 3/3] debuginfod: update mtime of interval_path as early as possible Frank said off-list that he didn't see anything wrong with these patches. So I pushed thse 3 patches. 12 points! Mark
☺ Buildbot (GNU Toolchain): elfutils - build successful (master)
A restored build has been detected on builder elfutils-debian-armhf while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/6/builds/28 Build state: build successful Revision: 4b5c8d1380715123f1b832fca932722e8c6651d2 Worker: debian-armhf Build Reason: (unknown) Blamelist: Mark Wielaard Steps: - 0: worker_preparation ( success ) - 1: set package name ( success ) - 2: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/2/logs/stdio - 3: autoreconf ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/3/logs/stdio - 4: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/4/logs/stdio - 5: get version ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/5/logs/stdio - property changes: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/5/logs/property_changes - 6: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/6/logs/stdio - warnings (3): https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/6/logs/warnings__3_ - 7: make check ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/7/logs/stdio - test-suite.log: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/7/logs/test-suite_log - 8: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/8/logs/stdio - 9: fetch ['tests/*.trs', 'tests/*.log'] ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/9/logs/stdio - 10: fetch ['elfutils-*/_build/sub/tests/*.trs', 'elfut ( skipped ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/10/logs/stdio - 11: fetch ['config.log'] ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/11/logs/stdio - 12: fetch ['elfutils-*/_build/sub/config.log'] ( skipped ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/12/logs/stdio - 13: pass .bunsen.source.gitname ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/13/logs/stdio - 14: pass .bunsen.source.gitrepo ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/14/logs/stdio - 15: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/15/logs/stdio - 16: clean up ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/6/builds/28/steps/16/logs/stdio
