[Bug debuginfod/29117] debuginfod client leaking fd's for cache misses

2022-05-04 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=29117

Mark Wielaard  changed:

   What|Removed |Added

 CC||mark at klomp dot org

--- Comment #2 from Mark Wielaard  ---
Nice find.

BTW. Playing with valgrind --track-fds=yes you can find a couple of other file
descriptor leaks in debuginfod_init_cache, debuginfod_config_cache and
debuginfod-find itself.

Note that when using newer valgrind there is a bit of interference because
valgrind itself is using debuginfod-find (you can move it out of the way so
valgrind cannot find it).

These aren't as bad since they only happen on first initialization or just
before process termination.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/29117] debuginfod client leaking fd's for cache misses

2022-05-04 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=29117

--- Comment #3 from Mark Wielaard  ---
Created attachment 14090
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14090&action=edit
More fd leaks

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/29117] debuginfod client leaking fd's for cache misses

2022-05-04 Thread fche at redhat dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=29117

Frank Ch. Eigler  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #4 from Frank Ch. Eigler  ---
pushed via:
commit 59158656f3b0b99d8784ddc82c15778813000edc (HEAD -> master, origin/master,
origin/HEAD)
Author: Frank Ch. Eigler 
Date:   Wed May 4 10:26:42 2022 -0400

PR29117: fix fd leak in debuginfod client for cache-miss files

Correct a nasty fd leak and a few less nasty leaks in the debuginfod
client code.  The nasty one impacts long-lived apps such as debuginfod
servers.

Signed-off-by: Mark Wielaard  
Signed-off-by: Frank Ch. Eigler 

-- 
You are receiving this mail because:
You are on the CC list for the bug.

☠ Buildbot (GNU Toolchain): elfutils - failed test (failure) (master)

2022-05-04 Thread builder--- via Elfutils-devel
A new failure has been detected on builder elfutils-debian-armhf while building 
elfutils.

Full details are available at:
https://builder.sourceware.org/buildbot/#builders/6/builds/17

Build state: failed test (failure)
Revision: 59158656f3b0b99d8784ddc82c15778813000edc
Worker: debian-armhf
Build Reason: (unknown)
Blamelist: Frank Ch. Eigler 

Steps:

- 0: worker_preparation ( success )

- 1: set package name ( success )

- 2: git checkout ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/2/logs/stdio

- 3: autoreconf ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/3/logs/stdio

- 4: configure ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/4/logs/stdio

- 5: get version ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/5/logs/stdio
- property changes: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/5/logs/property_changes

- 6: make ( warnings )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/6/logs/stdio
- warnings (3): 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/6/logs/warnings__3_

- 7: make check ( failure )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/7/logs/stdio
- test-suite.log: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/7/logs/test-suite_log

- 8: prep ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/8/logs/stdio

- 9: fetch ['tests/*.trs', 'tests/*.log'] ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/9/logs/stdio

- 10: fetch ['elfutils-*/_build/sub/tests/*.trs', 'elfut ( skipped )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/10/logs/stdio

- 11: fetch ['config.log'] ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/11/logs/stdio

- 12: fetch ['elfutils-*/_build/sub/config.log'] ( skipped )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/12/logs/stdio

- 13: pass .bunsen.source.gitname ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/13/logs/stdio

- 14: pass .bunsen.source.gitrepo ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/14/logs/stdio

- 15: upload to bunsen ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/15/logs/stdio

- 16: clean up ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/16/logs/stdio



Re: ☠ Buildbot (GNU Toolchain): elfutils - failed test (failure) (master)

2022-05-04 Thread Mark Wielaard
Hi,

On Wed, May 04, 2022 at 03:34:44PM +, builder--- via Elfutils-devel wrote:
> A new failure has been detected on builder elfutils-debian-armhf while 
> building elfutils.
> 
> Full details are available at:
> https://builder.sourceware.org/buildbot/#builders/6/builds/17
> 
> Build state: failed test (failure)
> Revision: 59158656f3b0b99d8784ddc82c15778813000edc
> Worker: debian-armhf
> Build Reason: (unknown)
> Blamelist: Frank Ch. Eigler 

H This seems totally unrelated to that commit

> - 7: make check ( failure )
> Logs:
> - stdio: 
> https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/7/logs/stdio
> - test-suite.log: 
> https://builder.sourceware.org/buildbot/#builders/6/builds/17/steps/7/logs/test-suite_log

FAIL: run-backtrace-native-core.sh
==
0xbeb25000  0xbeb26000  linux-vdso.so.1
0xb6f7  0xb6f99974  ld-linux-armhf.so.3
0xb626e000  0xb62e8078  libm.so.6
0xb62e9000  0xb63f36ec  libstdc++.so.6
0xb63f4000  0xb6409218  librt.so.1
0xb640a000  0xb641c0c4  libdl.so.2
0xb641d000  0xb651633c  libc.so.6
0xb6517000  0xb653b270  libpthread.so.0
0xb653c000  0xb6564134  libgcc_s.so.1
0xb6565000  0xb6a130f4  libubsan.so.1
0xb6a14000  0xb6f6fe30  libasan.so.5
0x410x4227c0backtrace-child
TID 25080:
# 0 0xb6526526  __libc_do_syscall
# 1 0xb6525316 - 1  raise
# 2 0x411290 - 1sigusr2
# 3 0x411344 - 1stdarg
# 4 0x411378 - 1backtracegen
# 5 0x411382 - 1start
# 6 0xb651cbbe - 1  start_thread
# 7 0xb64b716c - 1  
TID 25076:
# 0 0xb64b48d2  syscall
# 1 0xb6a50adc - 1  __interceptor_pthread_create
/var/lib/buildbot/workers/wildebeest/elfutils-debian-armhf/build/tests/backtrace:
 dwfl_thread_getframes: no matching address range
/var/lib/buildbot/workers/wildebeest/elfutils-debian-armhf/build/tests/backtrace:
 dwfl_thread_getframes: No DWARF information found
backtrace: backtrace.c:81: callback_verify: Assertion `seen_main' failed.
./test-subr.sh: line 84: 25096 Aborted 
LD_LIBRARY_PATH="${built_library_path}${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH" 
$VALGRIND_CMD "$@"
/var/lib/buildbot/workers/wildebeest/elfutils-debian-armhf/build/tests/backtrace:
 dwfl_thread_getframes: No DWARF information found
backtrace-child-core.25076: arm needs debuginfo installed for all libraries
rmdir: failed to remove 'test-25065': Directory not empty
FAIL run-backtrace-native-core.sh (exit status: 1)

I wonder if this is caused by the asan or ubsan "interceptor". But if
so, why haven't we seen this before?

Cheers,

Mark