Re: ☺ Buildbot (GNU Toolchain): elfutils - build successful (master)
Hi, On Tue, 2022-05-03 at 00:25 +, builder--- via Elfutils-devel wrote: > A restored build has been detected on builder elfutils-fedora-x86_64 > while building elfutils. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/59/builds/14 > > Build state: build successful > Revision: 6d0c3b57429add5b6494259c1c06499e52cff4d5 > Worker: fedora-x86_64 > Build Reason: (unknown) > Blamelist: Mark Wielaard This is a little cheating. I removed the --enable-valgrind from make distcheck and this failed before because of some (valgrind I suspect) bug that caused a zstd using test to fail. Once we add --enable- valgrind back for this distro/arch (fedora 35 x86_64) the failure would come back. But for now we are all green! :) https://builder.sourceware.org/buildbot/#/builders?tags=elfutils Cheers, Mark
[COMMITTED] config: Move the 2>/dev/null inside the sh -c '' quotes for profile.csh.
csh/tcsh would warn about "Ambiguous output redirect" if not done inside the sh -c command. Fix-by: наб https://bugzilla.redhat.com/show_bug.cgi?id=2080957 Signed-off-by: Mark Wielaard --- config/ChangeLog | 4 config/profile.csh.in | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/config/ChangeLog b/config/ChangeLog index 51415258..cfb37b42 100644 --- a/config/ChangeLog +++ b/config/ChangeLog @@ -1,3 +1,7 @@ +2022-05-03 Mark Wielaard + + * profile.csh.in: Move the 2>/dev/null inside the sh -c '' quotes. + 2022-04-25 Mark Wielaard * elfutils.spec.in: Update for 0.187. diff --git a/config/profile.csh.in b/config/profile.csh.in index 012e243a..74c20c99 100644 --- a/config/profile.csh.in +++ b/config/profile.csh.in @@ -6,7 +6,7 @@ if (! $?DEBUGINFOD_URLS) then set prefix="@prefix@" -set DEBUGINFOD_URLS=`sh -c 'cat "$0"/*.urls; :' "@sysconfdir@/debuginfod" 2>/dev/null | tr '\n' ' '` +set DEBUGINFOD_URLS=`sh -c 'cat "$0"/*.urls 2>/dev/null; :' "@sysconfdir@/debuginfod" | tr '\n' ' '` if ( "$DEBUGINFOD_URLS" != "" ) then setenv DEBUGINFOD_URLS "$DEBUGINFOD_URLS" else -- 2.18.4
[Bug debuginfod/29117] New: debuginfod client leaking fd's for cache misses
https://sourceware.org/bugzilla/show_bug.cgi?id=29117 Bug ID: 29117 Summary: debuginfod client leaking fd's for cache misses Product: elfutils Version: unspecified Status: NEW Severity: normal Priority: P2 Component: debuginfod Assignee: unassigned at sourceware dot org Reporter: fche at redhat dot com CC: elfutils-devel at sourceware dot org Target Milestone: --- There appears to be an fd leak in the debuginfod client cache-miss code path. This can exhaust fd resources over time, which is bad for a long-lived client such as debuginfod itself. Trying to reproduce the trigger operation sequence. But the end result is the client holding onto file descriptors like debuginfo 10215 debuginfod 81r REG8,0 0 927302 /var/cache/debuginfod/.debuginfod_client_cache/3b47e7f26e7ed1dda18165fb20cb56769affdd19/debuginfo (deleted) ... while the files actually exist, despite the (deleted) tag; maybe they were recreated later: [root@elastic ~]# ls -ald /var/cache/debuginfod/.debuginfod_client_cache/3b47e7f26e7ed1dda18165fb20cb56769affdd19/debuginfo -rw-r--r-- 1 debuginfod debuginfod 0 May 3 23:40 /var/cache/debuginfod/.debuginfod_client_cache/3b47e7f26e7ed1dda18165fb20cb56769affdd19/debuginfo -- You are receiving this mail because: You are on the CC list for the bug.
[Bug debuginfod/29117] debuginfod client leaking fd's for cache misses
https://sourceware.org/bugzilla/show_bug.cgi?id=29117 --- Comment #1 from Frank Ch. Eigler --- Created attachment 14089 --> https://sourceware.org/bugzilla/attachment.cgi?id=14089&action=edit possible patch By inspection, in the unlink too-old negative-hit cache file case, we don't close the fd. -- You are receiving this mail because: You are on the CC list for the bug.
