[Bug tools/23787] eu-size: Bad handling of ar files inside are files
https://sourceware.org/bugzilla/show_bug.cgi?id=23787 PinoyTVTambayan changed: What|Removed |Added CC||pinoytvtambayanhd at gmail dot com --- Comment #32 from PinoyTVTambayan --- Watch Pinoy TV, Pinoy Tambayan, Pinoy Lambingan, Pinoy Teleserye Replay, Pinoy Tv shows, Pinoy Channel Replay. https://pinoytvtambayanhd.su/ -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libdw/26321] Possible bug in dwarf_getlocation
https://sourceware.org/bugzilla/show_bug.cgi?id=26321 Mark Wielaard changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #3 from Mark Wielaard --- (In reply to Giuliano Procida from comment #2) > If my reading of this is right, some of check_constant_offset's callers have > return values 0 success, -1 failure and others have count >= 0 success, -1 > failure. > > In which case, this makes sense. yes, the failure case indicates that there was some bad DWARF data. > I found the name of check_constant_offset particularly unhelpful. I added the documentation and renamed the function to is_constant_offset. Hopefully that name is slightly better. commit 0c8cac246d18c7f9d161e68c951168750c72e26c (HEAD -> master) Author: Mark Wielaard Date: Tue Aug 25 23:31:29 2020 +0200 libdw: Rename check_constant_offset to is_constant_offset. The check_constant_offset code in dwarf_getlocation.c code is not very intuitive, rename it to is_constant_offset and update the documentation. https://sourceware.org/bugzilla/show_bug.cgi?id=26321 Signed-off-by: Mark Wielaard -- You are receiving this mail because: You are on the CC list for the bug.
Re: [PATCH] libelf: Fixup SHF_COMPRESSED sh_addralign in elf_update if necessary.
On Wed, Aug 19, 2020 at 11:51:15PM +0200, Mark Wielaard wrote:
> In elf_getdata.c we have the following to compensate for possibly
> bad sh_addralign values of compressed sections:
>
> /* Compressed data has a header, but then compressed data.
> Make sure to set the alignment of the header explicitly,
> don't trust the file alignment for the section, it is
> often wrong. */
> if ((flags & SHF_COMPRESSED) != 0)
> {
> entsize = 1;
> align = __libelf_type_align (elf->class, ELF_T_CHDR);
> }
>
> Which makes sure the d_data alignment is correct for the Chdr struct
> at the start of the compressed section.
>
> But this means that if a user just reads such a compressed section
> without changing it, and then tries to write it out again using
> elf_update they get an error message about d_align and sh_addralign
> being out of sync.
>
> We already correct obviously incorrect sh_entsize fields.
> Do the same for the sh_addralign field of a SHF_COMPRESSED section.
Pushed to master and added to the Fedora rawhide package.
Cheers,
Mark
