[COMMITTED] config: Remove rpm, add dpkg as Requires for debuginfod package in spec.

2020-03-04 Thread Mark Wielaard
We no longer require rpm2cpio to unpack rpms.
We do now require dpkg-deb to unpack debs.

https://sourceware.org/bugzilla/show_bug.cgi?id=25583

Signed-off-by: Mark Wielaard 
---
 config/ChangeLog| 5 +
 config/elfutils.spec.in | 5 +++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/config/ChangeLog b/config/ChangeLog
index f420dba6..d1050e2c 100644
--- a/config/ChangeLog
+++ b/config/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-04  Mark Wielaard  
+
+   * elfutils.spec.in (package debuginfod): Remove Requires: rpm.
+   Add Requires: dpkg.
+
 2020-01-12  Frank Ch. Eigler  
 
* elfutils.spec.in: Typo fix for "Requires: debuginfod-client".
diff --git a/config/elfutils.spec.in b/config/elfutils.spec.in
index e992812a..ef7fe31f 100644
--- a/config/elfutils.spec.in
+++ b/config/elfutils.spec.in
@@ -157,8 +157,9 @@ Requires(post):   systemd
 Requires(preun):  systemd
 Requires(postun): systemd
 Requires(pre): shadow-utils
-# For /usr/bin/cpio2rpm
-Requires: rpm
+# To extract .deb files with dpkg-deb --fsys-tarfile
+# Can be Recommends if rpm supports that
+Requires: dpkg
 
 %description debuginfod-client
 The elfutils-debuginfod-client package contains shared libraries
-- 
2.18.2



Re: [PATCH] debuginfod-client: update cache_path when new default path exists

2020-03-04 Thread Mark Wielaard
Hi Aaron,

On Tue, 2020-03-03 at 14:32 -0500, Aaron Merey wrote:
> Subject: [PATCH] debuginfod-client: Update cache_path when the new default
>  path exists
> 
> Update cache_path with the path of the new default directory when this
> directory already exists. Previously cache_path was updated only when
> creating the new default directory and would otherwise be set to the
> old default path.

Nice catch and nice testcase. Looks good. Pushed to master.

Cheers,

Mark


Buildbot failure in Wildebeest Builder on whole buildset

2020-03-04 Thread buildbot
The Buildbot has detected a failed build on builder whole buildset while 
building elfutils.
Full details are available at:
https://builder.wildebeest.org/buildbot/#builders/10/builds/457

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-s390x

Build Reason: 
Blamelist: Mark Wielaard 

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot



Re: Buildbot failure in Wildebeest Builder on whole buildset

2020-03-04 Thread Mark Wielaard
On Wed, 2020-03-04 at 12:09 +, build...@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building elfutils.
> Full details are available at:
> https://builder.wildebeest.org/buildbot/#builders/10/builds/457
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: fedora-s390x

Hohum. Our buildbot worker vm got upgraded to a z15. Which has zlib
deflate instructions. Which valgrind doesn't support, causing:

gnu compressed kmods are unstripped
==27438== 
==27438== Process terminating with default action of signal 4 (SIGILL): dumping 
core
==27438==  Illegal opcode at address 0x4ACCC80
==27438==at 0x4ACCC80: ??? (in /usr/lib64/libz.so.1.2.11)
==27438==by 0x4ABF05B: deflateResetKeep (in /usr/lib64/libz.so.1.2.11)
==27438==by 0x4ABF0C5: deflateReset (in /usr/lib64/libz.so.1.2.11)
==27438==by 0x4AC21FF: deflateInit_ (in /usr/lib64/libz.so.1.2.11)
==27438==by 0x4856B35: __libelf_compress (elf_compress.c:113)
==27438==by 0x485770B: elf_compress_gnu (elf_compress_gnu.c:104)
==27438==by 0x100413D: compress_section (elfcompress.c:204)
==27438==by 0x100318B: process_file (elfcompress.c:778)
==27438==by 0x100318B: main (elfcompress.c:1359)

Luckily upstream valgrind already has a patch. But that will need to be
backported and then a new package should be installed on the s390x
buildbot worker.

Cheers,

Mark