Re: [PATCH] elflint: Check sh_info for symtab isn't too big.

2020-02-18 Thread Mark Wielaard
On Fri, 2020-02-07 at 18:20 +0100, Mark Wielaard wrote:
> The sh_info field of the symtab says how many symbols are in the
> section. Make sure at least that many symbols fit in the section.

I pushed this to master.


[Bug debuginfod/25502] debuginfod client should default to XDG cache

2020-02-18 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=25502

--- Comment #4 from Mark Wielaard  ---
(In reply to Tom Tromey from comment #3)
> (In reply to Mark Wielaard from comment #2)
> > What about the Default database file? Currently $HOME/.debuginfod.sqlite
> > 
> > Should that go under $XDG_DATA_HOME/debuginfod/ ?
> > And then probably not as hidden file?
> 
> If the file can be deleted and then re-created without difficulty,
> then it should go in the cache directory as well.

It could be, if the database is gone then it can be recreated from scratch. But
it might take a lot of work depending on how many packages/dirs you want to
index.

On the other hand if the database is important it might be explicitly be given
on the command line.

Any other opinions on where the default .debuginfod.sqlite should go (and how
it should be named)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/25511] unknown program header entry type 0x6474e553

2020-02-18 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=25511

--- Comment #2 from Mark Wielaard  ---
I requested some more background information on this:
https://sourceware.org/ml/gnu-gabi/2020-q1/msg0.html

But since it is now emitted in production binaries lets handle it as is for
now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/25511] unknown program header entry type 0x6474e553

2020-02-18 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=25511

Mark Wielaard  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Mark Wielaard  ---
commit c4600ae002c8a8738035ec5f80e818171811c9d4
Author: Mark Wielaard 
Date:   Sat Feb 8 21:40:27 2020 +0100

readelf, elflint: Handle PT_GNU_PROPERTY.

binutils 2.32 ld emits a new PT_GNU_PROPERTY segment that overlaps
with the PT_NOTE segment covering the .note.gnu.property section data.

https://sourceware.org/bugzilla/show_bug.cgi?id=25511

Signed-off-by: Mark Wielaard 

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/25502] debuginfod client should default to XDG cache

2020-02-18 Thread amerey at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25502

Aaron Merey  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #5 from Aaron Merey  ---
(In reply to Mark Wielaard from comment #4)
> (In reply to Tom Tromey from comment #3)
> > (In reply to Mark Wielaard from comment #2)
> > If the file can be deleted and then re-created without difficulty,
> > then it should go in the cache directory as well.
> 
> It could be, if the database is gone then it can be recreated from scratch.
> But it might take a lot of work depending on how many packages/dirs you want
> to index.
> 
> On the other hand if the database is important it might be explicitly be
> given on the command line.
> 
> Any other opinions on where the default .debuginfod.sqlite should go (and
> how it should be named)?

According to the XDG spec, XDG_CACHE_HOME is meant for "non-essential data".
I'm not 100% sure what constitutes essential data here but if a server is able
to rebuild its database after a wipe and continue functioning as it previously
did, then I suppose the database isn't essential in this sense (even if it
might take a while to rebuild).

I think it's fair to default to XDG_CACHE_HOME since if the database is
particularly important to a user they'll probably just specify its location
like Mark said.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/25502] debuginfod client should default to XDG cache

2020-02-18 Thread tromey at sourceware dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=25502

--- Comment #6 from Tom Tromey  ---
> I think it's fair to default to XDG_CACHE_HOME since if the database is
> particularly important to a user they'll probably just specify its location
> like Mark said.

FWIW I only really care about the behavior on the client side.
I think for a server making a database, it would be reasonable to just
require the user specify some location; or default to ".".  IMO there's
no real reason to use some XDG directory in this situation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.