[Bug tools/25077] unstrip bad handling of sh_entsize of the symver section

2019-10-22 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=25077

--- Comment #3 from Mark Wielaard  ---
(In reply to leftcopy.chx from comment #2)
> Since this crashes occurs when calling `elf_update`, which resides in
> libelf, I suppose this is a libelf library issue.
> 
> I'd suggest adding some documents to warn that it is the developers' duty to
> ensure that the claimed symver size matches with the actual one, or better
> resolves the size purely inside libelf code?

libelf would do the right thing if you use don't use elf_flagelf (outelf,
ELF_C_SET, ELF_F_LAYOUT) as eu-unstrip does. If you set ELF_F_LAYOUT you
promise to set up all ELF data fields correctly yourself and libelf just trusts
you when writing out the file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tools/25077] unstrip bad handling of sh_entsize of the symver section

2019-10-22 Thread leftcopy.chx at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25077

--- Comment #4 from leftcopy.chx at gmail dot com ---
OK, that makes sense!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Re: [PATCH 1/3] Add some supporting framework for C11-style atomics.

2019-10-22 Thread Mark Wielaard
On Thu, 2019-08-29 at 15:16 +0200, Mark Wielaard wrote:
> From: Jonathon Anderson 
> 
> Uses the stdatomic.h provided by FreeBSD when GCC doesn't (ie. GCC <
> 4.9)
> 
> Signed-off-by: Jonathon Anderson 
> Signed-off-by: Srđan Milaković 
>
> diff --git a/lib/ChangeLog b/lib/ChangeLog
> index 7381860c..3799c3aa 100644
> --- a/lib/ChangeLog
> +++ b/lib/ChangeLog
> @@ -1,3 +1,9 @@
> +2019-08-25  Jonathon Anderson  
> +
> + * stdatomic-fbsd.h: New file, taken from FreeBSD.
> + * atomics.h: New file.
> + * Makefile.am (noinst_HEADERS): Added *.h above.

Thanks. I cherry-picked and rebased this and pushed to master.

Sorry this took so long, even though the change itself was fairly small
and self-contained. I wanted to play with it in context of the other
patches first, which weren't that simple.

Cheers,

Mark