[Bug libelf/23903] Uses linux specifc mremap
https://sourceware.org/bugzilla/show_bug.cgi?id=23903 Jean Michault changed: What|Removed |Added CC||bibi584762 at gmail dot com --- Comment #8 from Jean Michault --- Created attachment 11932 --> https://sourceware.org/bugzilla/attachment.cgi?id=11932&action=edit patch to allow compile on systems without mremap I suggest the patch attached. This makes it possible to compile elfutils on nonlinux systems, but generates an error if one tries to use features that need mremap. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libelf/23903] Uses linux specifc mremap
https://sourceware.org/bugzilla/show_bug.cgi?id=23903 --- Comment #9 from Mark Wielaard --- (In reply to Jean Michault from comment #8) > Created attachment 11932 [details] > patch to allow compile on systems without mremap > > I suggest the patch attached. > This makes it possible to compile elfutils on nonlinux systems, but > generates an error if one tries to use features that need mremap. Thanks. Some questions about the proposed patch: - What defines HAVE_MMAP? I don't believe we currently have a configure check for it, should we? - The guard checks for HAVE_MMAP, but the code calls mremap. Should we have a HAVE_MREMAP guard and configure check instead? - On which systems did you test and what were the make check results? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libelf/23903] Uses linux specifc mremap
https://sourceware.org/bugzilla/show_bug.cgi?id=23903 --- Comment #10 from Jean Michault --- (In reply to Mark Wielaard from comment #9) > (In reply to Jean Michault from comment #8) > > Created attachment 11932 [details] > > patch to allow compile on systems without mremap > > > > I suggest the patch attached. > > This makes it possible to compile elfutils on nonlinux systems, but > > generates an error if one tries to use features that need mremap. > > Thanks. Some questions about the proposed patch: > - What defines HAVE_MMAP? > I don't believe we currently have a configure check for it, should we? > - The guard checks for HAVE_MMAP, but the code calls mremap. > Should we have a HAVE_MREMAP guard and configure check instead? > - On which systems did you test and what were the make check results? You're right, i was a little too fast, you can have mmap without having mremap, so you have to test mremap. And we need to add the mremap test in configure.ac. I will work again. -- You are receiving this mail because: You are on the CC list for the bug.
