[Bug binutils/23919] bfd doesn't handle ELF compressed data alignment
https://sourceware.org/bugzilla/show_bug.cgi?id=23919 --- Comment #2 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Nick Clifton : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4207142d6a5d2359170c5f9a140fc1a2351fbda9 commit 4207142d6a5d2359170c5f9a140fc1a2351fbda9 Author: Mark Wielaard Date: Tue Nov 27 11:59:10 2018 + Handle ELF compressed header alignment correctly by setting up the section alignment correctly for the Elf32_Chdr or Elf64_Chdr type and respect the ch_addralign field when decompressing the section data. PR binutils/23919 binutils* readelf.c (dump_sections_as_strings): Remove bogus addralign check. (dump_sections_as_bytes): Likewise. (load_specific_debug_sections): Likewise. * testsuite/binutils-all/dw2-3.rS: Adjust alignment. * testsuite/binutils-all/dw2-3.rt: Likewise. bfd * bfd.c (bfd_update_compression_header): Explicitly set alignment. (bfd_check_compression_header): Add uncompressed_alignment_power argument. Check ch_addralign is a power of 2. * bfd-in2.h: Regenerated. * compress.c (bfd_compress_section_contents): Get and set orig_uncompressed_alignment_pow if section is decompressed. (bfd_is_section_compressed_with_header): Add and get uncompressed_align_pow_p argument. (bfd_is_section_compressed): Add uncompressed_align_power argument to bfd_is_section_compressed_with_header call. (bfd_init_section_decompress_status): Get and set uncompressed_alignment_power. * elf.c (_bfd_elf_make_section_from_shdr): Add uncompressed_align_power argument to bfd_is_section_compressed_with_header call. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/23919] bfd doesn't handle ELF compressed data alignment
https://sourceware.org/bugzilla/show_bug.cgi?id=23919 Nick Clifton changed: What|Removed |Added Status|NEW |RESOLVED CC||nickc at redhat dot com Resolution|--- |FIXED --- Comment #3 from Nick Clifton --- Hi Mark, Thanks very much for the bug report, and especially for a patch to fix it! I have applied the patch, so I hope that this problem is now resolved. One very minor point - in the future, would you mind providing the ChangeLog entries as plain text, rather than a context diff ? It did not matter this time, but often the diff will not apply because the changelog has changed by the time that the patch is applied. Cheers Nick -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/23919] bfd doesn't handle ELF compressed data alignment
https://sourceware.org/bugzilla/show_bug.cgi?id=23919 --- Comment #4 from Mark Wielaard --- (In reply to Nick Clifton from comment #3) > Thanks very much for the bug report, and especially for a patch to fix it! > I have applied the patch, so I hope that this problem is now resolved. Thanks! > One very minor point - in the future, would you mind providing the > ChangeLog entries as plain text, rather than a context diff ? It > did not matter this time, but often the diff will not apply because > the changelog has changed by the time that the patch is applied. OK, I will in the future. Do you have some script that helps you handle separate ChangeLog entries? Note that gnulib contains some helpers for merging ChangeLog entries that I have used somewhat successfully with mercurial and git. They work the other way around though, you explicitly do add the ChangeLog entries in the commit/ChangeLog file, but when a merge action takes place they handle the entry specially. https://gnu.wildebeest.org/blog/mjw/2012/03/16/automagically-merging-changelog-files-with-mercurial-or-git/ -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/23919] bfd doesn't handle ELF compressed data alignment
https://sourceware.org/bugzilla/show_bug.cgi?id=23919 H.J. Lu changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #5 from H.J. Lu --- On Linux/x86-64, I got /export/build/gnu/binutils/build-x86_64-linux/binutils/objcopy -O elf32-x86-64 --compress-debug-sections=zlib-gabi tmpdir/dw2-3.o tmpdir/debug_str.copy.o Executing on host: /export/build/gnu/binutils/build-x86_64-linux/binutils/objcopy -O elf32-x86-64 --compress-debug-sections=zlib-gabi tmpdir/dw2-3.o tmpdir/debug_str.copy.o (timeout = 300) spawn -ignore SIGHUP /export/build/gnu/binutils/build-x86_64-linux/binutils/objcopy -O elf32-x86-64 --compress-debug-sections=zlib-gabi tmpdir/dw2-3.o tmpdir/debug_str.copy.o^M /export/build/gnu/binutils/build-x86_64-linux/binutils/objcopy: tmpdir/debug_str.copy.o: error: alignment power 32767 of section `.zdebug_line' is too big^M /export/build/gnu/binutils/build-x86_64-linux/binutils/objcopy:tmpdir/debug_str.copy.o[.text]: file in wrong format^M /export/build/gnu/binutils/build-x86_64-linux/binutils/objcopy: tmpdir/debug_str.copy.o: error: alignment power 32767 of section `.zdebug_line' is too big /export/build/gnu/binutils/build-x86_64-linux/binutils/objcopy:tmpdir/debug_str.copy.o[.text]: file in wrong format FAIL: objcopy (Convert x86-64 object with zlib-gnu to x32 (2)) -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/23919] bfd doesn't handle ELF compressed data alignment
https://sourceware.org/bugzilla/show_bug.cgi?id=23919 --- Comment #6 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by H.J. Lu : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=131a5a648d314cd15811158150573cb40eb3abd0 commit 131a5a648d314cd15811158150573cb40eb3abd0 Author: H.J. Lu Date: Tue Nov 27 06:02:36 2018 -0800 Initialize *uncompressed_align_pow_p to 0 Initialize *uncompressed_align_pow_p to 0 since *uncompressed_align_pow_p is passed to bfd_is_section_compressed_with_header as uninitialized, PR binutils/23919 * compress.c (bfd_is_section_compressed_with_header): Initialize *uncompressed_align_pow_p to 0. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/23919] bfd doesn't handle ELF compressed data alignment
https://sourceware.org/bugzilla/show_bug.cgi?id=23919 H.J. Lu changed: What|Removed |Added Status|REOPENED|RESOLVED Version|unspecified |2.32 (HEAD) Resolution|--- |FIXED Target Milestone|--- |2.32 --- Comment #7 from H.J. Lu --- Fixed for 2.32. -- You are receiving this mail because: You are on the CC list for the bug.
