Re: elfutils 0.175 released
On Mon, Nov 19, 2018 at 07:53:07AM +0100, Mark Wielaard wrote: > On Sun, Nov 18, 2018 at 11:46:29PM +0100, Kurt Roeckx wrote: > > On Fri, Nov 16, 2018 at 02:00:46PM +0100, Mark Wielaard wrote: > > > ELFUTILS 0.175 - http://elfutils.org/ > > > > > > A new release of elfutils is available at: > > > ftp://sourceware.org/pub/elfutils/0.175/ > > > or https://sourceware.org/elfutils/ftp/0.175/ > > > > Trying to build this on Debian, I get 8 failures, but they all > > seem to be white space differences. I've attached the > > test-suite.log file. > > That looks like you somehow are missing: > > commit 704f5fc477efaf120980449e677deb563da8491f > Author: Mark Wielaard > Date: Wed Nov 29 15:43:26 2017 +0100 > > readelf: Adjust print_ops formatting. > > Use only 2 spaces for index (there are never 1, the most seen in the > wild is 64). Adjust re-indenting after GNU_entry_value. > > Signed-off-by: Mark Wielaard > > But that is a commit from elfutils-0.171. > Maybe you have a local patch that conflicts with it? I somehow ended up with something that reverts it, no idea why. After removing that everything seems to work. Kurt
[PATCH] Add -Wtrampolines to CFLAGS.
elfutils uses nested functions a lot. This is fine unless one takes the address of such a nested function. When taking the address of a nested function a trampoline is generated that on some systems require the stack to be executable. That is bad. We never want to generate such trampolines. Add -Wtrampolines to CLAGS to make sure we don't. Signed-off-by: Mark Wielaard --- config/ChangeLog | 4 config/eu.am | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/config/ChangeLog b/config/ChangeLog index f281eb2..40d6f85 100644 --- a/config/ChangeLog +++ b/config/ChangeLog @@ -1,3 +1,7 @@ +2018-11-19 Mark Wielaard + + * eu.am (AM_CFLAGS): Add -Wtrampolines. + 2018-07-04 Mark Wielaard * upload-release.sh: New file. diff --git a/config/eu.am b/config/eu.am index c2cc349..82acda3 100644 --- a/config/eu.am +++ b/config/eu.am @@ -70,7 +70,7 @@ IMPLICIT_FALLTHROUGH_WARNING= endif AM_CFLAGS = -std=gnu99 -Wall -Wshadow -Wformat=2 \ - -Wold-style-definition -Wstrict-prototypes \ + -Wold-style-definition -Wstrict-prototypes -Wtrampolines \ $(LOGICAL_OP_WARNING) $(DUPLICATED_COND_WARNING) \ $(NULL_DEREFERENCE_WARNING) $(IMPLICIT_FALLTHROUGH_WARNING) \ $(if $($(*F)_no_Werror),,-Werror) \ -- 1.8.3.1
Re: elfutils 0.175 released
On Fri, Nov 16, 2018 at 02:00:46PM +0100, Mark Wielaard wrote: > ELFUTILS 0.175 - http://elfutils.org/ > > A new release of elfutils is available at: > ftp://sourceware.org/pub/elfutils/0.175/ > or https://sourceware.org/elfutils/ftp/0.175/ I'm gettings errors on riscv64: https://buildd.debian.org/status/fetch.php?pkg=elfutils&arch=riscv64&ver=0.175-1&stamp=1542669684&raw=0 Kurt
