Re: [PATCH 1/2] Remove previous test files before running the next round
On Mon, Jul 16, 2018 at 12:01:21PM +0200, Ulf Hermann wrote: > strip explicitly creates the new files. This will not work on windows if > the files already exist. > > Also, if strip fails to create the files for any reason, we would check > the previous run's files and succeed. However, the test should fail > then. This makes sense and does uncover a bug as your second patch shows. I want to fix that first and only then commit this fix. That way we don't have the testsuite failing between commits. Thanks, Mark
Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv
On Mon, Jul 16, 2018 at 12:02:17PM +0200, Ulf Hermann wrote: > strip does not produce debug files for riscv binaries. If this is a bug > it needs to be fixed in strip, but for now, we disable the tests. The issue is that hello_riscv64.ko doesn't contain any debug sections. So strip doesn't produce a separate debug file. Andreas, could you provide an updated hello_riscv64.ko that is compiled with -g and does contain debuginfo? Thanks, Mark
