[Bug libelf/22083] run-strip-strmerge.sh test fail on i686
https://sourceware.org/bugzilla/show_bug.cgi?id=22083 --- Comment #5 from Mark Wielaard --- (In reply to Laurent Carlier from comment #4) > (In reply to Mark Wielaard from comment #3) > > Thanks. Replicated with that object file. But not yet understood. > > Filtering -fno-plt from CFLAGS fixes the issue Thanks. That is interesting. Would you mind also attaching the elfstrmerge.o file binary produced without -fno-plt? That would make it easier to see exactly what change in the binary causes the breakage. -- You are receiving this mail because: You are on the CC list for the bug.
Re: elfutils build and testing
Hi Phi, On Mon, 2017-09-18 at 14:24 +0200, Phi Debian wrote: > I just git cloned the elfutils.git > > How to I build it, to my surprise there is no configure script > (assuming the clone is not damaged) > > My secondary question is assuming I can build what is the process to > run the test suite? To my own surprise this isn't documented at all. I added the attached to the README. Hope that helps. Thanks, MarkFrom 04ecad6acd13e7120b171307aa57325b2ec08715 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Tue, 19 Sep 2017 16:05:49 +0200 Subject: [PATCH] README: Add basic build instructions. Signed-off-by: Mark Wielaard --- ChangeLog | 4 README| 9 + 2 files changed, 13 insertions(+) diff --git a/ChangeLog b/ChangeLog index 86b19b5..c0034ba 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2017-09-19 Mark Wielaard + + * README: Add basic build instructions. + 2017-05-03 Ulf Hermann * configure.ac: Test if symbol versioning is supported. diff --git a/README b/README index 9e55d75..0e15bae 100644 --- a/README +++ b/README @@ -5,11 +5,20 @@ The project home is http://elfutils.org/ Releases are published at ftp://sourceware.org/pub/elfutils/ Which can also be found at https://sourceware.org/elfutils/ftp/ +To build a release do: ./configure && make && make check +Please check the configure summary to make sure all recommended +features are enabled. There should be no failures after make check. + Please reports bugs at https://sourceware.org/bugzilla/ The current elfutils source code can be checked out with git clone git://sourceware.org/git/elfutils.git +To build a git checkout do: + autoreconf -i -f && \ + ./configure --enable-maintainer-mode && \ + make && make check + The developer mailinglist to send patches to is elfutils-devel@sourceware.org. https://sourceware.org/ml/elfutils-devel/ -- 1.8.3.1
Re: Compile elfutils with Clang
Hi Dmitry, On Sat, 2017-09-09 at 13:52 +0300, Dmitry Golovin wrote: > I've been trying to compile elfutils with clang for a while now and > I'm wondering maybe someone else is also working on it? > I found some useful patches written by Chih-Hung Hsieh, but they seem > to be written over 2 years ago and not maintained. > Is there a fork or a branch of elfutils that can be compiled with > clang? The problem with clang is that it claims to implement -std=gnu99 but doesn't really. We now have a configure check to make sure the features used in the code base are actually supported by the compiler. So as soon as clang gets the needed features it should just work. Various people have worked on supporting clang as compiler, but it is a lot of work and nobody succeeded doing it without making the code much harder to maintain. But in general elfutils patches to clean up the code and support alternative compilers (or linkers, libc, kernels, etc.) are accepted and integrated as long as they improve the code base and don't make it hard to maintain. But the first target of elfutils is a normal GNU/Linux system. You might want to look at the mailinglist archives to find various attempts. Including a discussion of replacing nested functions with blocks. Which wasn't accepted because nobody seemed to believe it actually improved the code. Cheers, Mark
Re: [PATCH 1/2] Initialize type_offset of fake_cu
On Wed, 2017-09-06 at 12:38 +0200, Ulf Hermann wrote: > On 05/09/2017 06:28 PM, Ulf Hermann wrote: > > Signed-off-by: Ulf Hermann > > --- > > libdw/ChangeLog | 4 > > libdw/dwarf_getmacros.c | 1 + > > 2 files changed, 5 insertions(+) > > [...] > > It seems we missed this one, but it fixes a bug. Can we apply it? > PATCH 2/2 is not actually related. I assume you mean this patch: > diff --git a/libdw/dwarf_getmacros.c b/libdw/dwarf_getmacros.c > index eb50508..9e2a4a1 100644 > --- a/libdw/dwarf_getmacros.c > +++ b/libdw/dwarf_getmacros.c > @@ -361,6 +361,7 @@ read_macros (Dwarf *dbg, int sec_index, > .offset_size = table->is_64bit ? 8 : 4, > .startp = (void *) startp + offset, > .endp = (void *) endp, > + .type_offset = 0, > }; > > Dwarf_Attribute *attributes; That really shouldn't be necessary. In a named struct field initializer omitted elements are initialized to zero. Are you sure it fixes a real bug? In that case it might be a compiler bug instead (which we would want to work around, but then lets make sure to report it and add a comment). Cheers, Mark
