Re: Newforms: colon after label

2007-03-29 Thread bromer

On Mar 29, 1:38 pm, "Jonas Maurus" <[EMAIL PROTECTED]> wrote:
> Also, there simply are languages where this punctuation doesn't make
> sense. Adding it automatically then telling international users that
> they have to write a lot more code, because english developers wanted
> to save one character is bad, I think. Imho, adding even more magic to
> make it go away, makes even less sense.
>
> Not to mention that there are a lot of layout choices that would make
> this colon superfluous.
>
> What's wrong with
>   name = forms.CharField(label='Your name:')?
>
> I'd definitely go for removing this altogether before it's to late.

I think there are lots of situations where you need to normalize the
labels with some string. Why not just make it an optional parameter to
the Form class with a default value.. maybe ":"?

Rune


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---



Re: Newforms: colon after label

2007-03-29 Thread Rune Bromer

Jonas Maurus wrote:
>> I think he was suggesting in the form, not each field:

I did :)

> I see that this would allow Django to be backwards-compatible by
> introducing this new parameter, so I could go for that because I think
> backwards-compatibility is very important. I still disagree with the
> concept anyway because I think that:
> 
>   * it's a newbie-trap ("where does this colon come from it's neither
> in the template nor in my string???"and
>   * it doesn't really save any significant amount of time or space (12
> characters saved on a form with 12 fields) and
>   * it splits your label string between two classes so it's a concern
> for l10n and
>   * it's not very friendly to languages that don't use english/western
> punctuation
> 
> So I guess it comes down between backwards-compatibility and "doing
> the right thing as currently defined by Jonas Maurus". I think that
> it's clear that requiring to write a full template for all form-fields
> just to remove the colon would be really bad, at least. Btw, how does
> the Django-community usually decide such a thing? by a vote like in
> Apache projects? or do we wait for one of the core developers to show
> up? :-)

I would agree that the punctuation should not be there at all, as it's 
easy to add it to the label yourself.

If - on the other hand - we want the parameter on the form I would be 
happy to write a patch.. should be quickly done..

Rune


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---