Proposal to merge django-csp into contrib

2015-12-05 Thread Thomas Grainger
Now that the django admin supports the Content-Security-Policy header I 
think merging django-csp into contrib would be a good fix for 
https://code.djangoproject.com/ticket/15727 

It might also be an idea to wait for Mozilla to also respond to the 
proposal of this merger.

See my PR here: https://github.com/django/django/pull/5776

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/807ded1c-8d1e-45e1-a705-ac316ca63a20%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Proposal to merge django-csp into contrib

2015-12-06 Thread Thomas Grainger
Yeah this makes a lot more sense in SecurityMiddleware

On Sunday, 6 December 2015 10:01:54 UTC, Florian Apolloner wrote:
>
>
>
> On Sunday, December 6, 2015 at 10:13:46 AM UTC+1, Aymeric Augustin wrote:
>>
>> I understand that the “just merge django-csp” approach minimizes effort. 
>> However the result doesn’t feel well integrated with Django. I left a few 
>> comments that all boil down to “this isn’t how we would have done if we’d 
>> started from a clean slate” and quickly gave up when I noticed that trend.
>>
>
> Ditto, I'd like to see this in core and as part of SecurityMiddleware.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/34db20b7-7fa9-41d7-8787-70ca32ff98f8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Proposal to merge django-csp into contrib

2017-02-16 Thread Thomas Grainger
I'd like to see this happen! Don't worry about taking over from me!

On 17 Feb 2017 00:37, "Robert Roskam"  wrote:

> OK, I'll probably hold off for a little bit just in case someone else
> wants it. But I'll probably have some time soon to work on it.
>
> Robert Roskam
>
> On Wednesday, February 15, 2017 at 9:13:45 PM UTC-5, Tim Graham wrote:
>>
>> Yes, if a ticket goes weeks or months without activity, it's unlikely
>> someone is working on it, so it's fine to reassign.
>>
>> On Wednesday, February 15, 2017 at 9:11:01 PM UTC-5, Robert Roskam wrote:
>>>
>>> Hey All,
>>>
>>> So it's over a year later, and even though there is consensus, this
>>> ticket (https://code.djangoproject.com/ticket/15727) appears to have
>>> had no progress.
>>>
>>> Would it be OK if someone else were to pick up this ticket and move it
>>> forward?
>>>
>>> Robert Roskam
>>>
>>> On Sunday, December 6, 2015 at 11:22:20 AM UTC-5, Thomas Grainger wrote:
>>>>
>>>> Yeah this makes a lot more sense in SecurityMiddleware
>>>>
>>>> On Sunday, 6 December 2015 10:01:54 UTC, Florian Apolloner wrote:
>>>>>
>>>>>
>>>>>
>>>>> On Sunday, December 6, 2015 at 10:13:46 AM UTC+1, Aymeric Augustin
>>>>> wrote:
>>>>>>
>>>>>> I understand that the “just merge django-csp” approach minimizes
>>>>>> effort. However the result doesn’t feel well integrated with Django. I 
>>>>>> left
>>>>>> a few comments that all boil down to “this isn’t how we would have done 
>>>>>> if
>>>>>> we’d started from a clean slate” and quickly gave up when I noticed that
>>>>>> trend.
>>>>>>
>>>>>
>>>>> Ditto, I'd like to see this in core and as part of SecurityMiddleware.
>>>>>
>>>> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/django-developers/OITfIvTOp0A/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/django-developers/60788491-d220-44b6-b692-
> ea4a49e67268%40googlegroups.com
> <https://groups.google.com/d/msgid/django-developers/60788491-d220-44b6-b692-ea4a49e67268%40googlegroups.com?utm_medium=email&utm_source=footer>
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CABnLcR4b7E8rwD8m6yDG8sscMFN8dWtGO8AoN2L%3DzcO_snHH7A%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.