#7611 contrib.auth PasswordResetTest requires specific templates for tests to pass
Re: http://code.djangoproject.com/ticket/7611 The current situation is that if you create a new Django project and run the unit tests, the contrib.auth baisc tests fail due to missing templates. These templates are provided by the admin app, which is not installed by default. Russell brought up some points which made me think about this more. My initial implementation was to force the inclusion of the admin app if it wasn't already installed, but I agree with Russell's initial comment that it isn't testing for the presence of the admin app. I believe that we should not run these tests if we cannot find the templates for the same reason we don't run Docutils tests if docutils is not installed. Though the error reported that the template is not found is "correct", I don't believe it is a correct test failure because that is not the goal of the test case. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: #7611 contrib.auth PasswordResetTest requires specific templates for tests to pass
I attached a new patch to the ticket in the original post. The hard- coded URL felt like it went against your reasoning for testing the auth application in your own project, so hopefully this approach gives us the best of both worlds. Without a proper way to skip test cases yet, I decided to follow what other tests did and pass the test in the case where the test is actually skipped. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: #7611 contrib.auth PasswordResetTest requires specific templates for tests to pass
> However, if the user is _not_ using the views (e.g., they're using the
> auth.User model, but providing their own login views), there is an
> argument to be made for skipping the tests.
Is it safe to say that if we try to
reverse('django.contrib.auth.views.password_reset'), we should not run
the tests? This would negate the use of urls that was introduced in
#7521. The patch you submitted for loading test templates in #7611
seems to complement the use of urls from #7521 in TestCase. I feel it
should be both or none. In the latter case, we should simply skip the
test case if django.contrib.auth.views.password_reset is not used.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---
Re: Let's schedule a Django sprint
I have a friend who can join in during the evening if it's held at Mountain View, though I am surprised there aren't more Django hackers in the Silicon Valley. On Sep 7, 9:51 am, "Adrian Holovaty" <[EMAIL PROTECTED]> wrote: > On 9/7/07, David Cramer <[EMAIL PROTECTED]> wrote: > > > Only 3 of us from SF? Come on now! > > > It's for sure that it'll be good at Google's campus? > > Google Chicago is for sure, but I'm not sure yet about Mountain View. > > Silicon Valley is *so* overrated. The real action is in Chicago. :) > > Adrian > > -- > Adrian Holovaty > holovaty.com | djangoproject.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
