Re: Tests introduced in patch for #17327 causing errors

2012-03-07 Thread Brian Riley
Thanks for catching this. I worked on that patch.

The problem is that those two test cases shouldn't be in the auth tests but 
rather somewhere in top-level tests folder (with the other multi DB tests). I'm 
not sure exactly where they belong though. If a core dev wants to chime in and 
suggest a location, I'd be happy to move them and submit the patch.

Brian

On Mar 7, 2012, at 7:11 AM, Calvin Cheng  wrote:

> 
> Thanks. I stumbled upon the same problem.
> 
> 
> On Wednesday, March 7, 2012 4:40:56 PM UTC+8, Ryan Kaskel wrote:
> Hi all.
> 
> I've pulled in the latest changes and it seems like ticket #17327 [1] 
> introduces a few new tests that are raising errors when I run contrib.auth 
> tests via my project:
> 
> - 
> auth.MultiDBChangepasswordManagementCommandTestCase.test_that_changepassword_command_with_database_option_uses_given_db
> - 
> auth.MultiDBCreatesuperuserTestCase.test_createsuperuser_command_with_database_option
> 
> They raise: ConnectionDoesNotExist: The connection other doesn't exist.
> 
> The issue is that the tests assume there there is a database called "other," 
> which my test settings didn't have. If I add a database "other" in my test 
> settings, the tests pass.
> 
> I've played around with override_settings but I'm not sure if that would work 
> here. What I've tried so far doesn't.
> 
> Any tips?
> 
> Thanks,
> Ryan Kaskel
> 
> [1] https://code.djangoproject.com/ticket/17327
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Django developers" group.
> To view this discussion on the web visit 
> https://groups.google.com/d/msg/django-developers/-/JXXZeiJ5SQgJ.
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to 
> django-developers+unsubscr...@googlegroups.com.
> For more options, visit this group at 
> http://groups.google.com/group/django-developers?hl=en.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.



Re: Tests introduced in patch for #17327 causing errors

2012-03-07 Thread Brian Riley
I added a new patch to move these two failing tests to regressiontests--where 
they get run with the correct settings and pass. 

https://code.djangoproject.com/ticket/17327#comment:8

If this isn't the proper place for management command tests like this, I'll 
move them to wherever is more appropriate.

Brian 


On Wednesday, March 7, 2012 at 8:11 AM, Brian Riley wrote:

> Thanks for catching this. I worked on that patch.
> 
> The problem is that those two test cases shouldn't be in the auth tests but 
> rather somewhere in top-level tests folder (with the other multi DB tests). 
> I'm not sure exactly where they belong though. If a core dev wants to chime 
> in and suggest a location, I'd be happy to move them and submit the patch.
> 
> Brian
> 
> On Mar 7, 2012, at 7:11 AM, Calvin Cheng  (mailto:linchuan.ch...@gmail.com)> wrote:
> 
> > 
> > Thanks. I stumbled upon the same problem.
> > 
> > 
> > On Wednesday, March 7, 2012 4:40:56 PM UTC+8, Ryan Kaskel wrote:
> > > Hi all.
> > > 
> > > I've pulled in the latest changes and it seems like ticket #17327 [1] 
> > > introduces a few new tests that are raising errors when I run 
> > > contrib.auth tests via my project:
> > > 
> > > - 
> > > auth.MultiDBChangepasswordManagementCommandTestCase.test_that_changepassword_command_with_database_option_uses_given_db
> > > - 
> > > auth.MultiDBCreatesuperuserTestCase.test_createsuperuser_command_with_database_option
> > > 
> > > They raise: ConnectionDoesNotExist: The connection other doesn't exist.
> > > 
> > > The issue is that the tests assume there there is a database called 
> > > "other," which my test settings didn't have. If I add a database "other" 
> > > in my test settings, the tests pass.
> > > 
> > > I've played around with override_settings but I'm not sure if that would 
> > > work here. What I've tried so far doesn't.
> > > 
> > > Any tips?
> > > 
> > > Thanks,
> > > Ryan Kaskel
> > > 
> > > [1] https://code.djangoproject.com/ticket/17327
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups 
> > "Django developers" group.
> > To view this discussion on the web visit 
> > https://groups.google.com/d/msg/django-developers/-/JXXZeiJ5SQgJ.
> > To post to this group, send email to django-developers@googlegroups.com 
> > (mailto:django-developers@googlegroups.com).
> > To unsubscribe from this group, send email to 
> > django-developers+unsubscr...@googlegroups.com 
> > (mailto:django-developers+unsubscr...@googlegroups.com).
> > For more options, visit this group at 
> > http://groups.google.com/group/django-developers?hl=en.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.