Re: Deprecate CICharField, CIEmailField, CITextField

['Johannes Maron' via Django developers (Contributions to Django itself)]

Hi there,

I am sorry that I missed this in the alpha. But to the best of my 
knowledge, CITEXT and non-deterministic collations are not the same. They 
don't support the same operations and their string comparison operations 
are similar, yet not identical.
Furthermore, PostgreSQL doesn't discourage the use of CITEXT, but hints 
towards a native alternative. That's maybe more than just a subtle 
difference.

99% of all use-cases might be email, but even email LIKE-queries would be 
affected (good for +-searches).

Unless we want to drop support for the CITEXT extension, collations might 
not be a sufficient replacement.

I'd caution to revert the deprecation and keep support unless we make an 
informed decision to drop CITEXT for a 3rd party integration.

Best
Joe!




On Monday, August 8, 2022 at 11:49:25 AM UTC+2 Mariusz Felisiak wrote:

> As far as I'm aware you can use:
>
>  CreateCollation("case_insensitive", "und-u-ks-level2", 
> provider="icu", deterministic=False)
>
> to create a case insensitive collation on PostgreSQL. 
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/20278136-dbbe-4bc1-9f86-3b6f671c83d9n%40googlegroups.com.

Re: Deprecate CICharField, CIEmailField, CITextField

[Mariusz Felisiak]

Hi

> Unless we want to drop support for the CITEXT extension, ...

What do you mean by that? As far as I'm now, we don't do anything special 
to support CITEXT extension 🤔.

> I'd caution to revert the deprecation and keep support ...

I'm obviously biased as the author of this proposition and patch, however, 
IMO, small differences between using CI fields and collations don't justify 
maintaining 3 additional fields that were mostly untested. Also, they are 
deprecated in a LTS so folks still have *3* more years to update their 
code. In the worst case someone can create 3rd party package with them.

Unless something is fundamentally broken I'm against reverting.

Best,
Mariusz

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/5c11b704-68c4-490d-84bf-90c734cc02d1n%40googlegroups.com.