Re: Revisiting multiline template tags in Django Templates (again)

2022-09-28 Thread Thibaud Colas 
Just wanted to follow up that I got to discuss this in person with Carlton 
Gibson at the DjangoCon Europe sprints in Porto, who provisionally offered 
to act as a shepherd for this proposed DEP. This is on the condition that I 
find an implementation team as well.

On Saturday, 24 September 2022 at 08:37:52 UTC+1 Thibaud Colas wrote:

> 👋 Hi django-developers, I would like to revisit a very old feature 
> request: ticket #8652 Multiline tags and tag escape tags 
> , proposed DEP Multiline 
> Template Tags , and maling list 
> thread Revisiting multiline tags 
> 
> .
>
> There have been a lot of cases made against and for multiline template 
> tags across many threads. I’m raising this on the mailing list not 
> necessarily to revisit those arguments but to ask:
>
>1. Is a DEP indeed the best way forward for this at this point in 
>time? If so I will volunteer to author it (co-authors welcome!).
>2. The last DEP got blocked due to the lack of an implementation team 
>and shepherd. If we made a new (proposed) DEP – is anyone here interested 
>in helping in either positions?
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/ddc74d02-63df-479a-968c-2ee44b696bd2n%40googlegroups.com.

Re: Revisiting multiline template tags in Django Templates (again)

2022-09-28 Thread Carlton Gibson 
Hey Thibaud.

Thanks for following up! Yes — happy to sheppard.

(My other comment was to make sure the Rationale was sufficiently
clear/compelling, but I know you're on that 😉)
C.

On Wed, 28 Sept 2022 at 12:24, Thibaud Colas  wrote:

> Just wanted to follow up that I got to discuss this in person with Carlton
> Gibson at the DjangoCon Europe sprints in Porto, who provisionally offered
> to act as a shepherd for this proposed DEP. This is on the condition that I
> find an implementation team as well.
>
> On Saturday, 24 September 2022 at 08:37:52 UTC+1 Thibaud Colas wrote:
>
>> 👋 Hi django-developers, I would like to revisit a very old feature
>> request: ticket #8652 Multiline tags and tag escape tags
>> , proposed DEP Multiline
>> Template Tags , and maling list
>> thread Revisiting multiline tags
>> 
>> .
>>
>> There have been a lot of cases made against and for multiline template
>> tags across many threads. I’m raising this on the mailing list not
>> necessarily to revisit those arguments but to ask:
>>
>>1. Is a DEP indeed the best way forward for this at this point in
>>time? If so I will volunteer to author it (co-authors welcome!).
>>2. The last DEP got blocked due to the lack of an implementation team
>>and shepherd. If we made a new (proposed) DEP – is anyone here interested
>>in helping in either positions?
>>
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/ddc74d02-63df-479a-968c-2ee44b696bd2n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAJwKpySuOV37RcngoV2TopXsayMOw_WRACgy-_WoHVTwebDjPw%40mail.gmail.com.

Re: Proposal: Make it so when getting an image's dimensions, EXIF orientation is considered

2022-09-28 Thread David Sanders 
Hi Adam,

Sorry to clarify I was referring to `ImageFile` which has 2 `@property`
attributes `width` and `height` [1].  My suggestion was that you could add
2 additional `@property` attributes that work with EXIF rotation 🙂  (or
something along these lines…)

[1]
https://github.com/django/django/blob/0dd29209091280ccf34e07c9468746c396b7778e/django/core/files/images.py#L18-L24

Regards,
David


On Wed, 28 Sep 2022 at 07:13, 'Adam Johnson' via Django developers
(Contributions to Django itself)  wrote:

> To have extra properties, we'd need to add extra database fields. It would
> be somewhat wasteful to add them to all ImageFields when few users will
> care about the difference.
>
> On Mon, Sep 26, 2022 at 10:28 AM David Sanders <
> shang.xiao.sand...@gmail.com> wrote:
>
>> Actually might as well throw out one idea, feel free to discard:
>>
>> Keep width and height as-is and add 2 additional properties for jpg:
>> `photo_width` and `photo_height` (or named something more suitable)
>>
>> This way it stays inline with other image viewing/editing software which
>> still reports the width and height as is read from the image with the
>> rotation as separate meta-data. (Eg I did a cursory look with Gimp &
>> Preview on mac)
>>
>> On Mon, 26 Sept 2022 at 19:20, David Sanders <
>> shang.xiao.sand...@gmail.com> wrote:
>>
>>> Coincidence I was also just reading up image-orientation… I didn't
>>> realise that it's the default behaviour now to orient.
>>>
>>> I guess it's a question of whether/how to be backwards compatible?
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to django-developers+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/django-developers/CADyZw-5mR87oKsDVnyLFwuftxY3As0%3Dz9JXydbSu2-Lvni-F7g%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/CAMyDDM1Lwt0sGLtfb3yY-H_341TiJN-Vd1%2BaFNV6aHvwkZQNkg%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CADyZw-582Q%2BwZ4ouTsjX%2Bq%3DD4xvGb0VsUkTMYRSSZSR_hux2iQ%40mail.gmail.com.

Re: Revisiting multiline template tags in Django Templates (again)

2022-09-28 Thread Alex Morega 
Hi Thibaud,

I don't have many contributions to Django, but FWIW, I'm happy to help with 
development. 

On Wednesday, September 28, 2022 at 1:42:11 PM UTC+3 carlton...@gmail.com 
wrote:

> Hey Thibaud. 
>
> Thanks for following up! Yes — happy to sheppard. 
>
> (My other comment was to make sure the Rationale was sufficiently 
> clear/compelling, but I know you're on that 😉)
> C.
>
> On Wed, 28 Sept 2022 at 12:24, Thibaud Colas  wrote:
>
>> Just wanted to follow up that I got to discuss this in person with 
>> Carlton Gibson at the DjangoCon Europe sprints in Porto, who provisionally 
>> offered to act as a shepherd for this proposed DEP. This is on the 
>> condition that I find an implementation team as well.
>>
>> On Saturday, 24 September 2022 at 08:37:52 UTC+1 Thibaud Colas wrote:
>>
>>> 👋 Hi django-developers, I would like to revisit a very old feature 
>>> request: ticket #8652 Multiline tags and tag escape tags 
>>> , proposed DEP Multiline 
>>> Template Tags , and maling list 
>>> thread Revisiting multiline tags 
>>> 
>>> .
>>>
>>> There have been a lot of cases made against and for multiline template 
>>> tags across many threads. I’m raising this on the mailing list not 
>>> necessarily to revisit those arguments but to ask:
>>>
>>>1. Is a DEP indeed the best way forward for this at this point in 
>>>time? If so I will volunteer to author it (co-authors welcome!).
>>>2. The last DEP got blocked due to the lack of an implementation 
>>>team and shepherd. If we made a new (proposed) DEP – is anyone here 
>>>interested in helping in either positions?
>>>
>>>
>>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to django-develop...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/django-developers/ddc74d02-63df-479a-968c-2ee44b696bd2n%40googlegroups.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/af3c7629-4f7c-42b7-bb98-a0a67ef9af07n%40googlegroups.com.

Re: Revisiting multiline template tags in Django Templates (again)

2022-09-28 Thread 'Adam Johnson' via Django developers (Contributions to Django itself) 
Big +1. IMO tags should work like HTML tags, which can be spread across
multiple lines, as often done with multiple attributes. Also, Jinja does it.

If you're going to write a DEP, I'd say don't make it too long. The feature
is clear enough.

The old PR  is also short, as
it affects only the lexer. It should rebase fairly well as the lexer won't
have changed much. I would plan to test it with as many templates as
possible, to ensure that the tokenization is the same before/after.

Happy to review... I'm planning on copying the lexer into django-upgrade so
it can upgrade template files, so I would like to have some familiarity
with it.

On Wed, Sep 28, 2022 at 1:40 PM Alex Morega  wrote:

> Hi Thibaud,
>
> I don't have many contributions to Django, but FWIW, I'm happy to help
> with development.
>
> On Wednesday, September 28, 2022 at 1:42:11 PM UTC+3 carlton...@gmail.com
> wrote:
>
>> Hey Thibaud.
>>
>> Thanks for following up! Yes — happy to sheppard.
>>
>> (My other comment was to make sure the Rationale was sufficiently
>> clear/compelling, but I know you're on that 😉)
>> C.
>>
>> On Wed, 28 Sept 2022 at 12:24, Thibaud Colas  wrote:
>>
>>> Just wanted to follow up that I got to discuss this in person with
>>> Carlton Gibson at the DjangoCon Europe sprints in Porto, who provisionally
>>> offered to act as a shepherd for this proposed DEP. This is on the
>>> condition that I find an implementation team as well.
>>>
>>> On Saturday, 24 September 2022 at 08:37:52 UTC+1 Thibaud Colas wrote:
>>>
 👋 Hi django-developers, I would like to revisit a very old feature
 request: ticket #8652 Multiline tags and tag escape tags
 , proposed DEP Multiline
 Template Tags , and maling list
 thread Revisiting multiline tags
 
 .

 There have been a lot of cases made against and for multiline template
 tags across many threads. I’m raising this on the mailing list not
 necessarily to revisit those arguments but to ask:

1. Is a DEP indeed the best way forward for this at this point in
time? If so I will volunteer to author it (co-authors welcome!).
2. The last DEP got blocked due to the lack of an implementation
team and shepherd. If we made a new (proposed) DEP – is anyone here
interested in helping in either positions?


 --
>>> You received this message because you are subscribed to the Google
>>> Groups "Django developers (Contributions to Django itself)" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to django-develop...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/django-developers/ddc74d02-63df-479a-968c-2ee44b696bd2n%40googlegroups.com
>>> 
>>> .
>>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/af3c7629-4f7c-42b7-bb98-a0a67ef9af07n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM1vF4rh7e2dTV3jp2tYH%3DVFz%3DuwSFqeSoHKjnPASMVdaQ%40mail.gmail.com.