Re: Quick Filter in the Admin Sidebar

[Tom Carrick]

Hi Maxim,

I think the best thing you can do is add a ticket on trac -
https://code.djangoproject.com/ and make a PR on GitHub if it's accepted. I
think it's hard - at least for me - to test something from a gist. Then you
will get some reviews and more feedback.

Cheers,
Tom

On Fri, 4 Dec 2020 at 13:01, Maxim Milovanov  wrote:

> Hey guys,
>
> I've updated my prototype. What's changed:
> -- moved the JS and CSS to nav_sidebar.js and nav_sidebar.css respectively
> -- slight changes in styling
> -- added ESC key support
>
> I've updated my gist
> https://gist.github.com/MilovanovM/84ffbbec02391c1ba1771a3a6aee5797
> My changes are:
> nav_sidebar.html: line 4
> nav_sidebar.css: line 121 and below
> nav_sidebar.js: line 40 and below
>
> Here is the commit in my repo
> https://github.com/MilovanovM/django/commit/837701e79c468f72cbce1921b42c130801927e1c
> I've attached a git patch file as well.
>
> Thanks,
> Maxim
>
> пятница, 4 декабря 2020 г. в 12:00:35 UTC+3, Adam Johnson:
>
>> I'm not sure that the nav_sidebar.html is the best place for the JS
>>> snippet. Probably, it should be placed in the main JS. When DOM is ready it
>>> can be initialized there.
>>
>>
>> Indeed, we can't use inline JS in the admin since that doesn't work with
>> a strict CSP.
>>
>> On Fri, 4 Dec 2020 at 08:42, Maxim Milovanov  wrote:
>>
>>> Hey guys,
>>>
>>> I'm not sure that the nav_sidebar.html is the best place for the JS
>>> snippet. Probably, it should be placed in the main JS. When DOM is ready it
>>> can be initialized there.
>>>
>>> About UX. Agree the the "Clear" feature would be useful. It can be an
>>> "x" icon, or a shortkey (ESC?), or both.
>>>
>>> I'll provide a working sample later.
>>>
>>> Thanks,
>>> Maxim
>>>
>>> среда, 2 декабря 2020 г. в 20:46:30 UTC+3, Collin Anderson:
>>>
 I think this would be really helpful. Looking at the code in the gist,
 that looks about right. It's not too complicated and the basic
 toLowerCase()/indexOf() method of search should hopefully be enough (it's
 what I would do if I were implementing this!). I'd suggest adding some sort
 of clear or x button for canceling/removing the filter, but otherwise I
 think this should be ok UX wise. We can always improve it later.

 On Thursday, November 19, 2020 at 9:38:25 AM UTC-5 t...@carrick.eu
 wrote:

> I haven't looked at the gist, but I think in principle it's a good
> idea. ctrl+f isn't ideal.
>
> I think we need to be careful that the UX is good, if we go with this.
>
> Tom
>
> On Thu, 19 Nov 2020 at 15:16, Maxim Milovanov 
> wrote:
>
>> Yeah, that's why I came up with that idea. There are two projects, 44
>> models on one, 57 models on another. It's very hard to navigate
>>
>> четверг, 19 ноября 2020 г. в 16:50:37 UTC+3, yasie...@gmail.com:
>>
>>> I found this feature very helpful. I'm maintaining two sites with
>>> more than 20 models registered in the admin and some time is annoying 
>>> when
>>> I try to find the one I'm looking for
>>>
>>> El miércoles, 18 de noviembre de 2020 a la(s) 15:13:02 UTC-5, Maxim
>>> Milovanov escribió:
>>>
 Hey guys,

 I've posted a ticket  with
 a proposal to add a quick filtering feature to the sidebar.
 To see it in action just replace the content of nav_sidebar.html by 
 this
 gist
 

 Does it worth adding to the admin features? Hope for any feedback.

 Thanks,
 Maxim

>>> --
>> You received this message because you are subscribed to the Google
>> Groups "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it,
>> send an email to django-develop...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/django-developers/8376528d-a2df-43b0-829e-43a49bd44dddn%40googlegroups.com
>> 
>> .
>>
> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Django developers (Contributions to Django itself)" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to django-develop...@googlegroups.com.
>>>
>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/django-developers/577ba446-7e78-42d8-8a1d-88db169475d4n%40googlegroups.com
>>> 
>>> .
>>>
>>
>>
>> --
>> Adam
>>
> --
> You received this message because you are subscribed to th

Repository

[Akanksha Shah]

Hello everyone! I am new here and I am unable to find the repository can 
someone help me out please.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/2f1d2f29-f3bc-4ab8-9fb7-a8e064bac98an%40googlegroups.com.

Re: Repository

[Harsh Panday]

How can help you?

On Sat, 9 Jan, 2021, 9:08 pm Akanksha Shah, 
wrote:

> Hello everyone! I am new here and I am unable to find the repository can
> someone help me out please.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/2f1d2f29-f3bc-4ab8-9fb7-a8e064bac98an%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAJ0pdCHXVTxeXhfFW9ovUapcJUHjt6ukKKYcy_5gcUqvf6U28w%40mail.gmail.com.

Re: Repository

[Adam Johnson]

Akaksha - do you mean the git repo at https://github.com/django/django/ ?

For more info see
https://docs.djangoproject.com/en/stable/internals/contributing/

On Sat, 9 Jan 2021 at 15:41, Harsh Panday  wrote:

> How can help you?
>
> On Sat, 9 Jan, 2021, 9:08 pm Akanksha Shah, 
> wrote:
>
>> Hello everyone! I am new here and I am unable to find the repository can
>> someone help me out please.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to django-developers+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/django-developers/2f1d2f29-f3bc-4ab8-9fb7-a8e064bac98an%40googlegroups.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/CAJ0pdCHXVTxeXhfFW9ovUapcJUHjt6ukKKYcy_5gcUqvf6U28w%40mail.gmail.com
> 
> .
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM1HsojC3ZiqwfMz%3DsLbDsV9pH1wUPLr9Kwz6ZC0H-SfOA%40mail.gmail.com.

Re: New Here !

[Adam Johnson]

Welcome!

There are many different ways to contribute to Django - the forum,
blogging, translating, documenting, writing code, and so on. Our
Contributing Guide can help you get started with any of these:
https://docs.djangoproject.com/en/stable/internals/contributing/

If you’re looking to work with the code base (for documentation or code),
check out the “Advice for New Contributors” section:
https://docs.djangoproject.com/en/stable/internals/contributing/new-contributors/
. Then see if you can work through the “Writing Your First Patch” tutorial:
https://docs.djangoproject.com/en/stable/intro/contributing/ .

If you get stuck or have questions, post back here or in the “Mentorship”
section on the forum:
https://forum.djangoproject.com/c/internals/mentorship/10

Hope that helps,

Adam

On Fri, 8 Jan 2021 at 10:30, Naveen Kumar  wrote:

> Hello everyone ,
>
> I am new here , and i really wants to contribute to Django community .
> Just need some guidance how to start . I got confused after looking such a
> huge codebase , so please help
>
> Thanks
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/018484b2-5d8a-4966-9967-14553e6be4fen%40googlegroups.com
> 
> .
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM28%3DHWK3CPsfqNjt5zQUCi2yxqMLPO4uReCSV2i-4SQaw%40mail.gmail.com.

Re: Want to contribute to this amazing open source community

[Adam Johnson]

Welcome!

There are many different ways to contribute to Django - the forum,
blogging, translating, documenting, writing code, and more. Our
Contributing Guide can help you get started with many of these:
https://docs.djangoproject.com/en/stable/internals/contributing/

If you’re looking to work with the code base (for documentation or code),
check out the “Advice for New Contributors” section:
https://docs.djangoproject.com/en/stable/internals/contributing/new-contributors/
. Then see if you can work through the “Writing Your First Patch” tutorial:
https://docs.djangoproject.com/en/stable/intro/contributing/ .

If you get stuck or have questions, post back here or in the “Mentorship”
section on the forum:
https://forum.djangoproject.com/c/internals/mentorship/10

Hope that helps,

Adam

On Fri, 8 Jan 2021 at 11:10, Sunny Tyagi  wrote:

>
> Hello everyone,
> I am new to this community, and really want to contribute in this
> organization. It feels amazing when you are work on such software in which
> there is some ,may be not that much, code that is yours.
> Can anyone guide me how to contribute here.
> With regards,
> Sunny
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/988c3496-83c3-464f-a0b4-7b03bcf24665n%40googlegroups.com
> 
> .
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM2Ju1xswWXeogv8OdKXj4LV2i-x0%3D%2BVBBZN6uww5XO4ig%40mail.gmail.com.

Re: Quick Filter in the Admin Sidebar

[Carlton Gibson]

I originally sent the ticket here to see if folks were keen.
Given discussion here, I’ve adjusted to Accepted.
Next step would be a PR.

Thanks all.


On Sat, 9 Jan 2021 at 10:21, Tom Carrick  wrote:

> Hi Maxim,
>
> I think the best thing you can do is add a ticket on trac -
> https://code.djangoproject.com/ and make a PR on GitHub if it's accepted.
> I think it's hard - at least for me - to test something from a gist. Then
> you will get some reviews and more feedback.
>
> Cheers,
> Tom
>
> On Fri, 4 Dec 2020 at 13:01, Maxim Milovanov  wrote:
>
>> Hey guys,
>>
>> I've updated my prototype. What's changed:
>> -- moved the JS and CSS to nav_sidebar.js and nav_sidebar.css respectively
>> -- slight changes in styling
>> -- added ESC key support
>>
>> I've updated my gist
>> https://gist.github.com/MilovanovM/84ffbbec02391c1ba1771a3a6aee5797
>> My changes are:
>> nav_sidebar.html: line 4
>> nav_sidebar.css: line 121 and below
>> nav_sidebar.js: line 40 and below
>>
>> Here is the commit in my repo
>> https://github.com/MilovanovM/django/commit/837701e79c468f72cbce1921b42c130801927e1c
>> I've attached a git patch file as well.
>>
>> Thanks,
>> Maxim
>>
>> пятница, 4 декабря 2020 г. в 12:00:35 UTC+3, Adam Johnson:
>>
>>> I'm not sure that the nav_sidebar.html is the best place for the JS
 snippet. Probably, it should be placed in the main JS. When DOM is ready it
 can be initialized there.
>>>
>>>
>>> Indeed, we can't use inline JS in the admin since that doesn't work with
>>> a strict CSP.
>>>
>>> On Fri, 4 Dec 2020 at 08:42, Maxim Milovanov 
>>> wrote:
>>>
 Hey guys,

 I'm not sure that the nav_sidebar.html is the best place for the JS
 snippet. Probably, it should be placed in the main JS. When DOM is ready it
 can be initialized there.

 About UX. Agree the the "Clear" feature would be useful. It can be an
 "x" icon, or a shortkey (ESC?), or both.

 I'll provide a working sample later.

 Thanks,
 Maxim

 среда, 2 декабря 2020 г. в 20:46:30 UTC+3, Collin Anderson:

> I think this would be really helpful. Looking at the code in the gist,
> that looks about right. It's not too complicated and the basic
> toLowerCase()/indexOf() method of search should hopefully be enough (it's
> what I would do if I were implementing this!). I'd suggest adding some 
> sort
> of clear or x button for canceling/removing the filter, but otherwise I
> think this should be ok UX wise. We can always improve it later.
>
> On Thursday, November 19, 2020 at 9:38:25 AM UTC-5 t...@carrick.eu
> wrote:
>
>> I haven't looked at the gist, but I think in principle it's a good
>> idea. ctrl+f isn't ideal.
>>
>> I think we need to be careful that the UX is good, if we go with this.
>>
>> Tom
>>
>> On Thu, 19 Nov 2020 at 15:16, Maxim Milovanov 
>> wrote:
>>
>>> Yeah, that's why I came up with that idea. There are two projects,
>>> 44 models on one, 57 models on another. It's very hard to navigate
>>>
>>> четверг, 19 ноября 2020 г. в 16:50:37 UTC+3, yasie...@gmail.com:
>>>
 I found this feature very helpful. I'm maintaining two sites with
 more than 20 models registered in the admin and some time is annoying 
 when
 I try to find the one I'm looking for

 El miércoles, 18 de noviembre de 2020 a la(s) 15:13:02 UTC-5, Maxim
 Milovanov escribió:

> Hey guys,
>
> I've posted a ticket  
> with
> a proposal to add a quick filtering feature to the sidebar.
> To see it in action just replace the content of nav_sidebar.html
> by this gist
> 
>
> Does it worth adding to the admin features? Hope for any feedback.
>
> Thanks,
> Maxim
>
 --
>>> You received this message because you are subscribed to the Google
>>> Groups "Django developers (Contributions to Django itself)" group.
>>> To unsubscribe from this group and stop receiving emails from it,
>>> send an email to django-develop...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/django-developers/8376528d-a2df-43b0-829e-43a49bd44dddn%40googlegroups.com
>>> 
>>> .
>>>
>> --
 You received this message because you are subscribed to the Google
 Groups "Django developers (Contributions to Django itself)" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to django-develop...@googlegroups.com.

>>> To view this discussion on the web visit
 https://gro