Re: On adding comments to database schema

2020-05-02 Thread SoungRyoul Kim


Hi felixxm

I want this feature to be reflected in Django.3.1

I know this feature that many people won't use.

but some people who communicate with DBA would be helpful this feature

sometimes ORM take control from DBA


*like these situation...*

DBAs: we want to know comment(help_text) not to *.py  could you use COMMENT SQL 
in migrationFile?

Developers: No, It's Impossible because django ORM does not support COMMENT SQL

DBAs:  that means .. should we refer *.py file everytimes even though 
COMMENT SQL exists but can't use?  
DBAs: it's illogical

Developers: but if we use COMMENT SQL, we customize everytimes to generate 
migrate files
Developers: it's inefficient


That's one of the reasons for avoiding ORM.


If you don't mind me asking...
could you give me a feedback to this feature?

https://github.com/django/django/pull/12605

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/29a5b1c4-21e1-4784-8c00-40778d074ea5%40googlegroups.com.


Re: On adding comments to database schema

2020-05-02 Thread Mariusz Felisiak
Asking for a review on multiple channels doesn't help. You need to be 
patient, we have many PRs in review queue. Please check "Patch review 
checklist" [1]. At first glance, docs are missing.

[1] 
https://docs.djangoproject.com/en/3.0/internals/contributing/writing-code/submitting-patches/#patch-review-checklist

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/f756bda6-c044-47c0-9317-7949eb114398%40googlegroups.com.


Re: On adding comments to database schema

2020-05-02 Thread SoungRyoul Kim
I'm sorry if I sounded like I was pushing you. 

even missing checklist


2020년 5월 3일 일요일 오전 1시 42분 2초 UTC+9, Mariusz Felisiak 님의 말:
>
> Asking for a review on multiple channels doesn't help. You need to be 
> patient, we have many PRs in review queue. Please check "Patch review 
> checklist" [1]. At first glance, docs are missing.
>
> [1] 
> https://docs.djangoproject.com/en/3.0/internals/contributing/writing-code/submitting-patches/#patch-review-checklist
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/d50ae4c2-86d8-4071-88ac-cde6b3a364a6%40googlegroups.com.