Does "Someday/Maybe" triage stage imply a low change of pull request getting merged?

2020-04-08 Thread Andy Robles
Hi all, 

Newcomer here.

Looking to contribute for the first time on a ticket. Currently looking to 
take on #31425 Support for Clear-Site-Data header because it seems 
interesting to me. 

However, I see it is marked as "Someday/Maybe" which leads me to think that 
the chances of a completed pull request getting merged are slim. Is this 
assumption correct and I should therefore seek a different ticket with a 
different triage stage?

Thanks in advance.

-Andy

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/5d721529-363a-4651-9ea3-0e4b89a1e32d%40googlegroups.com.


Re: Does "Someday/Maybe" triage stage imply a low change of pull request getting merged?

2020-04-08 Thread Tim Graham
Generally "Someday/Maybe" tickets aren't ready for coding. Something else 
needs to happen first, perhaps a discussion on this mailing list to come to 
a consensus on how to proceed, or in the cast of that ticket (perhaps), the 
spec to be approved.

On Wednesday, April 8, 2020 at 2:56:44 PM UTC-4, Andy Robles wrote:
>
> Hi all, 
>
> Newcomer here.
>
> Looking to contribute for the first time on a ticket. Currently looking to 
> take on #31425 Support for Clear-Site-Data header because it seems 
> interesting to me. 
>
> However, I see it is marked as "Someday/Maybe" which leads me to think 
> that the chances of a completed pull request getting merged are slim. Is 
> this assumption correct and I should therefore seek a different ticket with 
> a different triage stage?
>
> Thanks in advance.
>
> -Andy
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/f2bdc6f1-33a7-451d-9310-65d1ba16ff27%40googlegroups.com.


Re: Does "Someday/Maybe" triage stage imply a low change of pull request getting merged?

2020-04-08 Thread Adam Johnson
Yes, please unassign yourself and find another ticket. There are similar
experimental headers that we won't include until they're accepted specs,
such as feature-policy. I'm maintaining this in a third party package until
it's "ready": https://github.com/adamchainz/django-feature-policy

On Wed, 8 Apr 2020 at 19:46, Andy Robles  wrote:

> Hi all,
>
> Newcomer here.
>
> Looking to contribute for the first time on a ticket. Currently looking to
> take on #31425 Support for Clear-Site-Data header because it seems
> interesting to me.
>
> However, I see it is marked as "Someday/Maybe" which leads me to think
> that the chances of a completed pull request getting merged are slim. Is
> this assumption correct and I should therefore seek a different ticket with
> a different triage stage?
>
> Thanks in advance.
>
> -Andy
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/5d721529-363a-4651-9ea3-0e4b89a1e32d%40googlegroups.com
> 
> .
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM1YDZgfbokmu0fL%3DsMeRdgnSKZoNQBJK_WF_z7cd_SKWA%40mail.gmail.com.


Re: Does "Someday/Maybe" triage stage imply a low change of pull request getting merged?

2020-04-08 Thread Andy Robles
Okay, I'll assign myself and find another ticket. Thanks for the info.

On Wednesday, April 8, 2020 at 12:27:20 PM UTC-7, Adam Johnson wrote:
>
> Yes, please unassign yourself and find another ticket. There are similar 
> experimental headers that we won't include until they're accepted specs, 
> such as feature-policy. I'm maintaining this in a third party package until 
> it's "ready": https://github.com/adamchainz/django-feature-policy
>
> On Wed, 8 Apr 2020 at 19:46, Andy Robles  > wrote:
>
>> Hi all, 
>>
>> Newcomer here.
>>
>> Looking to contribute for the first time on a ticket. Currently looking 
>> to take on #31425 Support for Clear-Site-Data header because it seems 
>> interesting to me. 
>>
>> However, I see it is marked as "Someday/Maybe" which leads me to think 
>> that the chances of a completed pull request getting merged are slim. Is 
>> this assumption correct and I should therefore seek a different ticket with 
>> a different triage stage?
>>
>> Thanks in advance.
>>
>> -Andy
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to django-d...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/django-developers/5d721529-363a-4651-9ea3-0e4b89a1e32d%40googlegroups.com
>>  
>> 
>> .
>>
>
>
> -- 
> Adam
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/631a8044-f4fb-4ccd-bd88-9b1cd067a682%40googlegroups.com.


Re: Does "Someday/Maybe" triage stage imply a low change of pull request getting merged?

2020-04-08 Thread Andy Robles
*unassign

On Wednesday, April 8, 2020 at 12:29:44 PM UTC-7, Andy Robles wrote:
>
> Okay, I'll assign myself and find another ticket. Thanks for the info.
>
> On Wednesday, April 8, 2020 at 12:27:20 PM UTC-7, Adam Johnson wrote:
>>
>> Yes, please unassign yourself and find another ticket. There are similar 
>> experimental headers that we won't include until they're accepted specs, 
>> such as feature-policy. I'm maintaining this in a third party package until 
>> it's "ready": https://github.com/adamchainz/django-feature-policy
>>
>> On Wed, 8 Apr 2020 at 19:46, Andy Robles  wrote:
>>
>>> Hi all, 
>>>
>>> Newcomer here.
>>>
>>> Looking to contribute for the first time on a ticket. Currently looking 
>>> to take on #31425 Support for Clear-Site-Data header because it seems 
>>> interesting to me. 
>>>
>>> However, I see it is marked as "Someday/Maybe" which leads me to think 
>>> that the chances of a completed pull request getting merged are slim. Is 
>>> this assumption correct and I should therefore seek a different ticket with 
>>> a different triage stage?
>>>
>>> Thanks in advance.
>>>
>>> -Andy
>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Django developers (Contributions to Django itself)" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to django-d...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/django-developers/5d721529-363a-4651-9ea3-0e4b89a1e32d%40googlegroups.com
>>>  
>>> 
>>> .
>>>
>>
>>
>> -- 
>> Adam
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/c25b00da-4ca1-4913-b1f6-fec90513e61b%40googlegroups.com.


Re: Does "Someday/Maybe" triage stage imply a low change of pull request getting merged?

2020-04-08 Thread Andy Robles
Thanks Tim.

On Wednesday, April 8, 2020 at 12:23:28 PM UTC-7, Tim Graham wrote:
>
> Generally "Someday/Maybe" tickets aren't ready for coding. Something else 
> needs to happen first, perhaps a discussion on this mailing list to come to 
> a consensus on how to proceed, or in the cast of that ticket (perhaps), the 
> spec to be approved.
>
> On Wednesday, April 8, 2020 at 2:56:44 PM UTC-4, Andy Robles wrote:
>>
>> Hi all, 
>>
>> Newcomer here.
>>
>> Looking to contribute for the first time on a ticket. Currently looking 
>> to take on #31425 Support for Clear-Site-Data header because it seems 
>> interesting to me. 
>>
>> However, I see it is marked as "Someday/Maybe" which leads me to think 
>> that the chances of a completed pull request getting merged are slim. Is 
>> this assumption correct and I should therefore seek a different ticket with 
>> a different triage stage?
>>
>> Thanks in advance.
>>
>> -Andy
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/3cfcde2a-5b73-43d5-a4c1-bcfb4e76185d%40googlegroups.com.


Proposal: Allow stopwords in slugs generated by ModelAdmin.prepopulated_fields

2020-04-08 Thread Andy Chosak
Automatic slug generation in ModelAdmin via prepopulated_fields 

 
uses a urlify.js 

 
file which, among other behaviors, removes certain stop words 

 
from the slug. For example, a string like "To be or not to be, that is the 
question" will generate a slug "be-or-not-be-question", not 
"to-be-or-not-to-be-that-is-the-question" as one might expect. I’d like to 
solicit feedback on the idea of removing this logic so that slugs can 
contain these words.

For reference, the current list is: a, an, as, at, before, but, by, for, 
from, is, in, into, like, of, off, on, onto, per, since, than, the, this, 
that, to, up, via, with.

Django ticket #30538  mentions 
this behavior as part of a more general comparison between urlify.js and 
Python slugify 
.
 
It was closed as wontfix due to reasons of backwards compatibility. Per the 
triaging 
guidelines 
,
 
I’m making this post to solicit feedback on the more specific question of 
addressing stopword removal in the JS code only -- not to try to address 
any other differences in behavior between these two methods. There’s been 
quite a bit of discussion on generating slugs for non-English languages 
(for example #2282 ), and this 
post is not intended to reopen that discussion.

The current list of stopwords being removed seems to have been the same since 
at least 2005 

 
(the earliest code I can find including this logic). Some of these words 
feel a little unexpected, for example “before” and “since”. After 15 years 
it seems reasonable to revisit the list and consider whether it still makes 
sense.

Was removal of these words introduced for SEO reasons? If so, is this still 
a recommended default behavior? In 2020, search engines like Google seem 
smart enough to interpret them properly. Here's 
 an arbitrary page that discusses 
this and includes a much longer list of what might be considered stopwords. 
As another datapoint, the popular WordPress Yoast SEO plugin used to remove 
stopwords, but stopped doing so  a few 
years back.

Potentially outdated SEO concerns aside, does this behavior still align 
well with the needs and desires of Django users? Is this something this 
community would be open to revisiting? Thanks for your consideration.

(One minor point on language support: allowing these words would help to 
resolve at least some of the unequal treatment given to English over other 
languages, for example #12905 . 
See also wagtail#4899 , 
from which much of this post has been copied, for an example of how this 
logic impacts a Django-based CMS.)

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/fb6c9596-951d-4102-91b5-b5fd9c8c6340%40googlegroups.com.