Re: GitHub Actions

2019-10-31 Thread Florian Apolloner
Hi,

yes I had the same thought yesterday. I think trying with linters first 
should be an easy low hanging fruit (and to get a feeling for it). Tests in 
general might get a bit harder.

Cheers,
Florian

On Thursday, October 31, 2019 at 10:30:10 AM UTC+1, Johannes Hoppe wrote:
>
> Hey there,
>
> I saw that GitHub actions are already enabled for the Django organization.
> Since general availability was announced starting Nov. 13. by GitHub, I 
> wonder, should we use it?
>
> I know we have a very complicated build setup, but maybe it makes sense to 
> move some checks over to GitHub actions.
> All the linters and docs build should be easy. Things like Oracle, might 
> be a bit more difficult, but not impossible I guess.
>
> Anyhow, I would be interested on your thoughts.
>
> Cheers
> -Joe
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/76733e2d-7b2b-45bc-9bbe-e397a15fcb8f%40googlegroups.com.


Re: Python version support for LTS Django (in particular v2.2)

2019-10-31 Thread Johannes Hoppe
I am trying to understand the motivation to use an "old" Django 2.2 but a 
"bleading edge" Python version. I can understand Nicks logic of people 
needing to upgrade form Python 2 to 3 and Debian by default gave them 
Python 3.7.
Following that narrative, maybe we should check what the major operating 
systems have in stall for us, right? Then again, there is not going to be a 
big Python 2 to 3 change again *fingerscrossed*.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/be847bcd-fff5-4672-8d1e-775d8fa7b429%40googlegroups.com.


Re: GitHub Actions

2019-10-31 Thread Johannes Hoppe
I would love to give Selenium a try. O god I hate it when selenium tests 
just randomly fail and I can't restart them.
I think the ability to just restart actions as a user is going to be a 
major improvement to the current workflow.

On Thursday, October 31, 2019 at 6:36:24 PM UTC+9, Florian Apolloner wrote:
>
> Hi,
>
> yes I had the same thought yesterday. I think trying with linters first 
> should be an easy low hanging fruit (and to get a feeling for it). Tests in 
> general might get a bit harder.
>
> Cheers,
> Florian
>
> On Thursday, October 31, 2019 at 10:30:10 AM UTC+1, Johannes Hoppe wrote:
>>
>> Hey there,
>>
>> I saw that GitHub actions are already enabled for the Django organization.
>> Since general availability was announced starting Nov. 13. by GitHub, I 
>> wonder, should we use it?
>>
>> I know we have a very complicated build setup, but maybe it makes sense 
>> to move some checks over to GitHub actions.
>> All the linters and docs build should be easy. Things like Oracle, might 
>> be a bit more difficult, but not impossible I guess.
>>
>> Anyhow, I would be interested on your thoughts.
>>
>> Cheers
>> -Joe
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/df159ce7-040b-4f5f-9115-92e1aa76618a%40googlegroups.com.


Re: GitHub Actions

2019-10-31 Thread Florian Apolloner
I think Tom Forbes started working on it already, you might wanna sync up 
with him: https://github.com/orf/django-github-actions

On Thursday, October 31, 2019 at 10:40:47 AM UTC+1, Johannes Hoppe wrote:
>
> I would love to give Selenium a try. O god I hate it when selenium tests 
> just randomly fail and I can't restart them.
> I think the ability to just restart actions as a user is going to be a 
> major improvement to the current workflow.
>
> On Thursday, October 31, 2019 at 6:36:24 PM UTC+9, Florian Apolloner wrote:
>>
>> Hi,
>>
>> yes I had the same thought yesterday. I think trying with linters first 
>> should be an easy low hanging fruit (and to get a feeling for it). Tests in 
>> general might get a bit harder.
>>
>> Cheers,
>> Florian
>>
>> On Thursday, October 31, 2019 at 10:30:10 AM UTC+1, Johannes Hoppe wrote:
>>>
>>> Hey there,
>>>
>>> I saw that GitHub actions are already enabled for the Django 
>>> organization.
>>> Since general availability was announced starting Nov. 13. by GitHub, I 
>>> wonder, should we use it?
>>>
>>> I know we have a very complicated build setup, but maybe it makes sense 
>>> to move some checks over to GitHub actions.
>>> All the linters and docs build should be easy. Things like Oracle, might 
>>> be a bit more difficult, but not impossible I guess.
>>>
>>> Anyhow, I would be interested on your thoughts.
>>>
>>> Cheers
>>> -Joe
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/07a4594d-d2db-4ae2-a121-1d1bda3e649e%40googlegroups.com.


Re: GitHub Actions

2019-10-31 Thread Tom Forbes


Yep! My life has been unexpectedly busy the last few weeks so I’ve made no 
progress on it, but my idea is to prototype it in that repo before making a MR 
to Django itself. 

Starting with limiting would be easiest, but I actually don’t think it would be 
particularly hard to have the full suite running on actions.

There are a few open questions:

1. How do we support Oracle?
2. Can we (or do we want to?) unify it somehow with docker-box?
3. Will the standard github actions concurrency handle the number of builds we 
put through it in a reasonable time?

I’ve been experimenting with Github actions in a few repositories and I’m very 
impressed with their flexibility. It’s built to be much more than just a CI 
tool so if we wanted to automate anything about the repository we can do it 
with Actions: 

- workflow tags on merge requests, synchronized with Trac?
- messages to first time contributors, thanking them and giving them some 
advice on common issues new time contributors run into? (I really think we 
should do this)
- a comment with a link to the Django ticket if one is not already present?
- close MRs if the trac ticket is closed?

Side note: I’m also increasingly concerned about the lack of delivery on some 
Google groups messages. I had not been sent the first message from Johannes 
(it’s not in spam or any other place), and would have missed it if Felix has 
not replied. 

Tom

>> On 31 Oct 2019, at 09:49, Florian Apolloner  wrote:
> 
> I think Tom Forbes started working on it already, you might wanna sync up 
> with him: https://github.com/orf/django-github-actions
> 
>> On Thursday, October 31, 2019 at 10:40:47 AM UTC+1, Johannes Hoppe wrote:
>> I would love to give Selenium a try. O god I hate it when selenium tests 
>> just randomly fail and I can't restart them.
>> I think the ability to just restart actions as a user is going to be a major 
>> improvement to the current workflow.
>> 
>>> On Thursday, October 31, 2019 at 6:36:24 PM UTC+9, Florian Apolloner wrote:
>>> Hi,
>>> 
>>> yes I had the same thought yesterday. I think trying with linters first 
>>> should be an easy low hanging fruit (and to get a feeling for it). Tests in 
>>> general might get a bit harder.
>>> 
>>> Cheers,
>>> Florian
>>> 
 On Thursday, October 31, 2019 at 10:30:10 AM UTC+1, Johannes Hoppe wrote:
 Hey there,
 
 I saw that GitHub actions are already enabled for the Django organization.
 Since general availability was announced starting Nov. 13. by GitHub, I 
 wonder, should we use it?
 
 I know we have a very complicated build setup, but maybe it makes sense to 
 move some checks over to GitHub actions.
 All the linters and docs build should be easy. Things like Oracle, might 
 be a bit more difficult, but not impossible I guess.
 
 Anyhow, I would be interested on your thoughts.
 
 Cheers
 -Joe
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/django-developers/07a4594d-d2db-4ae2-a121-1d1bda3e649e%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/FE9D758A-F4EB-47A3-9964-FCDA36663387%40tomforb.es.


Re: GitHub Actions

2019-10-31 Thread Adam Johnson
Nice, I've been playing with GitHub actions and I'm impressed. Will move my
projects over from Travis at some point. Thanks for your work Tom

(Likewise on side note - I did not see Johannes' first message)

On Thu, 31 Oct 2019 at 10:08, Tom Forbes  wrote:

> 
> 
> Yep! My life has been unexpectedly busy the last few weeks so I’ve made no
> progress on it, but my idea is to prototype it in that repo before making a
> MR to Django itself.
>
> Starting with limiting would be easiest, but I actually don’t think it
> would be particularly hard to have the full suite running on actions.
>
> There are a few open questions:
>
> 1. How do we support Oracle?
> 2. Can we (or do we want to?) unify it somehow with docker-box?
> 3. Will the standard github actions concurrency handle the number of
> builds we put through it in a reasonable time?
>
> I’ve been experimenting with Github actions in a few repositories and I’m
> very impressed with their flexibility. It’s built to be much more than just
> a CI tool so if we wanted to automate anything about the repository we can
> do it with Actions:
>
> - workflow tags on merge requests, synchronized with Trac?
> - messages to first time contributors, thanking them and giving them some
> advice on common issues new time contributors run into? (I really think we
> should do this)
> - a comment with a link to the Django ticket if one is not already present?
> - close MRs if the trac ticket is closed?
>
> Side note: I’m also increasingly concerned about the lack of delivery on
> some Google groups messages. I had not been sent the first message from
> Johannes (it’s not in spam or any other place), and would have missed it if
> Felix has not replied.
>
> Tom
>
> On 31 Oct 2019, at 09:49, Florian Apolloner  wrote:
>
> 
> I think Tom Forbes started working on it already, you might wanna sync up
> with him: https://github.com/orf/django-github-actions
>
> On Thursday, October 31, 2019 at 10:40:47 AM UTC+1, Johannes Hoppe wrote:
>>
>> I would love to give Selenium a try. O god I hate it when selenium tests
>> just randomly fail and I can't restart them.
>> I think the ability to just restart actions as a user is going to be a
>> major improvement to the current workflow.
>>
>> On Thursday, October 31, 2019 at 6:36:24 PM UTC+9, Florian Apolloner
>> wrote:
>>>
>>> Hi,
>>>
>>> yes I had the same thought yesterday. I think trying with linters first
>>> should be an easy low hanging fruit (and to get a feeling for it). Tests in
>>> general might get a bit harder.
>>>
>>> Cheers,
>>> Florian
>>>
>>> On Thursday, October 31, 2019 at 10:30:10 AM UTC+1, Johannes Hoppe wrote:

 Hey there,

 I saw that GitHub actions are already enabled for the Django
 organization.
 Since general availability was announced starting Nov. 13. by GitHub, I
 wonder, should we use it?

 I know we have a very complicated build setup, but maybe it makes sense
 to move some checks over to GitHub actions.
 All the linters and docs build should be easy. Things like Oracle,
 might be a bit more difficult, but not impossible I guess.

 Anyhow, I would be interested on your thoughts.

 Cheers
 -Joe

>>> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/07a4594d-d2db-4ae2-a121-1d1bda3e649e%40googlegroups.com
> 
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/FE9D758A-F4EB-47A3-9964-FCDA36663387%40tomforb.es
> 
> .
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM3Yku34%3DCpdSyc_WNPZO6TG6EAqE5YrO5wXu%3D4PtZSUdg%40mail.gmail.com.


Re: GitHub Actions

2019-10-31 Thread Florian Apolloner


On Thursday, October 31, 2019 at 11:08:49 AM UTC+1, Tom Forbes wrote:
>
> 1. How do we support Oracle?
>

For now we don't

2. Can we (or do we want to?) unify it somehow with docker-box?
>

If it makes sense yes, if it makes the actions horribly complex and it 
would be more action-like in another way, we maybe should split the two and 
just share settings files? All in all I'd like to use docker-box is 
feasible.

3. Will the standard github actions concurrency handle the number of builds 
> we put through it in a reasonable time?
>

Good question, we can always ask for increases. But hence my idea of 
starting linting first, then maybe add sqlite tests and see how it goes

Cheers,
Florian

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/59e5edb8-2721-4039-8135-6f5b4b114880%40googlegroups.com.


Re: Python version support for LTS Django (in particular v2.2)

2019-10-31 Thread Jani Tiainen
Problem is that Python.org site always gives latest version as default
download.

When 3.8 was released one lib I work with suddenly got flood of help
requests because there was not prebuilt packages for 3.8.

So I think it's more issue for people that inadvertly upgrades Python.

to 31. lokak. 2019 klo 11.39 Johannes Hoppe 
kirjoitti:

> I am trying to understand the motivation to use an "old" Django 2.2 but a
> "bleading edge" Python version. I can understand Nicks logic of people
> needing to upgrade form Python 2 to 3 and Debian by default gave them
> Python 3.7.
> Following that narrative, maybe we should check what the major operating
> systems have in stall for us, right? Then again, there is not going to be a
> big Python 2 to 3 change again *fingerscrossed*.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/be847bcd-fff5-4672-8d1e-775d8fa7b429%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAHn91of%2B3oDEyb6cHcKtPG3gk61%3DucqpoRzUnPRpZ%2BS7ux2ZSg%40mail.gmail.com.