Re: Stop QuerySet repr from executing queries

2019-10-16 Thread Mariusz Felisiak
W dniu środa, 16 października 2019 07:53:05 UTC+2 użytkownik Harro napisał:
>
> Yes, it's a complicated issue, but isn't the SQL query the ultimate 
> representation of which methods are called or not?
>
> Having the query evaluated during debugging has been shown to be harmful 
> in certain situations, isn't that the most important thing to fix?
>

Current behavior is extremely valuable IMO. It is not the most important 
thing to remove behavior that most of users use because we want to fix an 
edge case that was reported twice in the last six years. I agree that we 
can clarify this in docs. SQL query is not a solutions because not all of 
ORM users know SQL. Moreover the current `repr()` shows values from DB that 
we'll miss showing only SQL. You can check in the Django documentation how 
users use the current `repr()` e.g. in tutorials.

Best,
Mariusz

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/dc658cc9-0974-4088-9ab7-f8eb24c74d36%40googlegroups.com.


Question about PR for #27391 -- Implement SimpleTestCase.debug method

2019-10-16 Thread Pavel Savchenko
Hello,

Is there anything left to-do or discuss to finish this?

https://github.com/django/django/pull/7436


Regards,
Pavel

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/4c82d1cd-c9e3-4b73-b84e-ea7ee148eb39%40googlegroups.com.


Re: Question about PR for #27391 -- Implement SimpleTestCase.debug method

2019-10-16 Thread Mariusz Felisiak
Hi Pavel,

   Thanks for this PR. You don't need to do anything at the moment, just be 
patient, it's waiting in a review queue and it's on my list.

Best,
Mariusz

W dniu środa, 16 października 2019 14:26:19 UTC+2 użytkownik Pavel 
Savchenko napisał:
>
> Hello, 
>
> Is there anything left to-do or discuss to finish this? 
>
> https://github.com/django/django/pull/7436 
> 
>  
>
>
> Regards, 
> Pavel

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/910ab72f-0758-4b90-957c-7bf1b0d96b80%40googlegroups.com.