Re: About users

[Adam Johnson]

Hi Burak

The reason the custom user model feature exists is because there are so
many "really simple" changes possible. Adding them all as options to Django
itself would add many such switches and a large maintenance burden.

For the exact change you're suggesting, there's a third party package out
there: https://github.com/jambonsw/django-improved-user/ .

Thanks,

Adam

On Sun, 29 Sep 2019 at 21:59, Burak Karahan  wrote:

> I want to contribute about the internal auth user. Many people creating
> custom user for really simple changes. For example username to email. I
> want to contribute about it and it could be change with settings variable.
> May be USE_EMAIL_AUTH = True. What do you think about it ?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/008a044b-702f-47c9-9411-faec450aa330%40googlegroups.com
> 
> .
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM0743VnrKkxmfpht-Q9sxHhpvp-oxE0T%2Bv%3Div5k9rcO4Q%40mail.gmail.com.

Re: Fellow Reports -- September 2019

[Carlton Gibson]

Hi all, 



Calendar Week 38 -- ending 22 September.


Triaged:

https://github.com/django/djangoproject.com/issues/949 -- Logging error 
(Invalid)
https://code.djangoproject.com/ticket/14218 -- Paginator just implement the 
__iter__ function (Accepted)
https://code.djangoproject.com/ticket/30781 -- New feature: field 
permissions based on data classification (needsinfo)
https://github.com/django/djangoproject.com/issues/947 -- deploy problem 
(Invalid)
https://code.djangoproject.com/ticket/30779 -- technical_500.html: use 
filename:lineno format for exception location (Accepted)



Reviewed:

https://github.com/django/django/pull/10643 -- Fixed #29915 -- Added 
support for values with hyphens to pattern lookups for UUIDField on 
backends without UUID datatype.
https://github.com/django/django/pull/9296 -- Fixed #14218 -- Added 
iteration behavior to Paginator.
https://github.com/django/django/pull/10563 -- Fixed #29615 -- Document 
diff in behaviour b/w m2m_changed for add & remove, when called 
multiple times.
https://code.djangoproject.com/ticket/30776 -- AuthenticationForm's 
username field doesn't set maxlength HTML attribute.
https://github.com/django/djangoproject.com/pull/903 -- Relocate doc search 
bar
https://code.djangoproject.com/ticket/20935 -- ePub documentation not valid



Authored:

https://github.com/django/django/pull/11792 -- Fixed #27462 -- Clarifed 
difference in m2m_changed pk_set for add() vs remove().





Calendar Week 39 -- ending 29 September.


I was at DjangoCon US this week. 

Talks: 

- Your web framework needs you: an update. (Getting contributors.)
- Using Django as a micro-framework. (A trip through the middleware and 
BaseHandler.)

These'll be on YouTube at some point. 

Sprints: 

Gave a "Getting started contributing to Django" workshop at the sprints. 
This went really well: we had four or five tables of people getting going 
with
the test suite and Trac. A number of PRs were opened. 

Big thanks to Mariusz for picking these up and reviewing/merging _overnight_
for us — that was rewarding for folks. 

I started notes here. I'll work on that for DjangoCon Europe, and hopefully 
it
can turn into a community resource that we can run each time. 


Triaged:

https://code.djangoproject.com/ticket/27086 -- running servers.tests may 
hang in parallel mode on Mac OS X (Accepted)



Reviewed:

https://github.com/django/django/pull/11835 -- Fixes #30806 by configuring 
OBJC_DISABLE_INITIALIZE_FORK_SAFETY in tox. 



Authored:

https://github.com/carltongibson/dcus2019sprints -- Notes for "Getting 
started contributing to Django" sprints workshop.



Kind Regards,

Carlton

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/c2c69841-dd16-434c-8c84-973c7440f01a%40googlegroups.com.

Desired behaviour when passing a non boolean to filter(*__isnull)

[André Ericson]

Hello,

I came across the discovery (due to a bug on our code) that it's possible 
to pass a non-boolean to the __isnull filter. What would be the desired 
behavior here?
Should we raise an exception or should Django use the truthy value?

If the second case is the desired behavior I have found a bug in Django 
that caused some unexpected behavior. If allowing non-booleans is not 
desired shouldn't we check for it?

I can submit a PR for the specific bug that I found but it would be nice to 
know if I should.

Thanks.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/dcbb5060-c7a1-4363-9564-e79c0ba319e6%40googlegroups.com.

Re: Desired behaviour when passing a non boolean to filter(*__isnull)

[Adam Johnson]

Hi André

I think Django should use the truthy value. Please open a ticket with your
bug report and then a PR.

Thanks,

Adam

On Mon, 30 Sep 2019 at 15:37, André Ericson  wrote:

> Hello,
>
> I came across the discovery (due to a bug on our code) that it's possible
> to pass a non-boolean to the __isnull filter. What would be the desired
> behavior here?
> Should we raise an exception or should Django use the truthy value?
>
> If the second case is the desired behavior I have found a bug in Django
> that caused some unexpected behavior. If allowing non-booleans is not
> desired shouldn't we check for it?
>
> I can submit a PR for the specific bug that I found but it would be nice
> to know if I should.
>
> Thanks.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/dcbb5060-c7a1-4363-9564-e79c0ba319e6%40googlegroups.com
> 
> .
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM25T3UfANi%3DL%2BR-gFY%2BRZMRZ3Wdqz4eJCZ0PzSTZd0gqQ%40mail.gmail.com.

Re: Desired behaviour when passing a non boolean to filter(*__isnull)

[André Ericson]

Super. I'll look into it!

On Monday, September 30, 2019 at 5:32:44 PM UTC+2, Adam Johnson wrote:
>
> Hi André
>
> I think Django should use the truthy value. Please open a ticket with your 
> bug report and then a PR.
>
> Thanks,
>
> Adam
>
> On Mon, 30 Sep 2019 at 15:37, André Ericson  > wrote:
>
>> Hello,
>>
>> I came across the discovery (due to a bug on our code) that it's possible 
>> to pass a non-boolean to the __isnull filter. What would be the desired 
>> behavior here?
>> Should we raise an exception or should Django use the truthy value?
>>
>> If the second case is the desired behavior I have found a bug in Django 
>> that caused some unexpected behavior. If allowing non-booleans is not 
>> desired shouldn't we check for it?
>>
>> I can submit a PR for the specific bug that I found but it would be nice 
>> to know if I should.
>>
>> Thanks.
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to django-d...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/django-developers/dcbb5060-c7a1-4363-9564-e79c0ba319e6%40googlegroups.com
>>  
>> 
>> .
>>
>
>
> -- 
> Adam
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/4613ddd5-655b-4e4f-8f53-7d6279a15409%40googlegroups.com.

Re: Fellow Reports - September 2019

[Mariusz Felisiak]

Week ending September 29, 2019.

*Triaged:*
https://code.djangoproject.com/ticket/30793 - Add a SECURITY.md file. 
(invalid)
https://code.djangoproject.com/ticket/30794 - inspectdb should generate 
related_name for ForeignKey. (duplicate)
https://code.djangoproject.com/ticket/30785 - Documentation missing info 
about subdomain wildcard for SESSION_COOKIE_DOMAIN. (invalid)
https://code.djangoproject.com/ticket/30795 - Django cannot serialize value 
into migration file. (invalid)
https://code.djangoproject.com/ticket/30797 - LoginView Error when going 
back to login page (invalid)
https://code.djangoproject.com/ticket/30798 - models.E015 is raised when 
Meta.ordering contains "pk" of a related field. (created)
https://code.djangoproject.com/ticket/30800 - Altering field crashes for 
fields with custom db_type() on PostgreSQL. (created)
https://code.djangoproject.com/ticket/30801 - Improve guidance for making 
good use of signals. (accepted)
https://code.djangoproject.com/ticket/30810 - 
WatchmanReloaderTests.test_setting_timeout_from_environment_variable() 
fails with AttributeError. (accepted)
https://code.djangoproject.com/ticket/30812 - ConditionalGetMiddleware 
returns 304 if ETag is the same but Last-Modified has changed. (accepted)
https://code.djangoproject.com/ticket/30761 - The floatformat filter 
sometimes returns "-0" instead of "0". (accepted)
https://code.djangoproject.com/ticket/30807 - test_extract_file_permissions 
test fails when umask is set to 000. (accepted)
https://code.djangoproject.com/ticket/30811 - Django throws 
'UnicodeEncodeError' when using Cyrillic symbols to override field 
upload_to. (invalid)
https://code.djangoproject.com/ticket/30813 - dumpdata > flush > loaddata. 
(invalid)

*Reviewed/committed:*
https://github.com/django/django/pull/10643 - Fixed #29915 -- Added support 
for values with hyphens to pattern lookups for UUIDField on backends 
without UUID datatype.
https://github.com/django/django/pull/11729 - Fixed #13296 -- Fixed 
ordering by Options.order_with_respect_to after deleting objects.
https://github.com/django/django/pull/11787 - Fixed #30732 -- Doc'd that 
SameSite cookies flags can affect xframe_options_exempt.
https://github.com/django/django/pull/11810 - Fixed #30796 -- Prevented 
select_related() from mutating a queryset on chaining.
https://github.com/django/django/pull/11802 - Refs #26601 -- Used new-style 
middlewares in documentation.
https://github.com/django/django/pull/11782 - Fixed #29444 -- Allowed 
returning multiple fields from INSERT statements on Oracle.
https://github.com/django/django/pull/11579 - Removed some outdated 
backwards compatibility imports and misleading comments.
https://github.com/django/django/pull/11564 - Fixed #25598 -- Added 
SCRIPT_NAME prefix to STATIC_URL and MEDIA_URL set to relative paths.
https://github.com/django/django/pull/11833 - Fixed #30810 -- Fixed 
WatchmanReloaderTests.test_setting_timeout_from_environment_variable test.
https://github.com/django/django/pull/11822 - Fixed #27921 -- Clarified 
usage of make_aware() with is_dst argument.
https://github.com/django/django/pull/11839 - [2.2.x] Fixed #30216 -- Doc'd 
that BooleanField is no longer blank=True in Django 2.1.
https://github.com/django/django/pull/11820 - Fixed #30798 -- Fixed 
Meta.ordering validation for pk of related fields.
https://github.com/django/django/pull/11842 - Refs #30597 -- Added a 
warning about dependent apps when unapplying migrations.
https://github.com/django/django/pull/11821 - Fixed #30597 -- Clarified how 
to unapply migrations.
https://github.com/django/django/pull/11824 - Fixed #30802 -- Prevented 
manifest creation when running collectstatic in dry run mode.

*Authored:*
https://github.com/django/django/pull/11817 - Fixed #30800 -- Fixed 
migrations crash when altering a field with custom db_type().
https://github.com/jacobian/dj-database-url/pull/124 - Add testing for 
Django 3.0
https://github.com/sebleier/django-redis-cache/pull/174 - Add support for 
Django 3.0
https://github.com/django/django-contrib-comments/pull/146 - Added testing 
for Django 3.0.

Best regards,
Mariusz

>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/648c9b77-1699-4363-a627-3c1c21f4ace2%40googlegroups.com.