Cross-DB JSONField ready for review

2019-08-02 Thread Sage M.A. 
Hello, everyone.

As a follow-up to this message 

 and this ticket , I have 
completed the implementation of a cross-DB JSONField.
I have submitted a PR , ready 
for review. Some folks have reviewed the PR multiple times (thanks!), but I 
think some more passes from new perspectives would be cool.

Regards,
Sage

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/d68c0bb6-40cc-418e-b511-60caf4b5a8ca%40googlegroups.com.

Re: Fellow Reports -- July 2019

2019-08-02 Thread Carlton Gibson 
Hi All,


Reposting Wks 29-30, in which I inadvertently leaked small details of the 
then 
pending security patches. 

Many thanks to Kevin Grinberg for noticing and 
advising me quickly. I then deleted the post, which, whilst not ideal, was 
the 
best I could do. 

I've update the command to compile the report to automatically exclude 
security 
issues. 


Calendar Week 29 -- ending 21 July.


Triaged:

https://code.djangoproject.com/ticket/30647 -- [FATAL] FileNotFoundError 
with runserver command inside Docker container (needsinfo)
https://code.djangoproject.com/ticket/30638 -- Allow the per-database 
TIME_ZONE option on databases that support timezones. (needsinfo)
https://code.djangoproject.com/ticket/30635 -- Add feature to sanitize text 
include control characters (needsinfo)



Reviewed:

https://github.com/django/django/pull/11576 -- Refs #30083 -- Clarified 
database state of instances in signals.pre_init docs.
https://github.com/django/django/pull/11574 -- Refs #30547 -- Clarified 
that partial UniqueConstraints don't affect model validation.
https://github.com/django/django/pull/11157 -- Fixed #13910 -- Added 
generator based rendering (streaming) to templates and supporting views.
https://github.com/django/django/pull/11021 -- Refs #29714 -- Added 
settings to override ExceptionReporter class in AdminEmailHandler



Calendar Week 30 -- ending 28 July.


Prepared releases for 1/8/2019


Reviewed:

https://github.com/django/djangoproject.com/pull/921 -- Use SVG image for 
donation icon.
https://github.com/django/django/pull/11476 -- Fixed #30066 -- Enabled 
super user creation without email and password
https://code.djangoproject.com/ticket/11602 -- Refactored the Django's 
documentation to fix the path of django's admin templates are located.
https://github.com/django/django/pull/11580 -- Fixed #26142 -- Added a 
'edit only' mode for model formsets
https://github.com/django/django/pull/11481 -- Fixed #10403 -- Declaraive 
syntax for FormSet, ModelFormSet & InlineF…
https://github.com/django/django/pull/11601 -- Fixed #29427 -- Ensured 
request has _body even when RequestDataTooBig is raised
https://github.com/django/django/pull/11582 -- Fixed #23524 -- Allowed 
TIME_ZONE option on PostgreSQL.





Calendar Week 31 -- ending 04 August.


Released Django versions 1.11.23, 2.1.11, 2.2.4


Triaged:

https://code.djangoproject.com/ticket/30672 -- JSONField/HStoreField key 
and index transforms crash. (Accepted)
https://code.djangoproject.com/ticket/30666 -- Use autocomplete_fields with 
models not registered in the admin (wontfix)
https://code.djangoproject.com/ticket/30660 -- Use of properites by Django 
and debugging in PyCharm (needsinfo)



Reviewed:

https://code.djangoproject.com/ticket/30661 -- Add support for 
SmallAutoField
https://github.com/django/django/pull/11608 -- Update request-response.txt
https://github.com/django/django/pull/11617 -- Moved indexes in 
ArrayField's Index and Slice transforms to SQL params.
https://code.djangoproject.com/ticket/30669 -- Can 
FILE_UPLOAD_MAX_MEMORY_SIZE be set to None?



Authored:

https://github.com/django/django/pull/11614 -- Refs #30669 -- Removed 
unused branch in ASGIHander.read_body().





Kind Regards,

Carlton


-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/095a6d61-d7e4-454f-911a-6eeb52c13aeb%40googlegroups.com.

Re: Cross-DB JSONField ready for review

2019-08-02 Thread Carlton Gibson 
Hey Sage, 

Super stuff! Well done on your effort so far. (I can't say how excited I am 
about this feature. 💃)

Kind Regards,

Carlton


On Friday, 2 August 2019 13:46:46 UTC+2, Sage M.A. wrote:
>
> Hello, everyone.
>
> As a follow-up to this message 
> 
>  and this ticket , I have 
> completed the implementation of a cross-DB JSONField.
> I have submitted a PR , 
> ready for review. Some folks have reviewed the PR multiple times (thanks!), 
> but I think some more passes from new perspectives would be cool.
>
> Regards,
> Sage
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/d8c946e2-9111-488a-9869-c6b4e555fac3%40googlegroups.com.

Re: Cross-DB JSONField ready for review

2019-08-02 Thread Sage M.A. 
Hi Carlton,

Thanks! I hope it can be merged soon :D

Oh, and by the way, where should I write a setup guide for SQLite+JSON1? I 
don't know where and how to put it in the docs. By linking to a page in 
Django wiki, perhaps?


Regards,
Sage

On Friday, 2 August 2019 22:08:17 UTC+7, Carlton Gibson wrote:
>
> Hey Sage, 
>
> Super stuff! Well done on your effort so far. (I can't say how excited I 
> am about this feature. 💃)
>
> Kind Regards,
>
> Carlton
>
>
> On Friday, 2 August 2019 13:46:46 UTC+2, Sage M.A. wrote:
>>
>> Hello, everyone.
>>
>> As a follow-up to this message 
>> 
>>  and this ticket , I have 
>> completed the implementation of a cross-DB JSONField.
>> I have submitted a PR , 
>> ready for review. Some folks have reviewed the PR multiple times (thanks!), 
>> but I think some more passes from new perspectives would be cool.
>>
>> Regards,
>> Sage
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/38824b73-162f-49b1-8709-887cace1af7c%40googlegroups.com.

Re: Cross-DB JSONField ready for review

2019-08-02 Thread Adam Johnson 
Sage, I think that should go in the main docs, in the docs/ folder in the
repo, no?

On Fri, 2 Aug 2019 at 18:09, Sage M.A.  wrote:

> Hi Carlton,
>
> Thanks! I hope it can be merged soon :D
>
> Oh, and by the way, where should I write a setup guide for SQLite+JSON1? I
> don't know where and how to put it in the docs. By linking to a page in
> Django wiki, perhaps?
>
>
> Regards,
> Sage
>
> On Friday, 2 August 2019 22:08:17 UTC+7, Carlton Gibson wrote:
>>
>> Hey Sage,
>>
>> Super stuff! Well done on your effort so far. (I can't say how excited I
>> am about this feature. 💃)
>>
>> Kind Regards,
>>
>> Carlton
>>
>>
>> On Friday, 2 August 2019 13:46:46 UTC+2, Sage M.A. wrote:
>>>
>>> Hello, everyone.
>>>
>>> As a follow-up to this message
>>> 
>>>  and this ticket , I have
>>> completed the implementation of a cross-DB JSONField.
>>> I have submitted a PR ,
>>> ready for review. Some folks have reviewed the PR multiple times (thanks!),
>>> but I think some more passes from new perspectives would be cool.
>>>
>>> Regards,
>>> Sage
>>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/38824b73-162f-49b1-8709-887cace1af7c%40googlegroups.com
> 
> .
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM1YBQw9Pb20h5QFjYXVJsWHvSAGbqW2_yuMtrnm6o2yyA%40mail.gmail.com.

Re: Cross-DB JSONField ready for review

2019-08-02 Thread Sage M.A. 
Adam, that's what I thought at first. However, I don't know which section 
it should go under. Writing it on Model fields docs doesn't seem right. 
Maybe in a howto?

On Saturday, 3 August 2019 01:23:25 UTC+7, Adam Johnson wrote:
>
> Sage, I think that should go in the main docs, in the docs/ folder in the 
> repo, no?
>
> On Fri, 2 Aug 2019 at 18:09, Sage M.A. > 
> wrote:
>
>> Hi Carlton,
>>
>> Thanks! I hope it can be merged soon :D
>>
>> Oh, and by the way, where should I write a setup guide for SQLite+JSON1? 
>> I don't know where and how to put it in the docs. By linking to a page in 
>> Django wiki, perhaps?
>>
>>
>> Regards,
>> Sage
>>
>> On Friday, 2 August 2019 22:08:17 UTC+7, Carlton Gibson wrote:
>>>
>>> Hey Sage, 
>>>
>>> Super stuff! Well done on your effort so far. (I can't say how excited I 
>>> am about this feature. 💃)
>>>
>>> Kind Regards,
>>>
>>> Carlton
>>>
>>>
>>> On Friday, 2 August 2019 13:46:46 UTC+2, Sage M.A. wrote:

 Hello, everyone.

 As a follow-up to this message 
 
  and this ticket , I have 
 completed the implementation of a cross-DB JSONField.
 I have submitted a PR , 
 ready for review. Some folks have reviewed the PR multiple times 
 (thanks!), 
 but I think some more passes from new perspectives would be cool.

 Regards,
 Sage

>>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to django-d...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/django-developers/38824b73-162f-49b1-8709-887cace1af7c%40googlegroups.com
>>  
>> 
>> .
>>
>
>
> -- 
> Adam
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/bc75684b-dae2-4acb-bd4a-e24e5f9845b9%40googlegroups.com.

Re: Cross-DB JSONField ready for review

2019-08-02 Thread Carlton Gibson 
Hi Sage. Perhaps draft it in a howto and we can have a look once it’s in
play. C.

On Sat, 3 Aug 2019 at 03:23, Sage M.A.  wrote:

> Adam, that's what I thought at first. However, I don't know which section
> it should go under. Writing it on Model fields docs doesn't seem right.
> Maybe in a howto?
>
> On Saturday, 3 August 2019 01:23:25 UTC+7, Adam Johnson wrote:
>>
>> Sage, I think that should go in the main docs, in the docs/ folder in the
>> repo, no?
>>
>> On Fri, 2 Aug 2019 at 18:09, Sage M.A.  wrote:
>>
>>> Hi Carlton,
>>>
>>> Thanks! I hope it can be merged soon :D
>>>
>>> Oh, and by the way, where should I write a setup guide for SQLite+JSON1?
>>> I don't know where and how to put it in the docs. By linking to a page in
>>> Django wiki, perhaps?
>>>
>>>
>>> Regards,
>>> Sage
>>>
>>> On Friday, 2 August 2019 22:08:17 UTC+7, Carlton Gibson wrote:

 Hey Sage,

 Super stuff! Well done on your effort so far. (I can't say how excited
 I am about this feature. 💃)

 Kind Regards,

 Carlton


 On Friday, 2 August 2019 13:46:46 UTC+2, Sage M.A. wrote:
>
> Hello, everyone.
>
> As a follow-up to this message
> 
>  and this ticket , I
> have completed the implementation of a cross-DB JSONField.
> I have submitted a PR ,
> ready for review. Some folks have reviewed the PR multiple times 
> (thanks!),
> but I think some more passes from new perspectives would be cool.
>
> Regards,
> Sage
>
 --
>>> You received this message because you are subscribed to the Google
>>> Groups "Django developers (Contributions to Django itself)" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to django-d...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/django-developers/38824b73-162f-49b1-8709-887cace1af7c%40googlegroups.com
>>> 
>>> .
>>>
>>
>>
>> --
>> Adam
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/bc75684b-dae2-4acb-bd4a-e24e5f9845b9%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAJwKpyTPFi1sy9vfvbfba_oe%3DsdEb7Bsne_XK9R-Sai2hTDShA%40mail.gmail.com.