Re: TestCase.setUpTestData in-memory data isolation.

2018-12-03 Thread charettes
Hey Tobias, thanks for chiming in.

The main motivation behind this package and this core inclusion proposal is 
that I've come across a non-negligible number users that were surprised to 
find out this was not working automatically and others that completely 
stopped using setUpTestData because of this limitation (we're even doing 
this in the Django test suite under certain circumstances). Now these cases 
could effectively be solved by an explicit decoration of the setUpTestData 
method but it does feel like an hack, at least to me, that users shouldn't 
have to worry about given how TestCase was branded as a bulletproof test 
data isolation tool.

With that said I wouldn't really mind forcing the developer to opt-in 
through the use of a decorator like in the external package does if that's 
what the consensus is here. I just wanted to mention that I was having a 
hard time siding with the _too much magic_ argument given all the isolation 
_magic_ TestCase already performs.

Cheers,
Simon

Le dimanche 2 décembre 2018 19:43:14 UTC-5, Tobias McNulty a écrit :
>
> On Fri, Nov 30, 2018, 1:03 PM Adam Johnson  
> wrote:
>
>> Tobias - using database updates isn't always viable. Also the system 
>> under test might need to take in the model instance, mutate it and execute 
>> its own save(), and then there's no way of rolling that back if the object 
>> wasn't deepcopy'd
>>
>
> Fair enough, but for those cases, one could just as easily deepcopy the 
> object in the test itself. Again, it's more explicit, gives the developer 
> control over exactly what they want to happen, and makes failures more 
> obvious.
>
> I suppose if the API allowed one to mix and match approaches for different 
> tests and model objects (like Simon's testdata app does right now), that 
> would work, too.
>
> Tobias
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/4881f375-5966-4f09-905a-ef807df129fa%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Django bugfix releases 1.11.17 and 2.1.4.

2018-12-03 Thread Carlton Gibson
Details are available on the Django project weblog: 

https://www.djangoproject.com/weblog/2018/dec/03/bugfix-releases/

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/87C178DB-CE37-4338-89CA-707172652A23%40gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Django bugfix releases 1.11.17 and 2.1.4.

2018-12-03 Thread Ing.Daniel Bojorge
Thanks.


Dios L@s Bendiga

Saludos,



[image: --]

daniel.bojorge
[image: http://]about.me/daniel.bojorge

 *Curso Desarrollo Web con Python usando Django 2.1 Para Principiantes*

*Fácil Replicación de Cualquier Base de Datos y/o Sistema Operativo*

*Programación en Capas (Web y Escritorio)* 
Mi Blog 
Nicaragua

"Si ustedes permanecen unidos a mí, y si permanecen fieles a mis
enseñanzas, pidan lo que quieran y se les dará.
(Juan 15:7 DHH)
Bendito el varón que se fía en el SEÑOR, y cuya confianza es el SEÑOR.
(Jeremías 17:7 RV2000)



El lun., 3 dic. 2018 a las 11:11, Carlton Gibson ()
escribió:

> Details are available on the Django project weblog:
>
> https://www.djangoproject.com/weblog/2018/dec/03/bugfix-releases/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers  (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/87C178DB-CE37-4338-89CA-707172652A23%40gmail.com
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMQeQjagqOL41PLZNEUaRefDayVpDkx%2BP%3DFwchy3xNfuKdj5nw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Fellow Reports - November 2018

2018-12-03 Thread Tim Graham


Week ending December 1, 2018

Triaged

---

https://code.djangoproject.com/ticket/29992 - Error in admin checking 
list_display items (needsinfo)

Authored

--

https://github.com/django/django/pull/10697 - Switched TestCase to 
SimpleTestCase where possible in Django's tests.

Reviewed/committed

--

https://github.com/django/django/pull/10683 - Refs #29722 -- Added 
introspection of materialized views for Oracle.

https://github.com/django/django/pull/10685 - Switched setUp() to 
setUpTestData() where possible in Django's tests.

https://github.com/django/django/pull/10681 - Fixed #28385 -- Fixed 
deserializing natural keys when primary key has a default value.

https://github.com/django/django/pull/10629 - Fixed #29929 -- Fixed admin 
view-only change form crash when using ModelAdmin.prepopulated_fields.

https://github.com/django/django/pull/10667 - Refs #25251 -- Filtered out 
skipped tests when processing the test suite to set 
_next_serialized_rollback.

https://github.com/django/django/pull/10699 - Fixed #29991 -- Doc'd logger 
propagation for the default logging config.

https://github.com/django/django/pull/10704 - Fixed #29997 -- Allowed 
combining SearchQuerys with different configs.
https://github.com/django/django/pull/10678 - Fixed #29930 -- Allowed 
editing in admin with view-only inlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/5d7e5a8b-3bc5-4409-bc59-2cfac2440c31%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.