Re: DEP pre-proposal for a simpler URLs syntax.

2017-08-04 Thread John Griebel
Hi All,
My day job has gotten unexpectedly busy, and it seems I've taken on more
than I can handle on the code side of things for this DEP. If someone else
can help out, that would be great. I can provide some help with the
documentation if it's still needed, though it seems like Tim's PR is pretty
complete.

Thanks,
John Griebel | Senior Backend Engineer | 3Blades.io | 814-227-4213

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAOK12Wayh0DsJZQMmhnaGFBP6GB9PVD6ZuGQi_eM-tOo_FchDw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Admin actions.js performance

2017-08-04 Thread ecas
Hi,

I was doing some loading time benchmarking in Chrome and I noticed that the 
javascript that sets up the actions in the admin page takes some time.

I pinpointed the problem to this jquery:

$('form#changelist-form table#result_list tr').find('td:gt(0) 
:input').change(function() {
list_editable_changed = true;
});

If I replace it with the following top-down approach, the execution time of 
the overall function call is reduced from ~115ms to ~53ms (as seen in the 
attached screenshots)

$('form#changelist-form table#result_list tr')
*.find('td:gt(0)').find(':input')*.change(function() {
list_editable_changed = true;
});

Has anybody noticed this or can reproduce it?

Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/86804109-cd6d-4514-82c1-72b53e000ef2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Admin actions.js performance

2017-08-04 Thread Collin Anderson
I can confirm it's slightly faster in my case (maybe 20-50ms for 58 rows, 3
inputs per row).

I can get it ~15ms faster by making it just one event handler, though it's
a bigger change:
$('#result_list').on('change', 'td:nth-child(n+2) :input', function() {

On Fri, Aug 4, 2017 at 7:29 AM, ecas  wrote:

> Hi,
>
> I was doing some loading time benchmarking in Chrome and I noticed that
> the javascript that sets up the actions in the admin page takes some time.
>
> I pinpointed the problem to this jquery:
>
> $('form#changelist-form table#result_list tr').find('td:gt(0)
> :input').change(function() {
> list_editable_changed = true;
> });
>
> If I replace it with the following top-down approach, the execution time
> of the overall function call is reduced from ~115ms to ~53ms (as seen in
> the attached screenshots)
>
> $('form#changelist-form table#result_list tr')
> *.find('td:gt(0)').find(':input')*.change(function() {
> list_editable_changed = true;
> });
>
> Has anybody noticed this or can reproduce it?
>
> Thanks!
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/django-developers/86804109-cd6d-4514-82c1-
> 72b53e000ef2%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAFO84S5OPJ-1crxYrhPgW%3DfpVZcgfYjWGEyy2wi_Gpr9KRnLPw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.