Re: status of 1.9 release blockers

2015-11-14 Thread Tim Graham
Sorry for the lack of updates, but no news is good news. We're on track for 
a release candidate on Monday.

On Saturday, October 17, 2015 at 7:41:55 PM UTC-4, Tim Graham wrote:
>
> We're on schedule for Monday's beta release. Most of the backported fixes 
> have been issues affecting 1.8 too.
>
> On Saturday, October 3, 2015 at 10:31:13 AM UTC-4, Tim Graham wrote:
>>
>> We've resolved a couple of release blockers on the stable/1.9.x branch 
>> since the alpha, but overall bug reports have been quiet. Hopefully that's 
>> a good sign!
>>
>> The beta release is scheduled for 2 weeks + 2 days from now, Monday 
>> October 19.
>>
>> On Wednesday, September 23, 2015 at 3:17:28 PM UTC-4, Tim Graham wrote:
>>>
>>> All known issues are resolved. I plan to create the branch and make the 
>>> release in about 4 hours if nothing else pops up.
>>>
>>> On Wednesday, September 23, 2015 at 9:46:40 AM UTC-4, Tim Graham wrote:

 I'm okay with deferring it. I'll see if we can release the alpha later 
 today then. I found one regression in the unreviewed ticket queue this 
 morning and submitted a pull request. I'm also investigating a possible 
 regression causing the djangoproject.com tests to fail.

 On Wednesday, September 23, 2015 at 6:39:58 AM UTC-4, Markus Holtermann 
 wrote:
>
> I did not fully follow the discussion, but by the amount of email 
> notifications I got on that PR if feels to me that deferring it to 1.10 
> would be the better option, also considering what Tom said about this 
> being 
> part of a core component and it has to be done right.
>
> /Markus
>
> On Wednesday, September 23, 2015 at 2:54:50 AM UTC+10, Tim Graham 
> wrote:
>>
>> The second patch has been committed, and the first one is still under 
>> review. 
>>
>> Florian says "with all that forth and back [on the pull request] I am 
>> not sure if it is not better to defer it to 1.10, i.e. I completely 
>> missed 
>> the base64 stuff for instance. One option would be to ship it with 
>> the feature inactive and mark it as experimental and ask users to try it 
>> out. Though, that would probably be a first."
>>
>> I'd also be more comfortable if it were disabled by default. The main 
>> problem for me is the documentation doesn't really motivate the feature 
>> very well and describe how one should go about setting the values of the 
>> new settings.
>>
>> Options:
>> 1) Defer the patch to 1.10 and release the alpha today.
>> 2) Maintain the feature freeze until the end of the week to see if 
>> the patch is better resolved by then (fix bugs on master in the 
>> meantime) 
>> and release the alpha then (whether or not the patch is completed).
>> 3) Create the 1.9 branch today to allow normal development to proceed 
>> on master and release the alpha by the end of the week with the option 
>> to 
>> backport the patch if it's completed.
>>
>> Opinions?
>>
>> On Monday, September 21, 2015 at 9:08:22 PM UTC-4, Tim Graham wrote:
>>>
>>> Let's consider master feature frozen for now. There are two more 
>>> patches I'd like to merge before we cut the 1.9 branch.
>>>
>>> #21231 -- Enforced a max size for POST values read into memory
>>> https://github.com/django/django/pull/3852
>>> Status: Needs final code reviews and probably some doc enhancements 
>>> (docs could possibly be deferred until after alpha). Florian & Shai, as 
>>> you've been taking the lead on reviewing this, please let us know your 
>>> thoughts.
>>>
>>> #24509 -- Added Expression support to SQLInsertCompiler
>>> https://github.com/django/django/pull/5324 
>>> Status: Josh working on some doc enhancements now, I will review in 
>>> the morning.
>>>
>>> On Friday, September 18, 2015 at 10:03:45 AM UTC-4, Marc Tamlyn 
>>> wrote:

 Sorry everyone :(

 On 18 September 2015 at 15:01, Tim Graham  
 wrote:

> The major features are officially deferred. Let's try for the 
> feature freeze by end of day on Monday and the alpha release on 
> Tuesday.
>
> There aren't any critical blockers at this time. Jani hasn't 
> completed the Oracle GIS work, but this isn't a must-have for alpha.
>
>
> On Saturday, September 12, 2015 at 7:50:31 PM UTC-4, Tim Graham 
> wrote:
>>
>> With 1 week to go until alpha:
>>
>> I haven't heard anything from Marc or Preston on the major 
>> features from the last mail.
>>
>> Jani continues to give updates in #django-dev about his progress 
>> on getting the Oracle GIS backend working. Things seem to be on 
>> track for 
>> finishing up by alpha.
>>
>> On Friday, September 4, 2015 at 3

Fellow Report - November 14, 2015

2015-11-14 Thread Tim Graham


Triaged

---

https://code.djangoproject.com/ticket/25701 - Add warning to an admin 
list_view if too many queries are being used (accepted)

https://code.djangoproject.com/ticket/25710 - Clarify the docs about what 
INTERNAL_IPS does (accepted)

https://code.djangoproject.com/ticket/25712 - Template overview 
documentation is not very approachable (accepted)

https://code.djangoproject.com/ticket/25721 - Allow dynamic raw_id_fields 
in admin system check (admin.E001) (duplicate)

https://code.djangoproject.com/ticket/25715 - refresh_from_db fails to 
update null'ed ForeignKeys (accepted)

https://code.djangoproject.com/ticket/25725 - UpdateCacheMiddleware can't 
cache a generator response (accepted)

https://code.djangoproject.com/ticket/25737 - Selenium test 
test_delete_stackeds from admin_inlines.tests.SeleniumFirefoxTests is 
failing (worksforme)

https://code.djangoproject.com/ticket/25454 - Module level database queries 
in a project prevent register_hstore from being called (accepted)

https://code.djangoproject.com/ticket/25672 - Clarify why related 
ManyToMany fields with a custom intermediary model disable the remove() 
method. (accepted)

https://code.djangoproject.com/ticket/25742 - "default_if_not_set" template 
filter (wontfix)

https://code.djangoproject.com/ticket/25669 - Adding postgresql 
publish/subscribe mechanism to django postgres contrib module (needsinfo)

https://code.djangoproject.com/ticket/25705 - Parameters are not adapted or 
quoted in Query.__str__ (accepted)

https://code.djangoproject.com/ticket/25733 - Change of inherited model's 
primary key not spotted by makemigrations (accepted)

https://code.djangoproject.com/ticket/25752 - RenameField on m2m causes 
error when new m2m field is added with old name (duplicate)

Authored



https://github.com/django/django/pull/5656 - Fixed admin_filters test 
failures when run in reverse.

https://github.com/django/django/pull/5654 - Corrected outdated information 
in submitting patches guide.

https://github.com/django/djangoproject.com/pull/543 - Created a separate 
"Recurring Donations" page.

Reviewed/committed

--

https://github.com/django/django/pull/5561 - Fixed #25686 -- Fixed crash on 
routers without an allow_migrate() method.

https://github.com/django/django/pull/5554 - Fixed #25683 -- Allowed 
ModelChoiceField(queryset=...) to accept Managers.

https://github.com/django/django/pull/5597 - Fixed #6727 -- Made 
patch_cache_control() patch an empty Cache-Control header.

https://github.com/django/django/pull/5545 - Fixed #24576 -- Made deletion 
of related objects deterministic.

https://github.com/django/django/pull/5580 - Fixed #25170 -- Made 
assertXMLEqual()/assertXMLNotEqual() ignore leading and trailing whitespace.

https://github.com/django/django/pull/5548 - Fixed #25618 -- Restored 
migration support for non-upgraded apps.

https://github.com/django/django/pull/5568 - Fixed #25693 -- Prevented data 
loss with Prefetch and ManyToManyField.

https://github.com/django/django/pull/5615 - Fixed #25720 -- Made gettext() 
return bytestring on Python 2 if input is bytestring.

https://github.com/django/django/pull/5640 - Fixed #25743 -- Optimized 
utils.localize() and localize_input()

https://github.com/django/django/pull/5563 - Fixed #25688 -- Made 
admin.register() disallow an empty list of models.

https://github.com/django/django/pull/5522 - Fixed #25169 -- Documented 
stacking of permission_required and login_required.

https://github.com/django/django/pull/5610 - Fixed #25469 -- Added 
autoescape option to DjangoTemplates backend.

https://github.com/django/django/pull/5642 - Fixed #25283 -- Fixed 
collectstatic crash if a URL contains a fragment with a path.

https://github.com/django/django/pull/5479 - Fixed #25606 -- Added support 
for "__" lookup in RelatedOnlyFieldList

https://github.com/django/django/pull/5575 - Fixed #25666 -- Fixed the 
exact lookup of ArrayField.

https://github.com/django/django/pull/5587 - Fixed #17686, refs #17816 -- 
Added "Files" section to Unicode topic

https://github.com/django/django/pull/5608 - Fixed #25531 -- Documented 
field lookups on admin_order_field.

Reviews of core dev work



https://github.com/django/django/pull/5625 -- Ticket 25693 enhancements

https://github.com/django/django/pull/5626 - Fixed #25730 -- Made 
Model.__str__() always return str instances.

https://github.com/django/django/pull/5618 - Fixed #25723 -- Made related 
field checks lookup against their local apps.
https://github.com/django/django/pull/5652 - Fixed #25745 -- Promoted 
RuntimeWarnings to errors in the test suite.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@goog

Re: #25582: Add a way to build URLs with query strings

2015-11-14 Thread Tino de Bruijn
Would it be an idea to have QueryDict accept a dictionary to construct it? Then 
you could use it’s urlencode method to create the querysting. Seems like a 
logical place to implement this to me.

Tino

> On 09 Nov 2015, at 14:30, Merijn Bertels  wrote:
> 
> I think would be a good thing if we create a function to support this. 
> But I don't think it should be build in the reverse function. 
> 
> Like to point out that the Admin ChangeList has a function on the class who 
> does something like this: 
> https://github.com/django/django/blob/master/django/contrib/admin/views/main.py#L153
>  
> 
> each ListFilter use this function to generate a new url.
> 
> The downside of this is that ListFilters can not be re-used without a 
> ChangeList. 
> 
> 
> 
> Op vrijdag 23 oktober 2015 09:41:42 UTC+2 schreef guettli:
> From  https://code.djangoproject.com/ticket/25582 
> 
> 
>  {{{
> It is a common question on stackoverflow and other places:
> 
> How to reverse() to url including GET parameters? Example: .../myview?foo=bar
> 
> ​http://stackoverflow.com/questions/9585491/how-do-i-pass-get-parameters-using-django-urlresolvers-reverse
>  
> 
> ​http://stackoverflow.com/a/27641445/633961 
> 
> It would be very nice if django could implement a short-cut which provides
> this.
> 
> It would be useful for python code and template, too.
> }}}
> 
> {{{
> If we do add it, it likely needs a discussion on the DevelopersMailingList 
>  to figure out 
> what the API should look like. See also #10941 
>  which asks for a template tag 
> for creating query strings in templates.
> }}}
> 
> What do you think?
> 
> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to django-developers+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to django-developers@googlegroups.com 
> .
> Visit this group at http://groups.google.com/group/django-developers 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/django-developers/d13c725a-5dd4-4eda-9168-cc603fc7374e%40googlegroups.com
>  
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/8A91C6C9-893E-4D02-8BCC-8489F4504F15%40gmail.com.
For more options, visit https://groups.google.com/d/optout.