Re: Suggestion: make auth login view more dynamic
Hi,
-1 from me here.
A) why don't you have site_name_name etc (those are still fixed).
B) templates need to be able to rely on a name, if your template expects a
different name user {% with form as my_form %}
Cheers,
Florian
On Wednesday, May 23, 2012 1:02:53 PM UTC+2, Hedde van der Heide wrote:
>
> I couldn't find an existing ticket but I'd like to suggest a change to
> make the basic auth view more dynamic (I'm not fond of hardcoded context
> variables :-))
>
> *change:*
>
> def login(request, template_name='registration/login.html',
> redirect_field_name=REDIRECT_FIELD_NAME,
> authentication_form=AuthenticationForm,
> current_app=None, extra_context=None):
>
> *to:*
>
> def login(request, template_name='registration/login.html',
> redirect_field_name=REDIRECT_FIELD_NAME,
> authentication_form=AuthenticationForm,
> current_app=None, extra_context=None, *form_name='form'*):
>
>
> *and obviously:*
>
> context = {
> *form_name: form,*
> redirect_field_name: redirect_to,
> 'site': current_site,
> 'site_name': current_site.name,
> }
>
>
> Kind Regards,
>
> Hedde van der Heide
>
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To view this discussion on the web visit
https://groups.google.com/d/msg/django-developers/-/9xWEYMsvTU8J.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en.
Re: Suggestion: make auth login view more dynamic
It seems to me there'd be more mileage in making new class-based
versions of the auth views.
- Andy
On 24 May 2012 13:51, Florian Apolloner wrote:
> Hi,
>
> -1 from me here.
>
> A) why don't you have site_name_name etc (those are still fixed).
> B) templates need to be able to rely on a name, if your template expects a
> different name user {% with form as my_form %}
>
> Cheers,
> Florian
>
>
> On Wednesday, May 23, 2012 1:02:53 PM UTC+2, Hedde van der Heide wrote:
>>
>> I couldn't find an existing ticket but I'd like to suggest a change to
>> make the basic auth view more dynamic (I'm not fond of hardcoded context
>> variables :-))
>>
>> change:
>>
>> def login(request, template_name='registration/login.html',
>> redirect_field_name=REDIRECT_FIELD_NAME,
>> authentication_form=AuthenticationForm,
>> current_app=None, extra_context=None):
>>
>> to:
>>
>> def login(request, template_name='registration/login.html',
>> redirect_field_name=REDIRECT_FIELD_NAME,
>> authentication_form=AuthenticationForm,
>> current_app=None, extra_context=None, form_name='form'):
>>
>>
>> and obviously:
>>
>> context = {
>> form_name: form,
>> redirect_field_name: redirect_to,
>> 'site': current_site,
>> 'site_name': current_site.name,
>> }
>>
>>
>> Kind Regards,
>>
>> Hedde van der Heide
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/django-developers/-/9xWEYMsvTU8J.
>
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to
> django-developers+unsubscr...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/django-developers?hl=en.
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en.
Re: Suggestion: make auth login view more dynamic
@Andy, I agree, it's perfectly possible to create you own auth backend now, so
theres no need to change it if new views are sceduled. It just felt as a
repetitive exercise
@Florian, The other context variables should be dynamic aswell. I don't agree
with your template logic. Django always seems to pass this 'form' name in,
which is a problem when you have a page with multiple forms coming form django
itself (for example: registration and auth). Ofcourse there's logic
workarounds, but still, I don't think those should be hardcoded.
Hedde
Op 24 mei 2012, om 14:57 heeft Andrew Ingram het volgende geschreven:
> It seems to me there'd be more mileage in making new class-based
> versions of the auth views.
>
> - Andy
>
> On 24 May 2012 13:51, Florian Apolloner wrote:
>> Hi,
>>
>> -1 from me here.
>>
>> A) why don't you have site_name_name etc (those are still fixed).
>> B) templates need to be able to rely on a name, if your template expects a
>> different name user {% with form as my_form %}
>>
>> Cheers,
>> Florian
>>
>>
>> On Wednesday, May 23, 2012 1:02:53 PM UTC+2, Hedde van der Heide wrote:
>>>
>>> I couldn't find an existing ticket but I'd like to suggest a change to
>>> make the basic auth view more dynamic (I'm not fond of hardcoded context
>>> variables :-))
>>>
>>> change:
>>>
>>> def login(request, template_name='registration/login.html',
>>> redirect_field_name=REDIRECT_FIELD_NAME,
>>> authentication_form=AuthenticationForm,
>>> current_app=None, extra_context=None):
>>>
>>> to:
>>>
>>> def login(request, template_name='registration/login.html',
>>> redirect_field_name=REDIRECT_FIELD_NAME,
>>> authentication_form=AuthenticationForm,
>>> current_app=None, extra_context=None, form_name='form'):
>>>
>>>
>>> and obviously:
>>>
>>> context = {
>>> form_name: form,
>>> redirect_field_name: redirect_to,
>>> 'site': current_site,
>>> 'site_name': current_site.name,
>>> }
>>>
>>>
>>> Kind Regards,
>>>
>>> Hedde van der Heide
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Django developers" group.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msg/django-developers/-/9xWEYMsvTU8J.
>>
>> To post to this group, send email to django-developers@googlegroups.com.
>> To unsubscribe from this group, send email to
>> django-developers+unsubscr...@googlegroups.com.
>> For more options, visit this group at
>> http://groups.google.com/group/django-developers?hl=en.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers" group.
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to
> django-developers+unsubscr...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/django-developers?hl=en.
>
Met vriendelijke groet,
Hedde van der Heide
Developer & Sales
intellimedia.nl
[T] +31(0)6 - 11 717 441
[E] h.vanderhe...@intellimedia.nl
---
TWITTER @intelli_media
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en.
Re: Redesign of djangoproject.com?
Hi Ashraful, First of all, thank you for contributing with your ideas for this project. Your mockup is one of the most aesthetically pleasing so far IMHO but there are some issues that need addressing before it could be replace the current design. Since the mockup to feedback ratio in this thread seems distant from 1 at the moment, I wanted to contribute to the discussion, so please bear with me. I really like your overall use of whitespace, especially right at the top. My first thought after seeing the design is that it doesn't feel cluttered, and this is my biggest issue with the current layout. But the more I looked into it, the more I noticed key areas are missing. Russel has mentioned several times that djangoproject.com is not only for developers. We need to "sell" the project to sponsors who provide publicity and financial support, and managers who can foment adoption of our most loved framework in design shops around the globe and corporate environments seeking modern solutions to everyday challenges. It could be argued that developers themselves don't need a "download" button. Django is hosted on at least half a dozen platforms and the ways to access these are also greatly diverse. I'm one of those who believe that familiarity with python packages and VCS tools are paramount to the success of Django developers, so pip and git are probably more relevant in today's world than tarballs. We also need to do address how Django relies on the community to prosper, and anyone can contribute. Users can submit tickets, developers can patch code, newbies can write docs and many more. This also needs to stand out in the layout. I like your use of silver and to be honest, it goes with green much better than our current beige, whilst looking more professional, clean and modern. I see no reason for keeping *everything* silver, however. Surely we could include a dash of green in the middle and bottom section, don't you agree? I also don't think the blog posts are layed out in a particularly elegant way. There's no telling what the most recent post is, and laying them out on a grid seems like a waste of valuable space. Perhaps you could split that into a main area on the left and additional, less prominent info on the right? A lot of the previous mockups made great suggestions on addition content that you could incorporate, like videocasts for example. Last but not least, I don't get the logo. It's not that it doesn't look good, but it simply doesn't fit Django. The framework is not in any way related to chatting, so the speech bubble feels out of place. As for the icons, they're somewhat random and fail to illustrate what the project is about. "The web framework for perfeccionists with deadlines" is a very abstract concept. If we can't come up with a concrete drawing of that vision, we should at least be inspired to design a conceptual and abstract piece that resonates with the notions of "framework", "perfeccionism", and "deadlines". Django's most admired strength is how it manages to solve the trade off between robustness and complexity in a seemingly natural way, and we should convey that. Before getting back to work, take a look at the previous mockups and the criticism that followed. There's a lot to be learned from what others did well, and it might also help you avoid the same pitfalls. Cheers, André Terra -- Sent from my phone, please excuse any typos. -- On May 23, 2012 9:38 PM, "Ashraful Sheikh" wrote: > Hi everyone, > > I saw this on HackerNews(news.ycombinator.com) and wanted to contribute. > Here is my mockup: http://i.imgur.com/dSMSJ.jpg > > With the design, I focused on keeping the look extremely clean, > professional and minimalistic. The content is based on that of the current > site. The mockup may seem a bit lacking in color, but adding eye-catching > icons for the features, and the screens for the "built with Django" section > will add sufficient color to liven up the design. On wider screens, the > blog posts will appear in a siderbar to the left of the features list. > > If you guys like it, email me at inl...@gmail.com, or reply here. You can > check out my previous work at madebyargon.com. Some of you may have seen > the redesign I did for VideoLAN (videolan.org) which receive a positive > reaction from the open-source community surrounding VLC. > > Thanks. > > On Saturday, April 28, 2012 2:05:27 PM UTC+6, Russell Keith-Magee wrote: >> >> Hi Dana, >> >> I completely agree. I've been trying to get a redesign of >> djangoproject.com going for quite some time under the auspices of the >> Django Foundation. As you can see from the lack of changes, you can see >> that I haven't been particularly successful :-( >> >> The fundamental problem is that we have plenty of coding talent at our >> disposal, but not as much design talent. That's not to say that there >> aren't many talented designers in our community -- there are -- it's just >> that they're all very busy. We've approac
Re: Redesign of djangoproject.com?
Here is an updated version of the design. http://i.imgur.com/PKUHM.jpg Let me know what you guys think. The icons and content are simply placeholders and can be changed later on. My experience is in web and UX design and am not a good illustrator or icon designer, so someone more experienced in those areas should ideally be creating the icons and the top illustration. In the design, I still kept the primary call-to-action geared towards new users, because I feel that they would be the ones needing most guidance. People who are existing users or are experienced developers would be much more likely to be able to find what they are looking for by searching, going through the navigation or scrolling down the page, without needing a large button "above the fold". Looking forward to more feedback regarding the design. Thanks. On Thursday, May 24, 2012 7:57:26 PM UTC+6, Andre Terra wrote: > > Hi Ashraful, > > First of all, thank you for contributing with your ideas for this project. > Your mockup is one of the most aesthetically pleasing so far IMHO but there > are some issues that need addressing before it could be replace the current > design. > > Since the mockup to feedback ratio in this thread seems distant from 1 at > the moment, I wanted to contribute to the discussion, so please bear with > me. > > I really like your overall use of whitespace, especially right at the top. > My first thought after seeing the design is that it doesn't feel cluttered, > and this is my biggest issue with the current layout. But the more I looked > into it, the more I noticed key areas are missing. > > Russel has mentioned several times that djangoproject.com is not only for > developers. We need to "sell" the project to sponsors who provide publicity > and financial support, and managers who can foment adoption of our most > loved framework in design shops around the globe and corporate environments > seeking modern solutions to everyday challenges. > > It could be argued that developers themselves don't need a "download" > button. Django is hosted on at least half a dozen platforms and the ways to > access these are also greatly diverse. I'm one of those who believe that > familiarity with python packages and VCS tools are paramount to the success > of Django developers, so pip and git are probably more relevant in today's > world than tarballs. > > We also need to do address how Django relies on the community to prosper, > and anyone can contribute. Users can submit tickets, developers can patch > code, newbies can write docs and many more. This also needs to stand out in > the layout. > > I like your use of silver and to be honest, it goes with green much better > than our current beige, whilst looking more professional, clean and modern. > I see no reason for keeping *everything* silver, however. Surely we could > include a dash of green in the middle and bottom section, don't you agree? > > I also don't think the blog posts are layed out in a particularly elegant > way. There's no telling what the most recent post is, and laying them out > on a grid seems like a waste of valuable space. Perhaps you could split > that into a main area on the left and additional, less prominent info on > the right? > > A lot of the previous mockups made great suggestions on addition content > that you could incorporate, like videocasts for example. > > Last but not least, I don't get the logo. It's not that it doesn't look > good, but it simply doesn't fit Django. The framework is not in any way > related to chatting, so the speech bubble feels out of place. As for the > icons, they're somewhat random and fail to illustrate what the project is > about. > > "The web framework for perfeccionists with deadlines" is a very abstract > concept. If we can't come up with a concrete drawing of that vision, we > should at least be inspired to design a conceptual and abstract piece that > resonates with the notions of "framework", "perfeccionism", and > "deadlines". Django's most admired strength is how it manages to solve the > trade off between robustness and complexity in a seemingly natural way, and > we should convey that. > > Before getting back to work, take a look at the previous mockups and the > criticism that followed. There's a lot to be learned from what others did > well, and it might also help you avoid the same pitfalls. > > > Cheers, > André Terra > > -- Sent from my phone, please excuse any typos. -- > > > On May 23, 2012 9:38 PM, "Ashraful Sheikh" wrote: > >> Hi everyone, >> >> I saw this on HackerNews(news.ycombinator.com) and wanted to contribute. >> Here is my mockup: http://i.imgur.com/dSMSJ.jpg >> >> With the design, I focused on keeping the look extremely clean, >> professional and minimalistic. The content is based on that of the current >> site. The mockup may seem a bit lacking in color, but adding eye-catching >> icons for the features, and the screens for the "b
Re: Redesign of djangoproject.com?
Hi folks -- Thanks so much to everyone who's participated in this thread; I feel like there's a lot of useful discussion and brainstorming going on. The DSF board met yesterday and discussed the effort -- we're determined to get this done soon. Unfortunately, we ultimately think that this collaborative effort isn't working: there's a lot of great ideas, but some of the discussion is veering closer to "design by committee", and nobody's really empowered to move things forward. Ultimately and sadly, though, great design is at odds to a community process: the only way we know to get something we *love* is to find someone awesome and let them do their thing. So here's the plan: in the next month we're do exactly that: find someone awesome, and give them carte blance on the redesign. We'll of course give feedback, and touch base with the community a few times, but ultimately we're going to put this thing into one person's hands. If you'd like to become the Benevolent Dictator For This Redesign, then please send a proposal to . This doesn't need to be formal; we just need to know two things: 1. Can you deliver? Convince us that you'll actually be able to get this done: show us a track record of shipping, and explain why you'll have time to work on this. We'd like to see this land before DjangoCon US in September; can you hit that? 2. Are you awesome? Convince us that your design will rock. This can come in the form of a mockup, or previous work, or whatever. Again we don't need formal stuff here, and we certainly don't expect spec work. We just want to make sure your aesthetic matches ours. A few further notes: * I want to stress the informality of this. We don't need or want a full formal proposal like you would for a real client; we just want to know that you're awesome and can deliver. If you can prove that to us in a few words, do it! * You don't have to do this all yourself; we have quite a few volunteers. Importantly, we have *plenty* of people who can help on the backend (natch), so really all we need is someone who's great at the design side. How much of the actual coding you do is up to you. If you've got weaknesses that's complete fine, just tell us what help you need and we'll fill it in. You'll be in charge visually and aesthetically, but we'll encourage you to delegate as much as you can. * We don't currently have a budget assigned; we're thinking this'll be volunteer work. However, the DSF *does* have some funds, and if money makes the difference we'll spend it. So if you need money to make it happen, tell us. We won't penalize you if you need to get paid (but at the same time we hope you recognize we probably can't afford market rates). * The deadline is Sunday, June 17th, and we'll aim to make a decision that week. Thanks everyone! Jacob PS: I'm deliberately burying this down in the thread instead of posting this more publicly. I'd like to avoid this becoming a general call; I'm more interested in reaching people who're *already* paying attention to this effort. I'd appreciate it, then, if you'd keep this call off Reddit, Hacker News, etc. However, if you know someone who you think *should* be interested, please forward it onto them! -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
Re: Suggestion: make auth login view more dynamic
Hi Hedde, On Thursday, May 24, 2012 3:08:22 PM UTC+2, Hedde van der Heide wrote: > > @Florian, The other context variables should be dynamic aswell. > No they shouldn't be made dynamic at all (none of them!) -- As Andy suggested CBV are a way better option. > I don't agree with your template logic. Django always seems to pass this > 'form' name in, which is a problem when you have a page with multiple forms > coming form django itself (for example: registration and auth). > But those two forms never end up in the same template, so there is no possibility of a clash etc, login goes to /registration/login.html, registration iteself to /registration/somethingelse.html. And if you really send them to the same template you can't use the builtin views and have to write a new view yourself either way... Cheers, Florian -- You received this message because you are subscribed to the Google Groups "Django developers" group. To view this discussion on the web visit https://groups.google.com/d/msg/django-developers/-/pcVmO4x9Sv0J. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
