Re: Oracle savepoints

2009-05-17 Thread Richard Davies

Matt Boersma wrote:
> I think Malcolm implemented this in the Oracle backend rather than Ian
> K. or myself.

It was Ian Kelly, I think in [10022].

> So I'd say the answer is a).

If that's right, then we have an inefficiency on Oracle at present -
the uses_savepoints flag is used both to signal that savepoints are
implemented (see BaseDatabaseWrapper._savepoint*() in django/db/
backends/__init__.py), and to signal that they are needed to wrap code
which may throw IntegrityErrors (as per reason b; see
QuerySet.get_or_create() in django/db/models/query.py).

We should probably be splitting these two meanings, so Postgresql
would have:

can_savepoint = True
needs_savepoint_after_exception = True

Whereas Oracle would have:

can_savepoint = True
needs_savepoint_after_exception = False

I'll open a ticket to remember this once Ian, Malcolm or another also
confirms.

Cheers,

Richard.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---



Buildbot config for postgresql with database-level autocommit

2009-05-17 Thread Richard Davies

Hi all,

I'm wondering how to add a configuration to Leo Soto's Hudson buildbot
at http://testing.ingenium.cl/hudson/job/django-trunk/ ? (Assuming
that this is the canonical buildbot and that it is still in use!)

At present it seems to run with settings for sqlite3, mysql,
postgresql and oracle.

We now also have the postgresql autocommit mode (http://
docs.djangoproject.com/en/dev/ref/databases/#autocommit-mode) and I'd
like to get a buildbot running with those settings too.

Should be easy - just duplicate the postgresql set up and additionally
set the autocommit key.

How can I help do this?

Richard

(Prompted by mir's comment on #10958)
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---



[GSoC] model validation - update

2009-05-17 Thread Honza Král

Hi all,
I didn't get much work done as I was waiting for feedback for
questions I posted in last week's status. I didn't get many replies
(big thanks to all that sent theirs) and it appears that the common
use case would justify going for the most powerfull interface:

def validator(value, all_values={}, model_instance=None): ...

I will start actual work the week after the next one, I will start
with porting the unique validation and writing more tests (possibly
migrating some tests from doctest to unittests).

Honza Král
E-Mail: honza.k...@gmail.com
Phone:  +420 606 678585

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---